View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0012161 | MMW 5 | General | public | 2014-09-01 13:31 | 2023-05-17 19:44 |
| Reporter | user_chrisjj | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Windows | OS | 7 | OS Version | - |
| Fixed in Version | 5.1 | ||||
| Summary | 0012161: Rating zero stars incorrectly adds a non-standard tag property | ||||
| Description | Help http://www.mediamonkey.com/sw/webhelp/frame/index.html?abouttrackproperties.htm [^] says: WMA Rating Yes [full stars] (SharedUserRating) Non standard [Half-stars] (SDB/Rating) (which I read to mean that standard values should create only the standard WM/SharedUserRating tag field) but zero stars sets adds a (non-standard) SDB/Rating tag field. Detail at http://www.mediamonkey.com/forum/viewtopic.php?f=7&t=42932&p=394774#p394774 [^] | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2800 | ||||
|
|
OK, documentation is not clear in this, there should be "Non standard [Half-stars, full stars] (SDB/Rating)". What is the problem with writing SDB/Rating for all values? It is standard custom WMA tag, applications, which do not understand this tag, simply ignore it. |
|
|
Documentation to be corrected... |
|
|
Actually, documentation states: Non-Standard indicates that it is saved in the media file tags, but that no clear standard exists for how this field should be tagged, and consequently it may not be readable by other media players. ...which is correct in this case, so probably nothing to do here. |
|
|
1) I agree the documentation for Non-standard is correct, but that's not material to the issue, so I disagree this correctness means nothing to do. 2) At https://www.mediamonkey.com/forum/viewtopic.php?p=503827#p503827 Jiri wrote "The documentation doesn't state that non-standard tags aren't present when standard tags are". I agree, but that's not the issue. 3) The issue is as stated: "standard values should create only the standard WM/SharedUserRating tag field) but zero stars sets adds a (non-standard) SDB/Rating tag field". The behaviour does not accord with documentation "Non standard [Half-stars] (SDB/Rating)" given zero is not half-star and hence should not generate SDB/Rating. 4) Michal wrote: "documentation is not clear in this". I believe the documentation is clear, regardless that it and behaviour fail to accord. "there should be "Non standard [Half-stars, full stars] (SDB/Rating)"." That would additionally fail to accord with behaviour in the case of non-zero full stars, given they do not generate SDB/Rating. 5) Michael asked "What is the problem with writing SDB/Rating for all values?" Such a change would spread the problem to non-zero half-stars. "applications, which do not understand this tag, simply ignore it." Some may, others may not e.g. tagging programs such as Mp3tag will display it. 6) I believe the documented behaviour is proper. It ensures standard use of stars (i.e. full only) does not litter the tracks files with a non-standard fields. 7) The proper fix is to adjust behaviour to match documentation i.e. make zero stars not generate SDB/Rating. This rectifies the current littering of track files with redundant SDB/Rating fields, 8) I suggest this issue status be set to Open. 9) Perhaps an MM5 user would like to verify this issue is present there and carry this issue over. |
|
|
Deleting not set rating fixed for WMA/WMV in build 2800. I have analyzed the issue and it is correct. Problem is, that WM/SharedUserRating does not support zero rating, 0 in this tag means "not rated" (source: https://learn.microsoft.com/en-us/previous-versions/ms867702(v=msdn.10) ) MM distinguishes between "not rated" and "rated by zero stars". The second cannot be stored to WM/SharedUserRating. I have corrected description of this tag in doc: https://www.mediamonkey.com/wiki/WebHelp:About_Track_Properties/5.0 Also, saving only half stars and zero stars to SDB/Rating is not a good idea, some scripts and software could use this tag for years and always had value there, it would break consistency of this tag to save there only half (and zero) stars. |
|
|
> Deleting not set rating fixed for WMA/WMV in build 2800. I would not like to guess what behaviour/doc "Deleting not set rating" refers to. Regardless Mantis shows no issue "Deleting not set rating" or similar fixed in build 2800. It does show this issue "Rating zero stars incorrectly adds a non-standard tag property" fixed in build 2800. But your note here shows nothing that looks like any change to build 2800. > I have analyzed the issue and it is correct. I can't tell from that what you've found correct - report, behaviour and/or documentation. But from your note here I guess what you've found correct is report and behaviour. > I have corrected description of this tag in doc: https://www.mediamonkey.com/wiki/WebHelp:About_Track_Properties/5.0 Great. That is now: WMA Rating Yes (WM/SharedUserRating - rounded to full stars), Non-standard (SDB/Rating - also half and zero stars) I agree that that change fixes this issue in 5.0. Previously "Rating zero stars incorrectly adds a non-standard tag property" and now rating zero stars correctly adds a non-standard tag property. > Also, saving only half stars and zero stars to SDB/Rating is not a good idea, some scripts and software could use this tag for years and always had value there, I.e. scripts and software could be ignoring the docs and relying on full stars in SDB/Rating . > it would break consistency of this tag to save there only half (and zero) stars. I agree. Your addition of "also" fixes that. Thanks. Though I think explicit "full, " would be safer. You could easily make the same fix to MM4: https://www.mediamonkey.com/wiki/WebHelp:About_Track_Properties/4.0 . |
|
|
Not deleting removed rating was small bug found during analyzing this issue (we saved -1 instead of removing tag completely) By correct - I mean using custom tag for storing zero value. |
|
|
Verified 2804 |
