View Issue Details

IDProjectCategoryView StatusLast Update
0015695MMW 5FileMonitor / Find Missingpublic2019-09-09 01:57
Reporterrusty Assigned To 
PriorityurgentSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version5.0 
Target Version5.0Fixed in Version5.0 
Summary0015695: Problems (including several path-related issues) migrating content/DB to a new disk
DescriptionTested on build 2177

1 Copy portable instance of MM5 + associated tracks to a new disk
2 Run MM5 and attempt to play tracks
-->(1) Content on the new disk fails to play!! (I guess that this is related to new drive ID, though it appears that something else may be occurring since the paths change. i.e.
- prior to the upgrade, content appeared as: D:\My Documents\My Downloads\Amelie\18 - Le Banquet.mp3
- after the upgrade, content shows as: [Data]\My Documents\My Downloads\Amelie\18 - Le Banquet.mp3
2 Use Files to edit > dead link to find all the problematic tracks
-->(2) Files to edit > dead links does not contain any of the inaccessible tracks!!
3 Try to fix the problem by manually selecting several of the problematic tracks and using 'Locate moved and missing tracks'
--> Problem is corrected (for the manually selected tracks),
- Old path: [Data]\My Documents\My Downloads\Amelie\18 - Le Banquet.mp3
- New path: D:\My Documents\My Downloads\Amelie\18 - Le Banquet.mp3
--> (3) But, the view fails to update with the new paths!!

------------------4m20s - 12m30s of the second video can be ignored-----------
In this section of the video I was confused between navigation of Folders vs Library (the folders being correct, the library being incorrect)
---------------------------------------------------------------------------------------------

4 Attempt to fix the problem for all tracks on D: [Data] by editing the drive at Home > Folders > D:\[Data]
--> (4) F2 doesn't allow the drive to be renamed! Would this be easy to change?
5 Attempt to fix the problem for all tracks on D:[Data] by selecting D:[Data] and then showing all contained tracks recursively
--> (5) Show Recursively button isn't displayed for the drive (it only displays for folders within the drive ?perhaps since no tracks are in the root?)!
6 Select all tracks in D:\[Data] > My Documents > All
--> It takes MM about 10 minutes to display all the tracks! (I'll enter this in a separate bug-it's just a performance issue)
7 Use Locate Moved or Missing Files for all 10000 of the selected tracks
--> (6) On some occasions (see the end of the second video & associated log-2) the dialog doesn't display, and MM must be force terminated because the UI is in a greyed-out state as if the dialog is in focus even though it doesn't appear anywhere (not even in back of the main UI)!! (note: I have see this happen on a couple of occasions previously)
--> (7) In cases where the dialog does work, all of the tracks are listed in the 'Unmoved files' tab (and none are in 'Files located in new locations' or 'Unlocatable files' (i.e. the functionality doesn't work in this case even though it worked on the 3 tracks at step 3)! Strangely, the tracks in 'Unmoved files' display with a path of D:\My Documents\Temp unlike at step 3 where they were displayed with an old path of [Data]\My Documents\My Downloads\Amelie\18 - Le Banquet.mp3.

Note:
- Initial debug log shows problems (1) and (2). Debug at ftp.
- Follow-up debug & video shows bugs (1) - (7). Debug log 2 at ftp.
- Also, on closing, the error "Cannot read property 'createSharedList' of undefined " sometimes occurs (bug 0015694 ), so it may be related.

Note: I've set this to 'Immediate' as it's interfering with testing on my new machine
TagsNo tags attached.
Attached Files
Fixed in build2179

Relationships

related to 0015696 closedmichal Locations node does not sometimes display tracks, when DB migrated from MM4 
related to 0015524 closedpetr Issues with 'Locate moved/missing files...' 
related to 0015605 closedpetr Locate Moved/Missing tracks: Updating Located File path is slow 
related to 0015603 closedpetr Locate Moved/Missing tracks: Prepare track list takes too long 
related to 0015705 closedLudek Properties: can't manually edit paths of inaccessible files 
has duplicate 0015921 closedrusty Audiobooks fail to download over UPnP 
related to 0015699 closedpetr Locate Moved/Missing Files dialog fails in some cases 
related to 0015728 closedpetr Can't delete unused file path 
related to 0015729 feedbackrusty Improvements to facilitate migration to a new drive 

Activities

rusty

2019-05-27 16:33

administrator   ~0053640

Last edited: 2019-05-28 17:17

I've noticed another problem: (8) all podcasts appear in Podcasts > Location > [OS]\Users\Russell\Music\Podcasts\.... (originally they were in Podcasts > Location > C:\Users\Russell\Music\Podcasts\.... , though the drives breadcrumb appears as Podcasts > Location > C:[OS > ..... )

Reduced the priority to Urgent since I was able to kind of get this to work after numerous tries with Locate Moved and Missing.

Ludek

2019-05-28 13:15

developer   ~0053650

Last edited: 2019-05-28 15:28

Re items 1,2,4:
I tested the scenario both using MM4 portable and MM5 portable and I see the same behaviour also using MM4.
I guess that it has always been the case that one needs to use "Locate Moved/Missing" feature once moved to a new computer.
Both MM4 and MM5 shows the paths like '[Data]/Music', '[OS]/Podcast' until the locate moved/missing is used, also the [Files to Edit > Deadlinks] shows no tracks (in MM4 too).

EDIT: As for the not showing under "Deadlinks" (4) -- in the original MM4 code I see a comment:
// Don't test inaccessible songs, just these on present media
By using the SVN Blame I see that it is there from the initial SVN version (since 2005) -- i.e. earlier than I started to work for MM ;-)

5) I see the "Display folder content recursively" button on the toolbar and it works for me within the drive, isn't this just a test error? Or maybe related to 6 ?
EDIT: I saw the second video and now I understand the test error: You tested the "Folders" node (aka "My Computer" in MM4) -- while I was testing [Music > Location] node.
This is the reason why I was seeing the "old drive" and the "Display folder content recursively" button

6) I cannot replicate, but you wrote that you are entering the issue separately?
EDIT: I saw the second video and now I see the issue: You tested the "Folders" node (aka "My Computer" in MM4) -- therefore it took so long to read the list -- as it reads all the info from file tags for every file (not from the database)
i.e. You will see the same performance when using [MM4 > My Computer > D: > My Documents > All] (with DbgView closed)

As for the issues with "Locate moved/missing tracks" (3, 6,7) -- these are related to 0015524 , 0015603, 0015605 that have been already fixed by Petr, to be assigned to him to look into it...
EDIT
Re: (7) In cases where the dialog does work, all of the tracks are listed in the 'Unmoved files' tab
=> this is again the consequence of selecting the tracks under "Folders" (aka My Computer) node -- such a files are really unmoved (the same behaviour in MM4 when you select the files under "My Computer" node)

---------------------------------------------
Related note: I remember that reading the data from the file-system (and not from MM.DB) has been always root of the confusion under "My Computer" node, and I guess that it is even more confusing in MM5 when the node is renamed just to "Folders".
Any ideas how to solve this? A better wording for "Folders" node and/or a toast message explaining that the data is not read from the database?

rusty

2019-05-28 17:52

administrator   ~0053651

Last edited: 2019-05-28 18:03

(1)/(8): Yes in previous versions of MM, the user had update the paths using the 'Find moved/missing' functionality. What seemed new here is that after switching the drive, the _label_ had also changed to [Data] or [OS] (for podcasts). It's possible that the label change occured in MM4...I don't remember, but wanted to bring it to your attention.

(2): Re. not showing up in deadlinks, I guess that the change was made in relation to content that is stored on a USB drive that is unplugged. But how else can the user fix the problem?! e.g. even in our KB we tell users to select the problem files and then use the 'Find Moved/Missing' function: see 3e) at http://www.mediamonkey.com/support/index.php?/Knowledgebase/Article/View/92/0/why-is-music-greyed-out--fails-to-play

Aside: I think that not showing deadlinks at all isn't the right approach. i.e. in cases where all content on a drive is missing, MM should at least show that the drive is missing and allow the user to optionally expand that content.

(4) Yes I realize that renaming the label isn't supported in MM4--I'm just trying to figure out a quick/obvious solution to such cases. i.e. even the solution proposed in the KB above is too complex for most users. Probably the simplest approach would be to modify the Find moved/missing dialog so that it _automatically_ searches selected directories for _all_ files that can't be found.

(5) You're right--test error (along with the performance issue that I mentioned I'd track elsewhere.

Find Moved/Missing
(3) After the dialog functions correctly, the view fails to update with the new paths.
(6) On some occasions MM UI greys out and the dialog doesn't display. This might be related to 0015492?

Ludek

2019-05-28 18:21

developer   ~0053652

(2) Maybe another sibling of the "Dead links" node called "Inaccessible files" ?
My understanding was that "inaccessible files" are not "dead links", by checking the code the "deadlinks" were always files no longer existing on accessible media

rusty

2019-05-28 18:47

administrator   ~0053653

Last edited: 2019-05-28 18:48

Per discussion with Ludek, issues (1), (2), (4), (8) are long-standing usability issues. The solution to all of them could be a combination of:
(A) Include in Files to Edit: 'Dead links' (to refer to bad links on connected drives) and 'Disconnected' (to refer to content on drives that aren't connected). Note: this is based on Ludek's comment above, but modified to improve the distinction between Dead link and Inaccessible.
(B) The ability to edit drive labels to match actual folders ('Rename')
(C) Probably the best approach would be to modify the Find moved/missing dialog so that it can automatically search selected directories for files that can't be found. e.g.

Find moved/missing files
=====================
Find files missing from:
 [ ] Selected files
 [ ] C:
 [ ] D:
 [ ] ...
-------------------------------
Search for the files in:
> [ ] C::
> [ ] D:
...
...
-------------------------------------
[ ] Hide unselected items
__________________________ [Add]

I'm leaving this issue open for 5.0 for triage by devs should any of A,B,C be trivial to implement.

Items (3), (6) must be fixed for 5.0, but will be moved to a separate bug.

Ludek

2019-05-28 19:38

developer   ~0053654

Last edited: 2019-05-28 19:39

As for the triviality, the most trivial is (A). The most problematic is (C) as it spans tracks across multiple drives (to be located on another set of multiple drives).

So I guess we can implement (A) for MM 5.0 (as it is trivial) and leave (C) for 5.1.

Ludek

2019-05-29 13:44

developer   ~0053656

(A) is implemented in 2179

rusty

2019-06-07 18:12

administrator   ~0053775

Verified 2179.