View Issue Details

IDProjectCategoryView StatusLast Update
0016788MMW 5Main Panelpublic2020-08-27 23:55
Reporterlowlander Assigned To 
PriorityurgentSeveritymajorReproducibilityrandom
Status closedResolutionfixed 
Product Version5.0 
Target Version5.0Fixed in Version5.0 
Summary0016788: Constant Loading message in Filelistings
DescriptionFrequent Loading message is shown in Filelisting while nothing is being done on that node.
TagsNo tags attached.
Attached Files
Loading.zip (454,554 bytes)
Fixed in build2260

Relationships

related to 0016787 closedLudek Media Tree Node selection changes, possibly due to scanning 

Activities

Ludek

2020-07-06 10:37

developer   ~0058773

Last edited: 2020-07-06 10:48

The loading is caused by MM trying to auto-update the folderlist/tracklist after a track property change.
But the problem is that there is a bunch of lists to update and it seems that there must be some leaking lists, as e.g. in the log I see:

Task took 9735 ms, stack: TSharedUIList<T>.processTableUpdate, list type: albumlist, count: 31721, created ago: 70328937ms, stack: Callstack: Script: file:///viewHandlers.js ; Func: _getChildrenList ; Row: 5413 ; Col: 43
i.e. there is an album list with 31721 albums that is all re-read from the DB after a track property change, but this list was created ago 70328937 ms which corresponds to 19 hours!

There are also some others lists that leaks by evidence:
list type: tracklist, count: 13, created ago: 70340156ms, stack: Callstack: Script: file:///viewHandlers.js ; Func: getViewDataSource ; Row: 5465 ; Col: 30
list type: tracklist, count: 2279, created ago: 45657859ms, stack: Callstack: Script: file:///viewHandlers.js ; Func: __refreshTracklist ; Row: 196 ; Col: 57
list type: tracklist, count: 30468, created ago: 45683484ms, stack: Callstack: Script: file:///viewHandlers.js ; Func: __refreshTracklist ; Row: 196 ; Col: 57
list type: tracklist, count: 30468, created ago: 9668812ms, stack: Callstack: Script: file:///viewHandlers.js ; Func: __refreshTracklist ; Row: 196 ; Col: 57

Updating of these leaking lists is slowing updating of the folder lists resulting in the constant "Loading..." as shown on the video.

i.e. the key is to find and fix leaking of the lists (tracklist/albumlist) above.

Ludek

2020-07-06 15:49

developer   ~0058776

Last edited: 2020-07-06 15:51

I fixed some leaking that could be a cause of this issue, but I cannot be certain as the albumlist leak (with 31721 albums) was 19 hours old in your debug log -- so it is impossible to see why and where the leak arised.

Please re-test in 2260 this way:
1) start DbgView
2) start MM5 and try to access/visit various nodes
3) wait for 60 seconds -- this is the time for which the lists for last 3 views are loaded/cached in memory (to re-use them when quickly navigating)
4) After that time the lists are freed and shouldn't be part of the auto-update after a track change, to ensure please change a property of a track (e.g. rate a track)
=> in the debug log only the lists visible in the UI should be auto-updated (re-read from the database)

i.e. if there is a line like
[10248] MM5 [7368](R) BQ: Thread[7368] is executing new task now: TSharedUIList<T>.processTableUpdate, list type: albumlist, count: 13, created ago: 24344ms, stack: Callstack: Script: file:///controls/artistView.js ; Func: updateView ; Row: 207 ; Col: 44
then the album list with 13 albums needs to be visible on the screen, otherwise there is a leak.
Send me the log for analyzing if you are not certain

peke

2020-07-11 00:55

developer   ~0058874

Verified 2260

Unable to replicate.

Ludek

2020-07-13 17:32

developer   ~0058932

Fixed in 2261 together with 0016787

peke

2020-07-23 12:46

developer   ~0059090

Verified 2261

I am unable to reproduce this anymore.

peke

2020-08-27 23:55

developer   ~0059499

Verified 2265

Unable to replicate.