View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0017505 | MMW 5 | Playback | public | 2021-02-08 00:30 | 2022-08-19 21:22 |
Reporter | drakinite | Assigned To | |||
Priority | urgent | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | 5.0 | ||||
Target Version | 5.0.4 | Fixed in Version | 5.0.4 | ||
Summary | 0017505: Playback stutters when a large number of tracks change rating (WASAPI only?) | ||||
Description | User reported that when album rating is changed, while playing, audio playback stutters: https://www.mediamonkey.com/forum/viewtopic.php?p=478021#p478021 I can currently only reproduce when output is set to WASAPI. (Waiting for user to confirm). Based on user report: 1) Play an album, or a large selection of tracks. 2) Select the entire album (or the large number of tracks), including the track that is currently playing 3) R-click > My rating > Select some arbitrary rating 4) When the tracks are being tagged, the audio stutters slightly. However, I can reproduce just by editing the rating of the currently playing track. i.e., while track is playing, select a different rating from within the player. Playback stutters for a fraction of a second. Waiting for user to confirm: a. whether it's only reproducible on WASAPI b. whether they can reproduce by just editing the one track, instead of a whole album Note: Stuttering is easier to notice if you disable smooth pause, smooth seek, and smooth stop. | ||||
Tags | No tags attached. | ||||
Fixed in build | 2660 | ||||
|
Test results: for Playing a track, and changing the rating 8 times rapidly while playing WASAPI: MP3: a) Local: VBR:occasional stutters / CBR: occasional stutters occasional Whitescreen crash b) Network: VBR:occasional pauses / occasional Whitescreen/Crash / CBR: occasional pauses OGG: a) Local CBR --> PASS b) Network CBR --> Long pauses M4A: a) Local CBR / Lossless --> occasional stutters b) Network CBR --> Long Pauses FLAC: a) Local --> occasional stutters b) Network --> occasional long pauses Directsound: MP3 (VBR / CBR ) --> Pass OGG (VBR / CBR ) --> Pass (BUT over the network, tagging can get 'stuck' for some time 10s-1m though it eventually completes) M4A (VBR / CBR / Lossless) a) Local: Pass b) Network: Audio Loops when tagging is 'stuck' FLAC --> Pass (BUT over the network, tagging can get 'stuck' for some time 10s-1m though it eventually completes) Summary: - The problems seem to occur most often upon repeatedly tagging a track (e.g. by rating it successively) - The problems tend to occur when the user rates a track just as the first tagging operation is shown (in the status bar) to be completing - The bug tends to be worse on WASAPI, though it can be made to occur on DirectSound (with M4A). Also, with DirectSound, one can observe what might be the root cause of the issue for OGG/FLAC tracks; i.e. the tagging operation gets stuck when the user initiates a tagging operation just as another tagging operation is completing. With Directsound, the tagging operation gets stuck temporarily (but for a long time) without interrupting playback, but with WASAPI, playback is interrupted. - On WASAPI, the bug occurs much more readily on MP3 than other formats, and is exaggerated by tagging over the network: -- Stutters/Pauses when tagging MP3 can be easily triggered (locally or over the network) -- Other formats occasionally stutter, but playback Pauses are more easily replicable (by tagging tracks on the network, and even then, mainly by repeatedly tagging a track (e.g. 20x) which triggers a long pause. It is triggered when the user is performing a tag modification just as the current tagging process is completing. See: https://www.screencast.com/t/UjHgkkro -- The whitescreen bug that occured when tagging MP3 occurred twice but I haven't been able to replicate it--I'm guessing that it's a different issue |
|
This doesn't appear to be a regression from MM4, and it only occurs if the user changes the default WASAPI settings by disabling the 'smoothing' functions. Pushing to 5.0.1. |
|
I should note that it's still present if the smoothing functions are enabled; it just becomes harder to notice. Still minor, however, and it should be okay to wait until 5.0.1 to fix. |
|
Fixed in build 2660, by fixing 0017180. Playing files are now tagged after finishing playback. |
|
Verified 2660 I was not able to replicate loop, but no regressions were introduced. |