View Issue Details

IDProjectCategoryView StatusLast Update
0018122MMW 5Tagging / organizing (properties / auto-tools)public2021-12-20 13:08
Reporterlowlander Assigned To 
PriorityurgentSeveritymajorReproducibilityalways
Status closedResolutionreopened 
Product Version5.0.1 
Target Version5.0.2Fixed in Version5.0.2 
Summary0018122: Long Paths fail in Auto-Organize Files
DescriptionWhen using long Paths Auto-Organize Files fails to create the proper long Path the user has specified.
Steps To Reproduce1 Use Auto-Organize Files
2 Use a long Mask like <Album>\<Album>\<Album>\<Album>\<Album>\<Artist> - <Title>
--> Observe New Path value, in this case the last folder and filename get mixed together
Additional Informationhttps://www.mediamonkey.com/forum/viewtopic.php?f=30&t=99509
https://www.mediamonkey.com/forum/viewtopic.php?f=33&t=100591
TagsNo tags attached.
Fixed in build2519

Relationships

related to 0016505 closedLudek Files cannot be auto-organized until duplicates and overly long filenames are edited 
related to 0012868 closedmichal Ability to support long filepaths (> 260 chars) on Windows 
related to 0018689 closedLudek 'Eject CD after ripping' and 'Verify ripped tracks' settings can't be changed (regression 5.0.2) 

Activities

Ludek

2021-07-08 11:48

developer   ~0064190

Last edited: 2021-07-08 12:20

Yes, it currently auto-cuts the path per 0016505

But you are true that it mixes the last directory and filename together (without adding path separator in between).

=> Fixed in 5.0.2.2500

As for the inability to disable the auto-cut: I guess we could add an option for this in the Auto-orgnanize dialog below the '[x] Delete empties folders' ?
i.e. something like
[x] Auto-cut long paths/filenames

Assigned to Rusty for wording suggestions.

lowlander

2021-07-08 16:13

developer   ~0064191

Why does it auto-cut if MediaMonkey and Windows support longer file Paths?

Ludek

2021-07-10 19:38

developer   ~0064201

Why does it auto-cut if MediaMonkey and Windows support longer file Paths?

MediaMonkey and Windows supports the longer path by prepending with '\\?\' , but not all apps supports such a paths (including MM4) so the option is needed and I think it should be enabled by default.
BTW: User at https://www.mediamonkey.com/forum/viewtopic.php?p=484120#p484120 would like this option (to be able to disable the auto cut-off)

rusty

2021-10-13 13:44

administrator   ~0065154

Suggested text (probably disabled by default?):
[ ] Trim long paths/filenames
Tooltip: Shorten paths/filenames to 256 characters for compatibility with certain apps

Note:
- the suggested text may be inaccurate re. the number of characters
- keep in mind that this needs to be enabled for background auto-organize as well

Ludek

2021-10-18 20:25

developer   ~0065291

I added the checkbox in build 5.0.2.2501

But left it enabled by default (to trim the long paths) as the long paths have not been well tested + are not supported by older apps (e.g. Total Commander fails to work with them).

lowlander

2021-11-11 20:27

developer   ~0065859

When using a long filename a \\?\ is added in front of the Path in Auto-Organize

lowlander

2021-11-11 20:27

developer   ~0065860

image.png (34,973 bytes)   
image.png (34,973 bytes)   

Ludek

2021-11-11 20:56

developer   ~0065861

Last edited: 2021-11-11 21:55

I can't replicate, but trying to figure out how this can happen tomorrow...

EDIT: I can't figure out how to replicate and also by analyzing the code I don't see where //?/ prefix could be added.
Could you please generate debug log for me?

EDIT2: Assigned back to me, I just see something...

Ludek

2021-11-11 22:09

developer   ~0065876

Fixed in 2519

lowlander

2021-11-12 19:02

developer   ~0065909

Verified on 2519 that \\?\ isn't added on long filenames

peke

2021-11-12 20:58

developer   ~0065913

Last edited: 2021-11-12 21:03

NOTE that \\?\ is normal NTFS command to force Long paths up to 65535 Characters.

See https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file

https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getfullpathnamew