View Issue Details

IDProjectCategoryView StatusLast Update
0019072MMW 5Generalpublic2022-06-15 20:52
Reportermichal Assigned To 
PriorityurgentSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Product Version5.0.3 
Target Version5.0.4Fixed in Version5.0.4 
Summary0019072: Change handling of extended tags to asynchronous
DescriptionCurrently we read extended tags as string JSON with all extended tags and this info is kept in track structures as normal tags. Because they can be quite large, we should use similar approach as for lyrics and comments - keep only a fraction (e.g. max. 200 chars) as short version and load full JSON only asynchronously on demand, e.g. for properties dialog.
Just note, that cut version of JSON (extendedTagsShort) may not be reliably parsed, where parsing needed, everybody should use new getExtendedTagsAsync function then.
TagsNo tags attached.
Fixed in build2652

Relationships

related to 0019065 closedmichal "Out of memory" crash because of massive extendedTags values in database 

Activities

michal

2022-06-01 16:42

developer   ~0068370

Fixed in build 2650.

lowlander

2022-06-03 14:52

developer   ~0068406

2E320000 editing properties on multiple files is an immediate AV. This may be a regression introduced by this change.

michal

2022-06-03 15:24

developer   ~0068409

Regression fixed in build 2651.

lowlander

2022-06-09 20:50

developer   ~0068460

00794D74 when editing Properties on multiple files on 2651.
image.png (9,399 bytes)   
image.png (9,399 bytes)   

peke

2022-06-09 23:42

developer   ~0068469

I can confirm same behavior.

peke

2022-06-09 23:44

developer   ~0068470

As talked offline "It only happens when multiple files are edited through Properties. Tagging through Media Tree or assigning Rating from Context don't have this problem."

No issues using Scripts eg. Edit tags -> Swap Artist and Title

michal

2022-06-10 08:09

developer   ~0068478

Fixed in build 2652. Test note - I could reproduce it only if editing multiple files without opening Custom tag tab.

lowlander

2022-06-15 20:52

developer   ~0068544

Verified on 2652