View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0019801 | MMW 5 | Main Panel | public | 2023-02-06 19:11 | 2023-10-06 13:41 |
| Reporter | lowlander | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | unable to reproduce |
| Status | resolved | Resolution | no change required | ||
| Product Version | 5.0.4 | ||||
| Target Version | 5.1 | ||||
| Summary | 0019801: Can't remove Genre value from Genre node in Media Tree | ||||
| Description | Unlike MediaMonkey 4 and Classifications in MediaMonkey 5 users can't remove a Genre value from the Media Tree to remove this value from any files it's associated with. This is useful in scenarios where users have multiple Genre's assigned to files: 1. GenreA; GenreB 2. GenreC; GenreB 3. GenreD; GenreB There is no method to remove GenreB from files, other than going to each individual file. Doable with 3, but not with potential thousands. Rusty raised the concern that the action of remove from the Media Tree could be ambiguous, ie. does it remove the value from files or the files themselves. First of any operation on nodes like Albums, Genres, Rating are tagging operations (ie. Drag & Drop), so a tagging operation would be consistent. However a dialog (with the option to never show it again) could be shown when using Remove (as well as D&D) indicating what will happen (tagging). Besides Classification no other node seems to have Remove available. It may be useful to have it at least for all multi-value field nodes (like Artist/Album Artist) to deal with the example above. For other nodes (like Rating/Album) the user could simply select files and remove value via Properties, however for consistency it may be better to have Remove available on all tag value nodes. | ||||
| Additional Information | https://www.mediamonkey.com/forum/viewtopic.php?t=103671 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | |||||
|
|
I created 0019802 to handle detection of Multi value genres search, which I guess could be also used for solving this. Unfortunately on long term Multi Value fields handling should be reviewed, but this would require a fair bit of study/design. Short term quick fix would be to implement remove that would Remove genre for all tracks that have single GENRE (and other multi value fields) and exact EXACT of removing genre As future upgrade to handling remove would also Extract Selected Genre from tracks that have MULTI GENRE (and other multi value fields) and re tag them with removed GENRE. |
|
|
I could see the point of offering Remove in Media Tree for Genre sub-nodes if it REMOVED THE TAG from any tracks that used it, in the containing Collection, (either used it as the only tag, or used it in a multi-tag situation). I think that this would be a good addition. The menu option should be named RemoveTag to avoid potential confusion mentioned by LowLander. There is not much value in deleting the tracks, because that can easily achieved by a Select All in the main panel. But there is no (other) way to easily remove a nominated tag from any track which uses it. There would be no point offering the option in any node for which multi-tagging wasn.t available. ... ie not for Rating, because there can only be rating can't there? |
|
|
Can you please note exact steps to reproduce as I can't replicate the issue. Tested this way: 1) For 3 files already in library I renamed genre value to GenreA; GenreB GenreC; GenreB GenreD; GenreB for all three files via Properties dialog. 2) Gone to Media Tree > Music > Genres > Genre3 3) Pressed F2 to rename the Genre3 and renamed it to empty string => the Genre3 node disappeared as expected and was also removed from the files (as expected) so the files now correctly have values: GenreA GenreC GenreD So wondering how you tested this? |
|
|
Yes, removing the value in the Media Tree by editing the Genre and leaving it blank works. However this is likely hard to find as a method to accomplish this for a user. |
|
|
The current implementation is even more inconsistent than originally described since: - In the tree: classifications support attribute removal, but all other attributes don't - In grid views: attribute removal isn't supported--instead removal from the DB / File system is implemented for all attributes My feeling is that some users might expect attribute removal and others may expect file removal. Possible approaches could be: 1) Always implement attribute removal for all nodes that allow for customizable attributes (and get rid of File Removal / Removal from the DB for such nodes). i.e. implement this for everything except: -Root nodes, Ratings, Files to edit nodes: no removal option (as currently implemented) - Location, Folders: Implement file and/or DB entry removal (as currently implemented) And with this approach, users would have to actually select tracks to delete them. Note: the string might be clearer if changed as follows: Are you sure you want to remove "Slow"? --> Are you sure you want to remove the "Slow" attribute? 2) Modify the Confirmation dialogs so that they support both attribute deletion and file/db entry deletion. e.g. Are you sure you want to modify or delete xxxxx? (o) Remove the "Slow" attribute ( ) Delete from the database only ( ) Delete from the database and drive [[Yes]] [No] Please comment and triage. |
|
|
I think that current functionality is fine as: 1) Renaming a genre in Media tree to an empty string removes the attribute (as expected) 2) Selecting the genre in Media tree and pressing Delete suggest to remove all tracks from the genere (as expeced and same as in MM4) EDIT: Just testing 2) and the album/artist/genre nodes in Media tree are not removable (unlike in MM4) Tracked as 0020281 |
