View Issue Details

IDProjectCategoryView StatusLast Update
0019959MMW 5Skinspublic2024-07-22 22:34
Reporterzvezdan Assigned To 
PriorityurgentSeverityminorReproducibilityN/A
Status assignedResolutionopen 
Target Version5.1.1 
Summary0019959: None native skin is visualy acceptable with Windows 11 high Contrast themes
DescriptionI believe that many users are using high Contrast themes of Windows and I think that the program should have at least one skin that is optimized for such view.

The icons are almost invisible with the Desert light contrast theme and all native MM skins, and the selected tracks/nodes are not highlighted with any contrast theme. The borders of dialog boxes are also indistinguishable from the main window, especially with the dark Contrast theme.
TagsNo tags attached.
Attached Files
Material - Desert.png (84,574 bytes)   
Material - Desert.png (84,574 bytes)   
Material - Night Sky.png (72,385 bytes)   
Material - Night Sky.png (72,385 bytes)   
Material - None.png (88,530 bytes)   
Material - None.png (88,530 bytes)   
Metro - Desert.png (121,502 bytes)   
Metro - Desert.png (121,502 bytes)   
Metro - Night Sky.png (94,803 bytes)   
Metro - Night Sky.png (94,803 bytes)   
Metro - None.png (107,537 bytes)   
Metro - None.png (107,537 bytes)   
Fixed in build

Relationships

related to 0020897 assignedpetr Media forced-colors system changes is not working in realtime (Regression) 
related to 0020318 closedpetr Improved customization for default skins 

Activities

zvezdan

2023-04-27 12:50

updater   ~0071636

Actually, I have two related suggestions:
1. as I said, the program should have built-in skins optimized for Windows Contrast themes, light and dark, just as is the case with VS Code that has them included with it;

2. display and visual appearance of the existing skins should not depend on the Contrast theme set in Windows. Again, as it is the case with VS Code with which you could choose any of its themes and it will stay the same no matter which Windows theme you have set. As you may know, VS Code GUI is based on Chromium, just as your program. Or, the program should detect when the Contrast theme is turned on in Windows and automatically modify some of its GUI elements, as is the case with Opera and Vivaldi that are both also based on Chromium.
Opera - Night Sky.png (14,757 bytes)   
Opera - Night Sky.png (14,757 bytes)   
Opera - None.png (15,816 bytes)   
Opera - None.png (15,816 bytes)   

drakinite

2023-08-18 19:36

developer   ~0072654

Thanks for bringing this up. I think Dark Monkey would be a good basis for a high contrast theme but I understand some elements may need to be tweaked in order to guarantee good visibility. Any thoughts on how Dark Monkey works with Windows high contrast? https://www.mediamonkey.com/addons/browse/item/black-monkey/

zvezdan

2023-08-18 20:10

updater   ~0072656

On the first look, I don't see any difference between Dark Monkey and Metro M skins, it has the same mentioned problems. The indistinguishable selected tracks/nodes are especially troublesome preventing any normal use of the program.

Actually, I just saw one difference and I think Dark Monkey is even worse than Metro M because the thumbnail on the scrollbars is indistinguishable from the rest of the scrollbar (tested with Night Sky theme), so you don't have any visualization which part of the long list is currently displayed.

By the way, you could test Contrast themes very easily in Windows by yourself (Settings / Accessibility / Contrast themes or just Left Shift + Left Alt + Print Screen). I think Windows 10 has that similar.

drakinite

2023-08-19 22:01

developer   ~0072662

Thanks for the info. I'm away from home for a while so I don't have access to a Windows PC, so I figured I'd ask for your thoughts first - so now, when I get back home, I'll have the context necessary to get started testing �

drakinite

2023-10-30 15:16

developer   ~0073261

note to self: https://blogs.windows.com/msedgedev/2020/09/17/styling-for-windows-high-contrast-with-new-standards-for-forced-colors/

zvezdan

2023-10-30 15:33

updater   ~0073262

Last edited: 2024-07-22 14:27

Interesting. I just started to analyze MM skinning trying to do that high contrast modification by myself. Do you have any plan about it, so I could stop my efforts and spend my time on something else?

zvezdan

2024-07-22 14:30

updater   ~0076364

Last edited: 2024-07-22 14:31

I have finished the skin that supports Windows themes. Just waiting for you to resolve the 0020897 issue.

peke

2024-07-22 22:34

developer   ~0076375

0020897 Is not bug in MM itself but regression in chromium 121-123 and most likely fixed in chromium 127 pushing testing of rest of MM UI behavior after 0020897 is implemented as High contrast change along with Dark/light OS switch change can be normally handled and tested and implemented in skins that will support such change.

Assigning to me for 5.1.1 review/test after Chromium 127 is implemented and behavior is documented, so that native skins can be updated and function normally.

NOTE: https://blogs.windows.com/msedgedev/2020/09/17/styling-for-windows-high-contrast-with-new-standards-for-forced-colors/ is MS implementation in Edge legacy and Edge Chromium not yet fully propagated to Stable chromium builds.