View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0020223 | MMW 5 | Main Panel | public | 2023-09-08 21:08 | 2024-03-25 12:48 |
Reporter | Ludek | Assigned To | |||
Priority | urgent | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 5.1 | ||||
Target Version | 5.1 | Fixed in Version | 5.1 | ||
Summary | 0020223: Intensive artwork searching in Album grid can result in heap overflow | ||||
Description | MediaMonkey Exception Log - v.ID: 46B40000 v.5.1.0.2814 [Ticket # 6257] In the log V8 there javascript OOM (Reached heap limit) as there are many initiated artwork image searches at once. URLs like https://www.gstatic.com/_/mss/boq-search/_/js/k=boq-search.VisualFronten.... We should rate limit images being downloaded at once | ||||
Additional Information | https://www.mediamonkey.com/forum/viewtopic.php?t=105524 | ||||
Tags | No tags attached. | ||||
Fixed in build | 2830 | ||||
|
We already queue image search requests, they are made one by one, in the log we can see, that one file is downloaded and next search began. All the links including gstatic.com are part of Google image search result page (one such page is created by many sub-scripts). I am afraid the problem could be in Google scripts we cannot affect. |
|
But I found a possible problem, if this queue is too long, it can probably cause this error after some time. Will rework the handling. |
|
Fixed in build 2815. |
|
Verified 2815 Tested like user on 3k+ Artist images search. |
|
Reopen It happens again after MM use for few days. https://www.mediamonkey.com/forum/viewtopic.php?t=105524 |
|
Even though the ID is the same, the crash seems to be completely different (no heap overflow), the cause will be elsewhere, seems to be some different problem unrelated to this issue. |
|
It seems the crash happened inside Chromium during opening Google page with results, currently no idea what could cause this. |
|
Found the cause, it could happen in case downloading of artworks failed many times. |
|
Verified 3007 Unable to replicate TEST NOTE: Used manual unplug of LAN cable (50-100 fails) during download to simulate fail download. |