View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0021286 | MMW 5 | Tagging framework / input plugins | public | 2024-10-22 05:14 | 2024-12-19 16:01 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 5.0.4 | ||||
| Target Version | 2024.1 | Fixed in Version | 2024.1 | ||
| Summary | 0021286: ID3 Tags: Track # is saved incorrectly when format is x/y | ||||
| Description | If the user changes the Track# tag for an MP3 file from x/y to a/b then the tag is saved as a/b/y | ||||
| Additional Information | Reported at https://www.mediamonkey.com/forum/viewtopic.php?t=106821 (with more detail) | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 3101 | ||||
|
|
This is an old code that separated 'total tracks' from 'track #'. It probably make sense to get rid of it completely and simply show _exactly_ what is in tag. Should be deferred for the next major version to make sure it's properly tested (i.e. probably MM 2026). |
|
|
Postponed to the first post-release version, it is quite significant change in very long lasting behavior, so we should have more time to test consequences. New behavior will be also more consistent, because separating of total tracks is most probably not done for other formats (will need to check all). |
|
|
I agree, we should also check if Total Tracks can be used to help better match albums in Auto Tag, ... I have not see total tracks Tag in other formats, but like pointed we need to check all in details. |
|
|
I analyzed current state. MP3 - problem from this issue, saves x/y, reads only x part, incorrectly saves after edit of x/y FLAC, OGG - already correctly reads and saves x/y WMA - saves x/y, reads only x part. WMV - saves x/y, reads only x part. It also seems, we incorrectly save WM/Track tag to WMV. This is mostly not used already obsolete duplicate tag for Track number, should be zero based, we save it as 1-based. It is correct for WMA. AIFF, DSF, M4A/MP4/MOV, MPC, APE - saves x/y, reads x WAV, AVI - saves x, reads x. To support x/y we need to add support for ID3v2 tag in "id3 " chunk. Not sure it safe chunk even for AVI, but we could try. So issue should be fixable for all formats we tag, only for WAV/AVI we need to use not standard "id3 " chunk, but it is used by some other tagging SW, so should not be problem I think. |
|
|
For most formats fixed in build 3100. Remaining WAV and AVI. |
|
|
WAV fixed in build 3101. In case we need to save non-number to tracknumber, like x/y, uses 'id3 ' chunk. ITRK/itrk used only for track number part for better compatibility. AVI format left untouched, it is not clear, whether we could use 'id3 ' chunk, left for future, will see, whether it will be needed. |
