View Issue Details

IDProjectCategoryView StatusLast Update
0021450MMW 5Tagging / organizing (properties / auto-tools)public2025-01-21 00:53
Reporterpeke Assigned To 
PrioritynoneSeveritymajorReproducibilityalways
Status feedbackResolutionopen 
Target Version2024.1 
Summary0021450: Lyrics are saved in properties even they are not confirmed
DescriptionLyrics are saved in properties even they are not confirmed after you repeat search from properties.
Steps To Reproduce1. Make Auto Lookup enabled
2. Play track without Lyrics and Let MM search it
3. Right Click on track -> Properties -> Lyrics -> Search icon
4. Save Icon disappear
5. Clicking OK will Save Lyrics

Expected that Lyrics are not saved like when you:
1. Make Auto Lookup enabled
2. Play track without Lyrics and Let MM search it
3. Right Click on track -> Properties -> Lyrics
4. Save Icon Shows Lyrics are not yet saved
5. Clicking OK will not save Lyrics
TagsNo tags attached.
Fixed in build

Activities

michal

2025-01-20 15:10

developer   ~0078014

It is by design and similar to artwork search. Manual search fills information to property and user confirms by pressing "OK", that he/she want to save it to tag. It would be confusing and strange to press manual search then save button and then OK button. Save button is there only for automatically looked-up thing, that the user may not have checked yet. But in case he/she leave there result of manual search, it is correct to expect, that he/she is satisfied with the result. But leaving on Rusty to decide, I would definitely leave it as it is.

peke

2025-01-21 00:17

developer   ~0078022

Last edited: 2025-01-21 00:53

Problem here is that in case of Wrong Lyrics found it takes many many clicks to clean faulty metadata and not save incorrect lyrics to file metadata.

Maybe adding clean button would be solution as that would allow users to revert to original content or no content (eg. like we allow this in Auto-Tag and other parts where we have Undo).

Edit: User can click CANCEL, but it will also loose non saved changes in other Properties tabs