View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002510 | MMW v4 | Conversion/Leveling | public | 2006-06-10 19:19 | 2006-08-03 19:20 |
| Reporter | jiri | Assigned To | |||
| Priority | immediate | Severity | major | Reproducibility | sometimes |
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 2.5.4 | ||||
| Summary | 0002510: Conversion from OGG sometimes fails halfway | ||||
| Description | As reported in http://www.mediamonkey.com/forum/viewtopic.php?t=10491 and confirmed by me, files are sometimes converted only partially. I have no idea how is it possible, we need to make some testing in order to know when exactly it happens, i.e.: 1. Only when source is OGG? 2. Only when target is MP3? 3. As described by user, only when leveling is calculated during conversion? 4. Was it always so, or did it work correctly in an older version? | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1002 | ||||
|
|
Assigning to Peke to figure out what triggers the problem and find possible solution. There's definitely an issue here as it's been reported by several users. |
|
|
Except those two times (Explained in mail) I never reproduced problem I have tested several variations and files even several threads at time with variate destination formats. I even tried to lock MM while converting e.g. play stop currently converted song. I have tried to change Convertation profiles either of source or destination tracks. From OGG Quality settings to Bitrate Setting. Test number of files used in all those tests are 50 OGG songs which were previously created in MM and CDeX. P.S. Only thing I noticed that in some case destination Track is not written but .XXXXXX temp extension is left and when it is renamed to .mp3 all is OK. and that happend ones while I constantly changed currently play track and now playing list (almost every second) which possibly happened when I wanted to play just converted track and it was firstly added to library before renaming from temp EXT to correct one (possibly while syncing tags with source). |
|
|
Repeating exact steps from Forum Topic. I was able to replicate the problem of partially converted tracks by playing/stopping/editing tags of the track being converted. Steps to reproduce: 1. From My Computer node select several Tracks to convert 2. Start Connvert and select destination to .\<Filename> 3. Start playing the selected tracks, edit/update tags, open properties analyze volume level,... Steps to evade problem: - Repeat above steps 1-2 3. Change focused Node to different one and all convert background jobs are done OK I came to conclusion that MM possibly ignore some Access Violation: File Was allready in use and start to convert tracks when file gets available which results in cutted song after convertation. That rises a Q that is the problem maybe in Decoder.exe or Replaygain? Tested in MM 2.4.2 and 2.5.3. |
|
|
Ok, but I see only answer to my question number 4, do you know answers to questions 1-3? You could also try to add some debug messages, particularly in EncodeMP3File() in MP3Manage.pas and in TWinAmpDecode.Read() in WinampDecode.pas and then generate a debug log of a failed conversion in order to better localize the problem. |
|
|
There is memory leak somewhere in MM when MM calculates Volume while converting to MP3, no problems noted when converting to OGG. MM_debug Exits with Runtime error 216 when converting from OGG to MP3 with Volume Analyze. Sometimes happen on 4 file sometimes on 13 sometimes on 21 but it is reproducable. No problems noted when converting from FLAC or WAV or MP3. (tested on 0000019:0000050 tracks) Using Leveling volume while converting or not and with files that have leveling info and files that needs to be calculated. Should try to use larger number of files of mixed type to see what is eating the memory due to possible memory leak when Volume calculation during convert. Additional Log is uploaded to FTP when Runtime error 216 occured. |
|
|
Fixed in build 1002. - The file locking issue was resolved. - As a part of fix of this bug, an issue where MM could have reported randomly that track can't be decoded was resolved. |
|
|
Just tested in build 970 and: -Conversion fails with all OGG files -Playback fails with all OGG files!! |
|
|
Building batches were updated. |
|
|
Seems to work correctly in 2.5.4.971. |
