View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002523 | MMW v4 | Other | public | 2006-06-22 10:29 | 2006-08-03 12:21 |
| Reporter | jiri | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.0 | ||||
| Fixed in Version | 3.0 | ||||
| Summary | 0002523: Remove usage of Delphi resourcestrings | ||||
| Description | Currently we use resourcestring identifier for many messages in MM. However, strings defined this way are internally converted as 8-bit ANSI strings and so localization for languages that aren't set as default on PC doesn't work well (e.g. Greek language on Czech machine). We should always use gnugettext's function _(), i.e. instead of current: resourcestring myString = 'test'; MessageBox( myString); We should use: MessageBox( _('test')); | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1002 | ||||
|
|
Resolved by using var myString : WideString; myString := _('test'); MessageBox( myString); See revision 1265. |
|
|
Only strings in ResStrings.pas very modified, some other units also contains resourcestrings. Also, it would be nice to move at least some constants from ResStrings.pas to the places they are used - particularly strings that are used only in one place. This way it won't be necessary to translate all these strings on MM startup. |
|
|
Revision 1299: Removed usage of Delphi resourcestrings (deleted CommonResStrings.pas moved to ResStrings.pas commited in revision 1298) Revision 1301: Removed some strings from ResStrings.pas to its location in order to not translate it on start-up, but once it is needed. Revision 1304: Fixed Msg dialogs' and buttons' captions. |
|
|
There are still some string unnecessarily translated on startup in ResStrings.pas, mainly strings like RS_NeedGoldForAutoList, burning strings or e.g. Freedb strings. I think it's worth moving them, because of increased performance for almost no work involved. |
|
|
Ok, most of strings was moved to its place. Only the most common strings like 'Track#' are left. Now, the GetStringsTranslations() procedure takes 0.002 seconds. (It is two milliseconds on MM start up) Is it enough? :-) |
