View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003175 | MMW v4 | Properties/Auto-Tools | public | 2007-06-25 20:44 | 2007-07-16 02:20 |
| Reporter | jiri | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 3.0 | ||||
| Fixed in Version | 3.0 | ||||
| Summary | 0003175: Regression: Auto-Organize $if() function doesn't work | ||||
| Description | As reported in http://www.mediamonkey.com/forum/viewtopic.php?t=18616 , $if() function in auto-organize doesn't work well. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1049 | ||||
|
|
Fixed in build 1046. |
|
|
The issue raised in the forum still isn't completely resolved. The problem is that when the user clicks the '>>' button to configure the mask, <Custom1> is shown instead of <Custom 1>. When the user manually corrects this, the mask functions. We should just correct the dropdown list (but I don't understand why this was implemented as a separate string (i.e. the String that appears in the dropdown list should be the same string that appears in the description of the Custom field). |
|
|
Technical: It seems to be caused by constants in MaskHelper.pas, but I didn't fix it because there are some wider problems: 1. Constants are stored like '<Year>', etc., i.e. they aren't language neutral. They should rather be stored as '%Y' or better just 'Y' in this case, so that they can be converted to full words according to user's locale in runtime. (using functions from ViewManage.pas). 2. MaskDescs constants don't get .po files for translation, because only strings stored as _('xxx') in sources are. It's better to modify sources slightly so that strings are stored this ways. See e.g. mp3manage.pas for samples. 3. Numbers in MaskPack_Rip and other arrays should be changes to constants for easier modifications. |
|
|
Fixed. Will be in 1049. |
|
|
Verified 1049. |
