View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003215 | MediaMonkey Addons | Player | public | 2007-07-02 20:07 | 2012-01-31 20:42 |
| Reporter | rusty | Assigned To | |||
| Priority | immediate | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0003215: MP2 not supported on MediaMonkey 3 and 4 | ||||
| Description | I've uploaded the track by Slim Whitman to the ftp server. It plays properly in Winamp and WMP, and shows up correctly in MP3Tag, but MM can't play it for some reason. Note: it crashes MM 2.5.5.998. On MM3 and MM4, the track is just skipped. | ||||
| Steps To Reproduce | Related to ticket: BWL-623678 | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
|
|
A close examination of the file showed, that it actually is MPEG Layer 2 stream (i.e. mp2 extension would be correct). The WM layer can't play such a stream, they probably have some special handling of this in WMP so that mp2 can be played. So, I'd recommend to use e.g. in_mpg123.dll plug-in for this file (and possibly rename the file to .mp2 and configure the plug-in for mp1 and mp2 playback only). |
|
|
So the issues are: a) is it really impossible to get this working (given that WMP supports it)? b) if it is impossible, then we need to remove this as a supported file type c) if we remove it as a supported file type, what will happen when the user installs in_mpg123.dll? i.e. will MP2 get added back as a supported file type automatically? |
|
|
Fixed in build 1051. a) Seems to be impossible, the files aren't playable using WM layer. b) Done, removed both MP2 and MP1. c) Yes, if a plug-in supporting MP2 is installed, MP2 will be supported again. |
|
|
Verified 1051. |
|
|
Jiri suggested that we should look into this issue further: if the mp2 (mpeg-1 audio layer 2) patents have expired, then we can bundle in_mpg123.dll specifically for playback on MP2 files. Assigned to Rusty for investigation into the patent situation. |
|
|
Due raised same issue in one of recent eSupport Tickets I've investigated a little. And the solution would be to use default MPEG Splitter from MPEG2 Video Codec like WMP and other apps are doing. I Attached GSpot Screenshot to clearly see how others have solved the issue. Note: In case Windows do not have Codec Associated with MPEG2 Audio Dialog would show info that User needs additional Codec to play that typo of files with possible link to Affiliate site with containing codec. This approach should not break licensing. |
|
|
Michal, could you check out whether we can do easily something about it. Pretty low priority in my opinion though... |
|
|
We can try to simply add extension MP2 to in_dsmp3 plugin. This plugin uses DirectShow to play/read files and DS filters for MPEG-1 Layer I and Layer II are the standard part of the Windows system (MPEG-I Stream Splitter and MPEG-1 Audio Decoder in quartz.dll). I've checked it in Windows XP and Windows 7 x64 and it seems to work ok. |
|
|
Fixed in build 1301. I added the support for MP2 extension to in_dsmp3 plugin. |
|
|
I'm afraid there's some confusion here. MediaMonkey 3.x uses the in_wmp3 plugin--the in_dsmp3 plugin is deprecated! |
|
|
Rusty: in_wmp3 uses WM layer and as Jiri wrote above, it cannot play MP2. But we can play it using DirectShow (Windows Media Player uses DirectShow for MP2 too), and the code for this is in in_dsmp3 plugin now. We can rename the input plugin to in_dsmp2 and remove MP3 extension from it, so it will play only MP2 files. |
|
|
We could create such a plug-in, but due to almost non-existing MP2 files, I'd make it available only separately from our web. |
|
|
OK, I've renamed the plugin to in_dsmp2.dll. It will play only MP2, when used. It is prepared on SVN. |
|
|
If we want to create it as standalone plugin then I would suggest to do it asap so that MM 3.1 users could use it. Michal could create installer similarly like I created for f_aac_codec.dll located in projects/setup/MediaMonkey-AAC-Codec.iss and batch for re-compiling and package creation projects/setup/PrepareInstall-AAC-Codec.bat so that we could publish it at http://www.mediamonkey.com/addons/input-output/ Maybe just MMIP installer could be enough, but the disadvantage is that MMIP can be installed only if MM is running and thus prevents from replacing existing DLL, because the DLL is in use by MM. But MP2 plugin won't need to be replaced, because we are planning to create only one version (no update needed) therefore MMIP could be suitable for us in this case. |
|
|
MMIP Installer will be enough, let me know if I need to make it. Preventing update of DLL is not an problem as I already solved that in last.fm plugin MMIP. |
|
|
Assigning to Petr to recompile LibBuild_in_dsmp2.bat a put it on FTP, please assign to Rusty then in order to publish it on our web. |
|
|
MMIP uploaded on FTP |
|
|
Assigned to Rusty for upload to WEB. |
|
|
There is issue with multichannel audio, it does not support more then 2 channels yet. I'll try to fix it. |
|
|
The problem was in ID3 tag (ticket IKS-737890, multichannel audio in mp2 is very rare and it wasn't this case), assigning back to Rusty for upload to WEB. |
