View Issue Details

IDProjectCategoryView StatusLast Update
0004954MMW v4Burning / Disc Handlingpublic2009-06-11 04:08
ReporterLudek Assigned To 
PriorityhighSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version3.1 
Fixed in Version3.1 
Summary0004954: Support more CD-Text fields when burning audio CD.
DescriptionAs suggested in this ticket:
http://www.mediamonkey.com/support/staff/index.php?_m=tickets&_a=viewticket&ticketid=2697

We might add some other CD-Text fields, there is a list of all supported fields:

CDTT_TITLE = 0x80 Album name and Track titles
CDTT_PERFORMER = 0x81 Singer/player/conductor/orchestra
CDTT_SONGWRITER = 0x82 Name of the songwriter
CDTT_COMPOSER = 0x83 Name of the composer
CDTT_ARRANGER = 0x84 Name of the arranger
CDTT_MESSAGE = 0x85 Message from content provider or artist
CDTT_DISK_ID = 0x86 Disk ID
CDTT_GENRE = 0x87 Genre Code
CDTT_UPCISRC = 0x8E UPC/EAN code of album and ISRC for tracks

Now, we support only CDTT_PERFORMER and CDTT_TITLE.

For historical reasons? - when we used Nero burner in the past?
TagsNo tags attached.
Fixed in build1194

Activities

peke

2008-11-21 21:30

developer   ~0015067

For both reading and writing?
Also I noticed in http://gnu.ethz.ch/debian/traverso/traverso-0.41.0/src/traverso/dialogs/project/ProjectManagerDialog.cpp that there is also suport for different codepages. I'll upload to ftp Takabins last CD-Text Editor and LD CD Player to confirm that.

Ludek

2008-11-22 18:51

developer   ~0015070

Last edited: 2008-11-22 19:04

I have added some other CD-Text fields for tracks:
Lyricist (CDTT_SONGWRITER)
Composer (CDTT_COMPOSER)
Comment (CDTT_MESSAGE)
ISRC (CDTT_UPCISRC)

then there are other fields for whole album (main track with index = 0)
I added only DiscNumber (CDTT_DISK_ID), because there is small problem with genre (CDTT_GENRE):
1. genres are stored only by enumeration (as integer consts) so we would need ComboBox instead of EditBox with only some available genres:

CDTG_UNUSED = 0 Not Used
CDTG_UNDEFINED = 0x0001 Undefined
CDTG_ADULT_CONTEMP = 0x0002 Adult Contemporary
CDTG_ALT_ROCK = 0x0003 Alternative Rock
CDTG_CHILDRENS = 0x0004 Childrens Music
CDTG_CLASSIC = 0x0005 Classical
CDTG_CHRIST_CONTEMP = 0x0006 Contemporary Christian
CDTG_COUNTRY = 0x0007 Country
CDTG_DANCE = 0x0008 Dance
CDTG_EASY_LISTENING = 0x0009 Easy Listening
CDTG_EROTIC = 0x000A Erotic
CDTG_FOLK = 0x000B Folk
CDTG_GOSPEL = 0x000C Gospel
CDTG_HIPHOP = 0x000D Hip Hop
CDTG_JAZZ = 0x000E Jazz
CDTG_LATIN = 0x000F Latin
CDTG_MUSICAL = 0x0010 Musical
CDTG_NEWAGE = 0x0011 New Age
CDTG_OPERA = 0x0012 Opera
CDTG_OPERETTA = 0x0013 Operetta
CDTG_POP = 0x0014 Pop Music
CDTG_RAP = 0x0015 RAP
CDTG_REGGAE = 0x0016 Reggae
CDTG_ROCK = 0x0017 Rock Music
CDTG_RHYTHM_AND_BLUES = 0x0018 Rhythm & Blues
CDTG_SOUNDEFFECTS = 0x0019 Sound Effects
CDTG_SOUNDTRACK = 0x001A Soundtrack
CDTG_SPOKEN_WORD = 0x001B Spoken Word
CDTG_WORLD_MUSIC = 0x001C World Music
CDTG_RESERVED = 0x001D Reserved is 29..32767
CDTG_RIAA = 32768 Registration by RIAA 32768..65535

if you think that it could be valuable then assign back to me and I will add the Drop down for selected genres.

During the implementation I found several strange things that delayed me:
It seems that non-zero values (non-empty strings) are needed to set to the CD-Text fields otherwise there can be AV when creating CD session (Primo bug?),
I observed this problem when burning two tracks - the first had Composer = '' and the second had Composer = 'A/B'then if I changed the composer of the first track to a not null string (e.g. ' ') then it passed. So I set null strings to ' ' by default in order to prevent the AV (little hack).

Another problem I found we need to cut off long (especially comment) text values otherwise writing CD-Text can fail. I cut off text values longer then 99 chars. It seems to make sense ( see: http://www.feurio.com/English/faq/faq_cdtext_maxsize.shtml)

Added in build 1194.

Btw.
If you think that some of the Lyricist, Composer, Comment, ISRC values could be valuable also for whole album (like DiscNumber is) then we could add them also to the 0. track (maybe at least comment for album.comment), otherwise I think the values are valuable rather for tracks (are saved per track).

peke

2009-06-05 15:39

developer   ~0018198

Verified 1250

peke

2009-06-05 15:41

developer   ~0018199

Reminder sent to: jiri, rusty

I would leave things as is for now.

We can later see if we would need more fields.

@Rusty
Is there any changes that we need to make in Docs?