View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010153 | MMA | General | public | 2012-12-05 16:23 | 2013-06-13 00:10 |
| Reporter | jiri | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.0.1 | ||||
| Target Version | 1.0.4 | Fixed in Version | 1.0.4 | ||
| Summary | 0010153: Ability to control playback on pre-4.2 phones that screen lock active | ||||
| Description | This was already implemented for 4.2+ phones. However, since many users expect this functionality from a music player on any Android version, we should implement asap. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 139 | ||||
| related to | 0009169 | closed | martin | Lock screen widget |
| related to | 0009257 | closed | martin | Player Widget |
| has duplicate | 0011021 | closed | martin | Lock Screen Player can't be disabled on JB devices |
| related to | 0010918 | closed | peke | Widgets don't work with Go Locker alternate lock screen |
| related to | 0010935 | closed | martin | MMA sometimes fails to terminate (re. PlaybackService) |
| related to | 0010985 | closed | martin | Lock screen doesn't activate using 'home button' (regression in 145--it fails completely) |
| related to | 0011033 | closed | martin | Lock screen activates when it shouldn't |
|
|
Set priority to urgent for 1.02 due to the significant interest in this. |
|
|
Fixed in build 107 You need to set "Use lock screen player" option. |
|
|
Test note: verify how this functions on JB devices as well and whether it should be disabled for > 4.2 devices. |
|
|
A couple of issues when the Lock screen is enabled: 1) The lock screen appears in a couple of situations in which it shouldn't: a) It appears even if the phone isn't locked. e.g. 1 Disable lock screen 2 Press on/off button to turn off the device screen and back on --> MediaMonkey lock screen appears! In such cases, the phone should open in whatever state it was in previously (i.e. the MM lock screen should only appear in cases where the Android lock screen would have appeared. b) It sometimes appears even when MM isn't active. e.g. 1 Back out of MM (so that the MM icon no longer appears in the notification bar) 2 Press on/off button twice --> MediaMonkey lock screen appears! In such cases, it doesn't make sense for MM lockscreen to appear because MMA wasn't even active beforehand. I think that the only time that the lock screen should appear is if MM is the currently active app, OR if it is active (i.e. playing or paused in the background). 2) When the lock screen appears, the commands sometimes fail to function. e.g. 1 Get the lock screen to appear 2 Press the context menu button --> A small 2x2 pixel artifact appears at the lower left corner on some devices (Samsung S3 on JB, Samsung Galaxy Exhibit on GB) 3 Press the play/pause button --> The artifact disappears, but play/pause doesn't work 4 Press the play/pause button again --> This time it works (i.e. it works whenever the artifact isn't present) Note: Sometimes the artifact appears as soon as the lock screen is activated--I haven't been able to figure out what the trigger for this case is. 3) Although it's relatively easy to figure out how to get to the lock screen (i.e. by clicking 'home' or 'back') it might be a good idea to add an 'unlock' icon on the right side of the player. We'll see based on user feedback. 4) MM is always running even when it shouldn't. I suspect that this is a side effect of 1b). |
|
|
add 1) done in build 109 add 2) done in build 109 |
|
|
Fixed in build |
|
|
It is working on all ICS phones I have tested, But I noticed that Prev/Next Buttons are too little and are hard to click on Fo example Sony Xperia Tipo Other than that This can be closed. |
|
|
Resolving, seems to be ok for now, further UI improvements are possible in the future... |
|
|
Tested 125: 1a) fixed 1b) Still not fixed. The problem is that the lock screen still appears in cases where MM has been paused and isn't active. i.e. MM has been paused, and the user backed out of MM. BUT even though it doesn't appear in the notifications bar, the MM process takes about 2 minutes to terminate, and during that time, if the user goes to the lock screen, MM appears. The simplest fix would be either: i) terminate the MM process as soon as the user backs out so that the lock screen doesn't activate (preferred) ii) continue to show MM in the notifications bar until the process terminates 2) This is mostly fixed _except_ for the first time that the lock screen is used. After enabling the lock screen for the first time, and then triggering the lock screen while MM is running, the normal lock screen appears instead of the MM lock screen. Tested on Samsung Exhibit (GB) and Samsung Galaxy S3 (JB). |
|
|
Fixed in build 127 |
|
|
Verified 1a in 127 5) Do not work with GO Locker https://play.google.com/store/apps/details?id=com.jiubang.goscreenlock screen that support MediaPlayer options and Widgets in Lock Screen |
|
|
can you please triage 5) but I think it could be reviewed post release |
|
|
Re. 5) afaik, Go Locker is designed to use widgets, and this bug isn't about the MM Widget on the lock screen--it's about running the locked version of MM for versions of Android that don't support widgets in the lock screen. I'll open a separate bug re. the incompatibility that's described. 6) The text for the lock screen player should be modified to better reflect what it is: Use lock screen player --> Show player when screen is locked Enable music playback controls on the lock screen --> a)Enable player controls on Android < 4.2 if the screen is locked. For 4.2+ use widgets. OR b) Enable player controls if the screen is locked. 7) Is it possible to hide 6) if MMA detects that Android 4.2+ is running ? (in which case b) should be used instead of a) ) |
|
|
Fixed in build 135. |
|
|
Verified 136. - UI doesn't appear in Android 4.2 (nexus7) - Revised text appears in Android <4.2 (s3) |
|
|
Re-opening as case 1b) is an issue in build 138. i.e. if the Lock Player is enabled, and MM process isn't running, and the user clicks the off button to trigger a screen lock --> upon turning on the device, the Lock Player appears! This has the effect of causing MMA to run in cases where it shouldn't (i.e. it appears to not terminate when it should have). |
|
|
Fixed in build 139. |
|
|
Verified 141 |
