View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0011148 | MMW v4 | Main Panel/Toolbars/Menus | public | 2013-08-14 02:02 | 2013-08-29 21:39 |
| Reporter | peke | Assigned To | |||
| Priority | immediate | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 4.0 | ||||
| Fixed in Version | 4.1 | ||||
| Summary | 0011148: Artist & Album Artist -> Artist subnode lists only albums of Album Artist (reverted) | ||||
| Description | If browsing Artist & Album Artist -> Artist Subnode do not show all albums | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Fixed in build | 1654 | ||||
|
|
OK, I cannot confirm (because the screenshot doesn't show it), but most probably the issue is that '2pac' is not album artist of 'MTV 2005 CD 12' and thus this album is not shown under '2pac' You are probably right that in case of 'Artist & Album Artist' node it should behave like in case of 'Artist' node and all albums on which the artist is participated should be shown. But because it have been always like this without objections (I see the same in 4.0.7 too) then I am not sure whether the change would not result rather in a negative feedback? |
|
|
Fixed in build 1653 (we can revert in case of negative feedback). |
|
|
Isn't the reason why we made Artist and Album Artist node to show all? |
|
|
Verified 1653 |
|
|
Unless I'm missing something, this change seems to make the Artist and Album Artist node almost the same as the Artists node (with the exception that the Artists node will be missing 'Various' and 'Various Artists'). Moreover, the old functionality made MM consistent across the board (in its default config), where subnodes are always children. Now the tree will show for every single node an 'expand' indicator, even when there's nothing to expand (e.g. a single track from a compilation album will cause an expand indicator to appear). Lastly, as far as I can remember, there were interactions between the design and the manner in which drag and drop works when dragging and dropping between A&AA nodes, and I'm pretty sure that changing this functionality will cause other drag and drop bugs. Unless you feel strongly, and are confident that d&d bugs won't result, I suggest reverting. |
|
|
Yes, you are true that by the change in build 1653 the 'Artist & Album Artist' node becomes more like 'Artist' node and less like 'Album Artist' node. But looking at the 'Artist' node I think there is an inconsistency, one would expect that 'Artist' node should behave like 'Composer' node. i.e. all composer nodes have an expand indicator to show albums on which the composer is participied, but in case of 'Artist' node only album artists has an expand indicator instead of all artists. So I guess this should be fixed. Re the D&D between A&AA nodes: From what I see (the same for A, AA, A&AA nodes), D&D an album from A1 to A2 causes that the A2 becomes new Album Artist of the dragged album. I guess that this should happen only if A1 was Album Artist of the dragged album, otherwise only artist should be changed (or D&D of incomplete album shouldn't be allowed at all). Is this the D&D issue you are reffering to? |
|
|
Actually after further tests I found that the issue with 'Artist' node (its expand indicators) is a regression in 4.1 builds, the 'Artist' node works fine in 4.0.7 (in the same manner like the 'Composer' node). Fixed as 0008361 Also some further tests re the D&D issues: D&D album between two composers: - in 4.0.7 everything in UI looks like it works, album can be D&D, but actually the composer isn't changed - in 4.1 the situation is even worse, D&D album between composers causes that the new composer is assigned to artist and album artist field !!! I think that D&D album between nodes like composers shouldn't be allowed. Probably only albums under 'Album Artist' and 'Artist & Album Artist' nodes should allow D&D. That said D&D of album between A1 and A2 should be possible only if A1 is album artist and A2 is artist (to became new album artist). |
|
|
In 4.0.7, the Composer and Artists node differ slightly as follows: 1) Drag Track to Artist (where Artist=Album Artist) --> A/AA update 2) Drag Track or Album to Artist/Album (where Artist=Album Artist) --> A/AA/Album update 3) Drag Track to Artist (where Artist|=Album Artist) --> . a) if original track has Artist|=Album Artist, then only Artist updates . b) if original track has Artist=Album Artist, then both Artist/Album Artist update 4) Drag Track to Composer --> Composer updates 5) Drag Track to Composer/Album --> Album updates In other words: - Composers display Album subnodes for tracks by the composer, whereas Artists display subnodes only for tracks that have Artist=Album Artist. As described at 0005461, this is a bit inconsistent, however, when we tried changing it in the past, it cause even more problems as described at 0005461:0017852 . - D&D for composers>album only triggers updates to the Album, whereas D&D for Artist>Album triggers updates to both. I believe that in light of the manner in which nodes are displayed, this is the desired behavior for D&D. So basically, I'm saying that the behavior in 4.0.7 was probably fine, aside from the bug that you described in which D&D of an Album from one composer node to another updates the Album Artist instead of the Composer. |
|
|
OK, going to revert the new behaviour for A&AA node based on the problems and negative feedback raised when we already tried this in the past: 0005461:0017852 i.e. it remains as was in 4.0.7 Reverted in 1654 + fixed the bugs described above: - D&D album between two composers: fixed by disabling album D&D between composers as it actually doesn't make sense and is not clear what should happen. D&D of albums is enabled only between AA nad A&AA nodes now, because there are full albums and parent artist node is AA of the album. |
|
|
Verified 1656 |
