View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0012063 | MMW v4 | Properties/Auto-Tools | public | 2014-05-22 20:57 | 2015-04-21 19:26 |
Reporter | peke | Assigned To | |||
Priority | immediate | Severity | feature | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Product Version | 4.1.2 | ||||
Target Version | 4.1.6 | Fixed in Version | 4.1.7 | ||
Summary | 0012063: Get Info/Buy: Providers do not have correct Icons | ||||
Description | MMW should Cache providers favicons.ico and use them in "Get Info/Buy" Amazon: http://www.amazon.com/favicon.ico HD Tracks: http://www.hdtracks.com/favicon.ico YouTube: http://www.youtube.com/favicon.ico Google: http://www.google.com/favicon.ico Wikipedia: http://www.wikipedia.org/favicon.ico CD Universe http://www.cduniverse.com/favicon.ico Library: MMW Default APP icon This should be done on install of MMW only once or if favicon.ico is non existing for that provider. | ||||
Additional Information | KWB-733-60497 (regression) | ||||
Tags | No tags attached. | ||||
Fixed in build | 1740 | ||||
|
Fixed in build 4.1.2.1706 The icons are cached on background after MM start into temporary directory (MMCache_icons folder) and are re-cached only once deleted from the temp. dir. So they can be missing for a few seconds on first time run (once they are being cached on the background). |
|
Others verified 1706. Library Icon is Missing it should use existing MMW icon of Entire Library Tree. |
|
Confirmed regression with Zvezdan also. Socket error Keeps background icon download active which results in Slow MMW closing. |
|
2. As Zvezdan Suggested we should move "MMCache_icons" to Roaming\MediaMonkey Later this folder than can be used to Cache Icons from Podcast/Subscription sites like http://www.npr.org/favicon.ico |
|
Fixed the cache issues in build 1734 Icons are now cached to /AppData/MediaMonkey/favicons/ or /Portable/favicons/ and are cached only when the favicons directory does not exist, so usually on first time run only. |
|
Verified 1734 Will ask Zvezdan for confirmation. |
|
Reopen, Looks like if there is socket error on retriving icons MMW still tries to fet them instead of just abandon till next startup? Log is uploaded to FTP |
|
As discussed over IM with Peke, Zvezdan cannot even download them using IE6 (probably a firewall issue ?) The good news is that in 4.1.6.1734 MMW tries to download them just once (once the internet connection is available), so MM won't try it on each start repeatedly But for 4.1.7 we should lower the the TCP timeout (in the Zvezdan log it takes too long before the Socket Error # 11001 appears, this slows down MMW closing) |
|
Fixed in 4.1.6.1736 The timeout for each favicon lowered to 5 seconds + added download interruption when app is terminating |
|
Verified 1736 |
|
Still not working satisfying. I got impression that only in cse that MMW is closed within 20 Seconds after startup we will have delay of 20 seconds where MMW will iterupt download and will not try again. But from last description it looks like whenever MMW is closed on [x] there is 20 Sec delay no matter how long it is open. Can you clarify? Again No delay if icons are manually put in right folder. |
|
There is no 20 seconds delay, as I've written in 0012063:0042177 Icons are now cached to /AppData/MediaMonkey/favicons/ or /Portable/favicons/ and are cached only when the favicons directory does not exist, so usually on first time run only. If you mean the Zvezdan issue (where no icon is downloaded due to a firewall issue) that I guess it should work to stop the downloading (becuase the favicon diretory is created), or it isn't the case for him? |
|
It happen to me when I got "socket error code 10061" in which case there is exactly 25 Seconds delay on MMW exit. |
|
Can you include Icons in Installer? |
|
Fixed in 4.1.7.1740 Icons are now bundled within the installer (and not downloaded at all). |
|
Verified 1740 |