View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0012092 | Last.fm plugin | Last.fm | public | 2014-07-01 22:25 | 2014-11-07 16:06 |
| Reporter | peke | Assigned To | |||
| Priority | urgent | Severity | feature | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.1.0 | ||||
| Target Version | 1.1.0 | Fixed in Version | 1.1.0 | ||
| Summary | 0012092: Service: Plugin Options should show service status and statistics | ||||
| Description | In earlier versions there was last 5 messages from log file shown which allopw user state of plugin. There should be something similar in new version. something like: ---- Service State: OK Submitted: xx Tracks cached: yy; ---- | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Fixed in build | 40 | ||||
| related to | 0012208 | closed | peke | Last.fm plugin | Scrobble Now Playing Setting is not persistent (Regression) |
| has duplicate | 0012202 | closed | peke | Last.fm plugin | Options: Show statistics |
| related to | 0012216 | closed | Ludek | MMW v4 | Assertion failure when calling SDB.IniFile.Apply from external Plugins |
| related to | 0012222 | closed | peke | Last.fm plugin | Caching doesn't work correctly |
|
|
Build 31 shows: Statistics ----------- Scrobbled: x Now Playing: y It's unclear what 'Now Playing' is (it's always at 0). Can you explain? Also, I would like to see a service state indicator, and an indicator re. cached tracks. i.e. Status ------------------ Status: OK / Disabled / Failed connection Tracks scrobbled: xx Tracks to scrobble: yy (or Tracks cached) |
|
|
Corrected in build 32 It now shows: Statistics ----------- Status: OK (Status is based on last.fm Server response) Tracks Scrobbled: x Tracks Cached: x Scrobbled Now Playing: y (Per MMW Session and mainly used for debugging/or Showing if Now Playing is scrobbled) I also added Refresh Button back due the fact that there is no automatic Refresh of sheet Note: 'Now Playing' is (it's always at 0) due the regression see bug 0012208 |
|
|
Tested build 32 and Status is exactly the same as in build 31. i.e. it still shows: Statistics ----------- Scrobbled: x Now Playing: y |
|
|
SVN was not updated correctly and creating build 32 included old VBS from build 31. All updated and checked now. |
|
|
Tested updated build 32 and there are still a few issues: 1) Status sometimes displays Status: 1 Even after refreshing. 2) Minor text tweaks: a) Tracks Scrobbled --> Tracks scrobbled b) Tracks Cached --> Tracks cached c) 'Scrobbled NowPlaying' is confusing (and there's a missing space). It should be changed to something like 'Tracks scrobbled and shared'. 3) Immediately after installing, the last.fm config panel has a graphic artifact (see attached). 4) I would suggest that all stats should be _per_session_. Or if you prefer, per session, total |
|
|
1. I could not Replicate, as talked on IM Status shows last Last.FM Server result String. Until Plugin contact Last.fm on next event (play, scrobbling) it will not change even you click refresh 2. Fixed I used "Now Playing shared" to be consistent with the option to Show now playing to friends on Last.FM 3. Artifact looks like skinning bug as I could not replicate. that looks like bleed thru. Reset is suggested after plugin install and if after reset it doesn't show than it is not properly initialized and need restart. Note: plugin itself do not control how setup sheet is shown it just create objects. 4. Fixed, now it is used <session>/<total> |
|
|
Tested build 33. 1. Status still indicates '1' when initially run. i.e. Install the plugin, reboot MM, start playback, and then open the last.fm dialog --> it shows status: 1. After clicking refresh, it changes to 'OK', but it shouldn't show '1' as the initial value. 2. All of the capitalization/spacing changes haven't been fixed. a) Tracks Scrobbled --> Tracks scrobbled (the s in scrobbled is still uppercase) b) Tracks Cached --> Tracks cached (the c in cached is still uppercase) c) I understand what you're saying, but 'Scrobbled NowPlaying' is both confusing because regular scrobbling also scrobbles Now Playing AND in aditiona there's a missing space in Now Playing. It should be changed to 'Tracks scrobbled and shared'. 4. This is still missing in build 33. |
|
|
Fixed in build 34 |
|
|
Verified build 34. However, re. 2. the language 'Now Playing shared' should be changed to "Tracks scrobbled and shared". Also it should be moved _above_ the "Tracks cached" entry. Note: "Show Now Playing tracks to my Friends on www.last.fm" can also be changed in the future to "Show played tracks to my Friends on www.last.fm". The only reason I'm not suggesting to make the change now is because it's a localized string. |
|
|
Fixed in 35 Changing to "Tracks scrobbled and shared" is incorrect as that option shows only Now Playing notification on Last FM and not scrobbled track eg. it shows what User currently play/played in MediaMonkey within last 60 Seconds (or in some cases as they had a bug for reported duration of the track and MMW report "MMW started to play xyz and will play it for xy seconds before scrobbling it") |
|
|
Tested build 36, and a couple of basic error conditions aren't handled: 5) If submission is disabled in the plugin, the Status doesn't indicate 'Disabled' (rather it'll show the status of the plugin when it last submitted a track). 6) If the password is changed to an incorrect password, then status shows a) 'started' if MMW has just started but hasn't submitted any tracks. This is misleading. Perhaps this could be corrected by: - Changing 'Status' to 'Status (last played track)' (this will also resolve issue 5) - Changing 'Started' to 'Waiting for track to complete' b) 'Caching tracks' after a track failed to submit due to a faulty password / bad connection, instead of e.g.'Bad username/password', 'Network failure'. If the intended design is to cache tracks in both of these scenarios, then multiple strings can be used. e.g. Bad username/password. (the assumption being that tracks shouldn't be cached if the username/password is incorrect). Network failure. (this would be the case when username/password was never validated, so tracks shouldn't be cached) Network failure. Caching tracks. (this would be the case if username/password had been validated, but a transient failure triggered caching). |
|
|
Added number of status msgs: - Skipping, Track excluded by Submission Rules - Skipping, Track not in library - Submit OK - Submit failed, Caching track - Track cached - Failed, length under 30 sec - Failed, Artist must exist - Failed, Title must exist |
|
|
- Now Playing disabled - Submit disabled - Cache only activated |
|
|
Suggested language: Failed login (Bad username/password). Failed login (Network problems). Added number of status msgs: - Skipped (excluded by submission rules). - Skipped (Track not in library). - Submitted Track. - Submission failed. Cached Track. - Cached Track. - Submission failed (Length < 30 sec). - Submission failed (Artist must exist). - Submission failed (Title must exist). - Skipped (Now Playing disabled). - Skipped (Submission disabled). |
|
|
more added: - Submission failed (Album must exist) |
|
|
Tested build 37. 5) If the user disables the plugin and then starts playback --> the status correctly displays that the plugin is disabled. BUT, if the user plays a track, and disables the plugin while the track is playing --> the status isn't correct 6) If the user sets the password to an incorrect password, and then starts playback --> The status shows 'Skipped (Now Playing disabled)'. That's similar to the case above--the status of the last submitted track is shown instead of the fact that the username/password don't match. Note: when the next track plays, the status changes to 'cached'--not sure if this makes sense (i.e. why cache the tracks if the username/password is incorrect). 7) The plugin still seems to be showing the status of the previously submitted track even in cases where the login info is correct: 1 Start MMW 2 Check plugin status --> it shows 'Started' (which seems fine) 3 Start playing track --> status shows 'skipped (Now Playing disabled). This doesn't make sense since the track couldn't have been skipped since it couldn't have even been submitted yet!! 8) The status 'Skipped (Now Playing disabled)' should probably be eliminated since what it really signifies is that the track was submitted, but Now Playing wasn't shared. So either we can get rid of it entirely OR show something like 'Submitted track (but not shared). Getting rid of it probably makes more sense. |
|
|
You are right here is new revision of showed messages. - Failed (Network problems) - OK - Failed (Banned. Update Plugin) - Failed login (Bad username/password) - Failed (System Clock Timezone missmatch) - Failed Error: <Server error code> - Failed (Session expired) - Skipped (Track excluded by submission rules) - Skipped (Track not in library) - Skipped (Track length < 30 sec) - Skipped (Album must exist) - Skipped (Artist must exist) - Skipped (Title must exist) - Failed (Now Playing disabled) - Failed (Submission disabled) - OK (Submitted Track) - OK (Cached Track) - OK (Submitted Now Playing) - Failed (Cached Track) - OK (Submitted Cache) Unknown ERROR. Contact support |
|
|
I've reviewed the errors and modified them so that they're consistent across the board. - Failed (network problems) - Failed (banned; update plugin) - Failed login (bad username/password) - Failed (system clock timezone missmatch) - Failed (server error: <Server error code>) - Failed (session expired) - Skipped (Track excluded by submission rules) - Skipped (Track not in library) - Skipped (Track length < 30 sec) - Skipped (Album must exist) - Skipped (Artist must exist) - Skipped (Title must exist) - Submission disabled - OK (submitted Track) - OK (cached Track) - Failed (cached Track) - Unknown error (contact support) I'm unclear about the usecases for the following, so I'm not sure about the language: - OK ; when does this appear? - Failed (Now Playing disabled) ; Based on bug 8) I'm not sure when this could appear without being confusing. i.e. if the submission succeeded, but Now Playing was disabled, then the appearance of this message would be confusing. Please clarify. - OK (Submitted Now Playing) ; Based on bug 8) I'm not sure when this could appear without being confusing. i.e. shouldn't it just show OK (submitted track)? Please clarify. - OK (Submitted Cache); What is the difference between this and OK (cached Track)? |
|
|
r? ??: It is Last.FM response from Server that API Command is accepted before actual result is returned for the command. eg. connection, handshake, request login, ... It shouldn't show normally. Re now playing here is how things are processed: Main problem I see is that Now Playing and Submit is different things where Now playing is only current state of player and track shared which is deleted after 60 seconds it never goes to user play library on last.FM where Submit either from cache or played track goes directly to library. examples 1. Play -> Now Playing -> End Track inc Played -> Submit track -> now playing -> ... 2. Play -> Now Playing -> Skip -> Now Playing -> Skip -> ... 3. Play -> Now Playing -> End Track -> Submit track -> Stop Failed (Now Playing disabled) = Nothing is submitted as it represents only Now Playing state and that Now playing is failed due the fact that it is disabled. OK (Submitted Now Playing) = Last.fm accepted Now Playing Submission OK (Submitted Cache) = Last.fm accepted submission of cached tracks OK (cached Track) = Track successfully saved in cache for later submission I would also "Status" to "Service status:" to make things more clear |
|
|
Fixes in 38: - Service status report rewritten - Changes to Option sheet and Quick Icon are Now Seen in Statistics to avoid confusion of username/password changes and plugin enable/disable state - Code cleanup - Updated Service status messages |
|
|
5) Fixed 6) Fixed 7) Fixed 8) Although 'Skipped (now playing disabled)' has been eliminated, equally confusing language has replaced it: 1 Play Track (submit played enabled / show now playing disabled) --> Service status: Now Playing disabled 2 Play Track (submit played enabled / show now playing enabled) a--> Service status: Now Playing enabled and after playback is completed b--> Service status: OK (submitted Now Playing) All three cases are confusing. The primary feature is track submission, and yet the only status that is being displayed is for Now Playing!! As suggested at 0012092:0040816 , it would probably make more sense if it showed only the overall status (rather than the now playing status) e.g.: 1 Service status: OK (connected) OR 'OK' 2a Service status: OK (connected) OR 'OK' i.e. service status is 'OK' as long as a connection is active and Submission is enabled. 2b Service status: OK (submitted Track) 9) The 'Service status:' field changes to 'Service:' upon clicking refresh. e.g. Service status: Started Click refresh --> Status: Started Note: this occurs with other statuses as well. |
|
|
Fixed 8, 9 in build 39 |
|
|
Tested 39. 8) Case 1 and 2b (status after playback) seem to be fixed. However, case 2a (Service status prior to playback), still shows the Now Playing status! e.g. i) Set (submit played enabled / show now playing enabled) --> Service status shows 'Now Playing enabled' instead of 'OK' or 'OK (connected)' OR 'OK (submission enabled)' ii) Set (submit played enabled / show now playing disabled) --> Service status shows 'Now Playing disabled' instead of 'OK' or 'OK (connected)' or 'OK (submission enabled)' 9) Fixed |
|
|
Fixed 40 |
|
|
Verified 40. |
