View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0012264 | MMW v4 | Framework: Scripts/Extensions | public | 2014-10-25 21:58 | 2015-02-26 23:13 |
| Reporter | peke | Assigned To | |||
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 4.1.5 | ||||
| Target Version | 4.1.6 | Fixed in Version | 4.1.6 | ||
| Summary | 0012264: Extensions: Find Updates improvements | ||||
| Description | Currently Updates from our sites can't be found to fix that in case that INI file do not contain correct UpdateURL MMW should automatically search for update on http://www.mediamonkey.com/addons/update.php?id=<Extension ID> and in case of plugin Unknown errors it should be flagged as not available and never checked again (unless it is reinstalled) | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1735 | ||||
|
|
I have just verified that MM at first tries to read: http://www.mediamonkey.com/addons/update.php?id=ID and if nothing is found then it tries the UpdateURL specified by the addon's creator. So if UpdateURL specified by the addon's creator is unavailable then we cannot do anything. I don't think that we shouldn't ever try this URL again, because it can be just _temporarily_ unavailable Resolving as Not fixable |
|
|
Re-opened, you might mean directly the download link, i.e. the UpdateURL that is part of version.XML here: http://www.mediamonkey.com/wiki/index.php/Installation_Packages#Sample_version_XML_file That is actual link to the new MMIP file, if that is missing we could redirect to the deafult download link: http://www.mediamonkey.com/addons/download.php?id= Is that what did you mean? |
|
|
Yes and No. Yes -> deafult download link should be redirected to "http:\\www.mediamonkey.com/addons/download.php?id=" but only if UpdateURL is missing from version.XML and new version is found by obtaining from "http:\\www.mediamonkey.com/addons/update.php?id=" like in case of #12246 where for http://www.mediamonkey.com/addons/update.php?id=QuickMoods where <UpdateURL> and <NewVersionDescription> is missing. No -> MMW should always first check for existing UpdateURL made by addons creator and if that is missing then request version.xml from "http:\\www.mediamonkey.com/addons/update.php?id=" to check if addon is available on our addons site and than if new version is found we do automatic redirect to "http:\\www.mediamonkey.com/addons/download.php?id=" in case <UpdateURL> and <NewVersionDescription> is missing. Here is corerct logical approach: 1. Check [header] for UpdateURL and if a) Found query for version.xml b) not found query "http:\\www.mediamonkey.com/addons/update.php?id=" for Version.XML a2. after version.xml is received and UpdateURL missing/empty report "No updates found" else check version and download new version b2. after version.xml is received from "http:\\www.mediamonkey.com/addons/update.php?id=" and UpdateURL missing/empty, but new version is found redirect download to "http:\\www.mediamonkey.com/addons/download.php?id=" and obtain new version There is one more case if UpdateUrl is present either in header and/or in version.xml but it is not correct URL (eg. do not starts with "http:\\") than MMW should just reports "No Updates found" and do not even try to check for updates. |
|
|
Fixed in 4.1.7.1735 But I am afraid that it won't work correctly in all cases, if UpdateURL is missing or broken, but a new version is found then the original location ("http:\\www.mediamonkey.com/addons/download.php?id=" ) might still include the _old_ version which would result in re-downloading the old version, but probably not a big deal either way. Re #12246 , as I see the QuickMoods version.xml includes version 1,0,0,0 so it sounds logical to me that there is no update available (and MM even doesn't check the UpdateURL, because there isn't a new version number specified). So the question is whether there is an addon exhibiting the issue at all? |
|
|
Peke is also suggesting so that the optional UpdateURL in the [Header] section of Install.ini file is preferred over the default location ( http://www.mediamonkey.com/addons/update.php?id= [^]ID ) |
|
|
Fixed in 1735 So the current workflow is: if UpdateURL is specified in [HEADER] section of install.INI (and is in the correct form) then it is used to get the Version.xml (otherwise the default location on MM server is used) if UpdateURL is specified within the version.xml then is is used to get the MMIP (otherwise the default location on MM server is used) |
|
|
In Addition this is especially useful if Author wants to have its Stable Plugins on our addons site but working Beta/Alpha on its hosting avoiding non needed feedbacks and faster patching. Secondly, Extension find updates do non needed query to our site where bandwidth is generated for plugins not hosted on our addons making false results of no updates are found. |
|
|
Updated http://www.mediamonkey.com/wiki/index.php/Installation_Packages#Sample_version_XML_file and http://www.mediamonkey.com/wiki/index.php/Installation_Packages#.5BHeader.5D_section To Comply with fix |
|
|
Verified 1735 |
