View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0012905 | MMA | General | public | 2015-10-16 15:34 | 2024-01-29 22:39 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.1.3 | ||||
| Target Version | 1.3.1 | Fixed in Version | 1.3.1 | ||
| Summary | 0012905: Users can't remove incorrectly updated lyrics or artwork | ||||
| Description | If the user has enabled Album Art lookup and Lyrics lookup, it generally works correctly. BUT if the looked up information is incorrect, there's no way to delete it so that it can be re-looked up. Proper solutions in the future would be to make these fields editable in the properties dialog, but we need something in the interim. Possible interim solutions: Artwork: Tap on the artwork in the properties dialog --> delete option Lyrics: Tap on lyrics --> delete option I'm open to other suggestions, as these approaches aren't particularly elegant. | ||||
| Additional Information | http://www.mediamonkey.com/forum/viewtopic.php?f=21&t=82618 http://www.mediamonkey.com/forum/viewtopic.php?f=21&t=88070 | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Fixed in build | 714 | ||||
|
|
Re Artwork: ok Re Lyrics: It already works in this way, it reacts on long click, ok? |
|
|
Deletion of album art was implemented as part of 0014268. However, there are several issues: 1. The current implementation is kind of strange: User taps on AA --> "Confirm deletion: Do you really want to remove album art?" What's strange about this is that the user never chose to delete the album art, but the UI implies that by tapping on the artwork that that is what s/he intended. An approach that would make more sense (but that is still not that elegant) would be for the user to tap-hold on the AA --> context menu appears: Delete Album Art Search alternate But even this approach is problematic since it doesn't completely resolve editing issues as it: a) Doesn't allow the user to revert to the original artwork b) Doesn't give the user the ability to choose from among various alternates c) Doesn't give the user the ability to save artwork that has been looked up but not saved d) Always (presumably) saves artwork to the track since there is no 'Save' button to accept artwork (in the same way that Lyrics have a 'Save' button). Peke also indicated the following: -------------------------------------------------------------------------------- 2. Deletion removes artwork from listing but not from now playing. 3. Removed track album art is not updated and on refresh (went to prev track and back to track with removed picture) show old picture even track properties show new picture. Added pictures before remove, after remove and search in track properties and after refresh just before Log ID: ZR5U2N9PMD Description: 14268/3 was sent . To replicate: Start playback of tracks in MMA -> Locate one that shows incorrect metadata by swaping thru playing tracks -> tap "..." to show Track properties -> Delete/remove artwork -> OK -> swap left/right to play different track -> Now playing show no Album art -> Swap to next/prev track and back to just edited track and MMA starts AA search (wait till it is finished) -> Swap to next/prev track and back -> incorrect OLD AA show If you open track properties again correct AA will be assigned to track. At that point Log ID: ZR5U2N9PMD Description: 14268/3 was sent for analyze. EDIT: Bug Looks more deeper than I initially thought. I uploaded Video with steps from 3. on FTP and sent Log ID: FLHGRDETG8 Description: aa bug afterwards |
|
|
1. My understanding that TAP should enlarge Album art and allow us to show additional icons/options eg. a-d long press should execute an defined action like Delete artwork prompt or initiate search |
|
|
1. The UI issues are the most significant ones here, but unless it's trivial to fix, we should probably defer most of them to 1.3.2. I think that either of these approaches can be taken a) Tap Hold --> context options b) Tap --> Open AA editing screen that shows the artwork large, with menu options to delete it or to replace it with alternates. This is probably the preferred approach as it works similarly to how Lyrics does, and provides a UI that could allow for selection of alternates (that would be hard to do in a context menu). For 1.3.1 a simple interim fix might be for the tap (or tap hold) to yield a context menu 'Delete artwork'. 2. There are actually two different cases here: a) Deletion of saved artwork. Based on my testing this is working as expected (deletion of artwork that has been saved causes the artwork to be removed from the . b) Deletion of looked up, but not saved artwork. From what I see of Peke's tests: i) The perceived problem is that artwork appears in NP but not in Properties. I don't consider this to be a problem--Properties should only show looked up items that have been saved. ii) A second problem is that MMA allows the user to attempts to 'Delete' unsaved artwork. This should not be permitted by MM. i.e. if no artwork is saved, then MMA shouldn't give the user the option to delete artwork (since it doesn't actually exist anywhere but the cache)! 3. From what I see of the video, the additional problem that is shown here is that in some cases, MMA displays different Artwork in Properties vs Now Playing (neither of which is correct). According to Peke, this may have occurred in build 703 (see point 2 at http://www.ventismedia.com/mantis/view.php?id=12905#c48333 ). So I would leave it to Martin to decide as to whether there is an issue--i.e. does MMA fail to properly delete some artwork. |
|
|
3. looks like AA image is taken from Album that was searched by MMA attached picture of album art even each track have/haven't have own Images. and as album art is taken from first track listed on Album in this case track "Five - Until the Time Is Through" and ignores others and in Now playing Assigns that Image to UI |
|
|
3. As pointed by Rusty, this issue looks like related to 0011919 where Album share common AA and if it is incorrect user wants to delete which lead to different AA (newly searched and found) with old one assigned due the 0011919 which raises the question Which one to save/show eg. If track have Album filled and also have AA for singles release. MMW on the other hand like pointed in picture for each playing track shows its own Image correctly. Sync mask is "\Music\<Album Artist>\<Album>\<Track#:2> $Left(<Artist>,20) - <Title>" so this is long standing issue and and can cause AA search issues (fail search, missed AA) like pointed by Michal in offline testing/tweaking of AA searches, but unproved/not being able to replicate at teh moment. |
|
|
4. We should unify the approaches used for AA and Lyrics, but in the short term, it might be worth fixing a deficiency with lyrics editing: if mma searches and can't find lyrics, MMA doesn't give the user the option to manually edit lyrics (the only way to edit lyrics is if MMA first finds incorrect lyrics--which it sometimes can't)! A simple fix would be to add "Edit" next to the "Search" button. |
|
|
Re) 1 yes we should defer it to 1.3.2, AA editing screen will be needed for it. a)Tap Hold --> context options with two items: Delete Album Art Search alternate - > shows "AA editing screen" and automatically starts searching for alternate album arts b) Tap --> Open "AA editing screen" but do nothing automatically. For 1.3.1 Do you mean show context menu with just one item "Delete artwork"? Is this necessary for 1.3.1 when next dialog ask use again "Do you really want to remove album art?" or this dialog should not appear? 2) if "Update database" is not checked in Options, then looked up album arts are saved for tracks in NowPlaying(list) only (and not for media in library). MMA supports album art per album only, not per track. So when MMA found album art for one track, then all tracks with same album are updated by album art. ->BUG1: When user tap on missing Album art, delete dialog appears but it deletes nothing. SOLUTION: dialog should not appear 3) Different Artwork in Properties: - Properties dialog shows saved AA, so looked up AA is not displayed. In this case for one track from album was searched new album art and used for all album (in tracklist), but other tracks from same album had old album art in properties dialog. It was caused by bug. BUG2: Album art deletion dialog was deleting album art from selected media instead from all media with same album. SOLUTION: delete album art from all media with same album. |
|
|
1) For 1.3.1: I wouldn't bother with the confirmation dialog (i.e. just show the context menu). 2bi) Yes--no change required for 1.3.x, as long as Properties always shows what is actually saved. Note though that for the future MMA will support per track artwork 0011919. 2bii) The context menu option shouldn't appear. 3a) So the first bug should be fixed for 1.3.1. 3b) OK (for now--until 0011919 is resolved) |
|
|
Fixed in build 1.3.1.711 |
|
|
Verified 711 |
|
|
1a. Add Long press context menu to Main player screen |
|
|
Fixed in build 1.3.1.714 |
|
|
Verified 714 |
|
|
reopened for triage and possible move to new bug for 1.3.2 due the fact that original bug is fixed and we expanded functionality. |
|
|
Re-resolving. We can re-examine this in the future. ATM, the current solution seems reasonable. |
|
|
Closing since this was already verified. |
