View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0012965 | MMW v4 | Main Panel/Toolbars/Menus | public | 2015-11-17 21:49 | 2015-11-23 11:31 |
| Reporter | peke | Assigned To | |||
| Priority | high | Severity | major | Reproducibility | always |
| Status | feedback | Resolution | open | ||
| Product Version | 4.1.10 | ||||
| Target Version | 5.0.0 | ||||
| Summary | 0012965: Albums are not shown correctly for Artist & Album Artist tree nodes | ||||
| Description | When browsing Artist & Album Artist tree nodes list of Album sub nodes do not match Albums in track view. Eg. they incliude only those that both Artist and Album artist contain same search pattern (AND) instead using separate queries (OR) | ||||
| Additional Information | UXW-532-52787 | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Fixed in build | |||||
|
|
This is by design, since the tree is intended to represent parent-child relationships. From my perspective, changing this implies a change to what the tree hierarchy means (e.g. currently dragging and dropping an album between AA nodes changes the album artist--what would/should it do if you made the change being proposed?) and would have to be done very carefully. |
|
|
I Agree completely, my intention is that when user browse "Artist & Album Artist" tree node and like pointed parent-child relationships should comply with both Artist and Album artist. Current Drag And Drop behavior should be the same as it is correct approach only difference is that user knows all albums where selected "Artist & Album Artist" is existing. To be safe and retain correct behavior listing should behave like Album node in case Artist and Album Artist is different. Based on supplied picture - Destination Anywhere - Keep The Faith - Bounce (Bon Jovi) - Bon Jovi (Bon Jovi) - Blaze of Glory (Bon Jovi) - Rock Ballads CD1 (Various Artist) - .... Behavior: Drag And drop will only tag Album Artist like now allowing user to correct Album Artist eg. from this example D&D of "Bon Jovi (Bon Jovi)" would correct Album Artist to "John Bon Jovi", but if user click on Album "Rock Ballads CD1 (Various Artist)" all tracks from album would be shown to respect parent-child relationships even D&D of Tree Node would only Tag Album Artist of tracks actually contain "John Bon Jovi" in Artist/Album Artist @Ludek Let me know if you need any SQL query examples, but I think it shoukd be fairly easy to generate them. |
|
|
Also sounds to me like a significant design change. Moving target to MM5 to re-evaluate. Note that in MM5 we don't represent individual albums/artists in the tree, but in the main view and e.g. artist view is significantly different now, so not sure whether this issue shouldn't be just closed? Assigned to Rusty for revision |
|
|
1. I do not see big Design change, but bug as MMW show false data for "Artist & Album Artist" tree node Currently "Artist & Album Artist" tree node acts like "Album Artist" Tree node making MMW show incorrect Number of Albums eg. it shows only 2 Albums containing that Artist and 26 tracks (oldSQL.jpg). Instead "Artist & Album Artist" tree node should show 40+ Albums and 524 Tracks (newSQL.jpg). 2. Adding Album Artist to Parentheses will also correctly indicate that album is either compilation of Album Artists is different than Artist and note user that it needs to correct Album Artist or if clicking on Album will show rest of tracks or just those containing Artist in that album. NOTE: Adding Album Artist to Parentheses is not priority in case that is your reference to design change |
|
|
Reverted Back to 4.1 for revision due the design/functionality bug. And separate "Artist" and "Album Artist" Tree nodes work as they should problem is only in "Artist & Album Artist" Tree node which is enabled by default. Added corresponding pictures of each tree node. |
|
|
Per discussion, I don't consider this to be urgent, considering that the design has existed for several years, so I don't think it makes sense to risk regressions on such a fix at this time of MMW4's development (when we'd rather focus on fixing critically urgent issues, and include more strategic items in MM5). If it was simply a matter of changing which albums display in the tree, it wouldn't be a problem to make the change. The issue is that making that change might break drag and drop functionality (e.g. what would it mean to d&d an album that doesn't have an album artist from one artist to another?). |
|
|
Changed to feedbac so that Ludek can directly evaluate if just SQL query changes can be enough to retain current D&D Behavior. If Fixed as proposed and retaining cirrent behavior then D&D Albums that contain Artist = John Bon Jovi, Album Artist = Bon Jovi to tree Note John Bon Jovi will write down Album Artist = John Bon Jovi |
