View Issue Details

IDProjectCategoryView StatusLast Update
0014192MMW v4Properties/Auto-Toolspublic2018-07-08 14:03
Reporterpeke Assigned To 
PriorityimmediateSeveritycrashReproducibilityalways
Status closedResolutionfixed 
Target Version4.1.16Fixed in Version4.1.16 
Summary0014192: Tagging: Tagging Files with large Album Art can freeze MMW and Whole System
DescriptionWhen user tries to tag Files with large Album Art MMW Never finishes and Whole System eventually come to stall.

NOTE:
- For windows explorer such files crashes explorer on D&D
- MMW opens such files on File -> Open but freeze on metadata manipulation
Additional InformationTICKET ID
OVM-863-63852 (Size report from ticket is OK as MMW saves six 45mb Album arts in Tags)

Possible relations to the TICKET ID:
XOT-337-44643
TagsNo tags attached.
Fixed in build1833

Relationships

related to 0014193 assignedmichal MMW 5 Tagging: MMW tags file even it is disabled in options 
related to 0006467 closedLudek MMW v4 Error loading Album art properties when there lots of high res images 
related to 0014949 closedmichal MMW v4 Tagging fails FLAC (regression) 

Activities

michal

2017-04-18 13:23

developer   ~0047798

Last edited: 2017-04-18 13:23

For me, the problems with tagging start after playing this MP3 file with big images. Then tagging such file leads to never ending tagging thread with status bar message "1 file to be tagged". Without this, file is tagged as it should.
Another problems is with converting such file. e.g. to FLAC - it leads to not playable FLAC file, which crashes our f_flac_codec plugin.

michal

2017-04-18 14:49

developer   ~0047799

So tagging FLAC file with these big artworks always leads to corrupted FLAC file.

michal

2017-04-18 16:44

developer   ~0047800

FLAC supports only metadata up to 16 777 215 bytes, so we cannot store artworks larger than cca 16MB at all to FLAC files, it would always create wrong FLAC files.

michal

2017-04-19 17:25

developer   ~0047805

Problem with corrupting FLAC files fixed in build 1833, FLAC plugin will not store very large images to avoid file corruption (FLAC standard does not support metadata blocks larger than 0xFFFFFF bytes).

Freezing problem lies in Windows Explorer and we cannot do much with it probably. It seems, MP3 file with very large images causes Explorer to lock the file for ever (or for a lot of minutes) and sometimes freeze. It happens even when only listing such file in the folder in File Open dialog (not only in MM, in every other application too). Users should avoid tagging files with extremely large images (20-50MB in this example).

peke

2017-04-24 18:35

developer   ~0047841

Last edited: 2017-04-24 18:36

As taled on IM I further pursued Explorer crash and traced that actually explorer works OK, but it crashes due the thumbcache.dll that can't read album art from such files so once I unloaded thumbcache.dll fro memory files didn't crash explorer.

As noted we can't do much about it.

peke

2017-04-25 15:12

developer   ~0047848

Verified 1833

peke

2017-05-12 14:57

developer   ~0047964

Confirming verification in 1835 Closing