View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0014193 | MMW 5 | Tagging / organizing (properties / auto-tools) | public | 2017-04-18 10:09 | 2022-09-14 14:31 |
| Reporter | peke | Assigned To | |||
| Priority | high | Severity | minor | Reproducibility | always |
| Status | assigned | Resolution | open | ||
| Product Version | 5.0 | ||||
| Target Version | 5.2 | ||||
| Summary | 0014193: Tagging: MMW tags file even it is disabled in options | ||||
| Description | MMW tags file even it is disabled in options Test note: File must not be MMW library for easier replication 1. Disable Update tag on edit (Tools -> Options -> Library -> Tags) 2. Use File -> open to Open sample file from ticket in order not to trigger 0014192 3. Edit Track properties and Delete all album arts except first one which is 173KB 4. Press OK -> MMW do not tag file 5. Use Tools -> Convert Format and use copy not overwrite 6. MMW show Tagging and trigger 0014192 (thus it is notable that MMW changes original file) 7. Starts conversion and if wait enough (due the bug 0014192) it finishes (no bug there in MMW) NOTE: MMW should not start tagging on original file. | ||||
| Additional Information | TICKET ID OVM-863-63852 (Size report from ticket is OK as MMW saves six 45mb Album arts in Tags and sample file from ticket is used due the its size and that bug 0014192 revealed this bug) | ||||
| Tags | No tags attached. | ||||
| Fixed in build | |||||
|
|
Problem related to 14192 explained in 0014192. Moved to MM5. We should consider what to do, if Tools -> Options -> Library -> Tags -> Update tag on edit is not checked and user edits Properties for file not present in library, so the changes cannot be stored in DB. Peke thinks we should show something like "You have disabled Tag Update on EDIT and some files not in library have metadata changed, do you wish to update tags YES/NO/DO NOT ASK AGAIN". |
|
|
I guess MMW is supposed to write artwork to file tag once the option 'Save image to tag (if possible) otherwise save to file folder' is selected (Artwork section). i.e. independently on the 'Update tags when editing properties' checkbox (Tags section). |
|
|
We talk about any change in track properties, not only artworks. In fact the same as issue 0006763, only with option to choose, whether to really save changes to the file or not. |
|
|
Problem with respecting this option for My Computer nodes is that when the changes are not stored in the Library, they aren't stored anywhere, i.e. the edit doesn't do anything. That's the reason we implemented it this way in the past. Note that this fact is to some degree communicated by the fact the option is in 'Library \ Tags' sheet, i.e. is supposed to be relevant to Library tracks only. That said, I understand that it can be confusing. We possibly could show some kind of a toast message in this case. However, not a big priority imho. |
|
|
Revising this I mostly agree with Jiri. My original problem as seen from steps is that if user choose Convert Format with copy (not replace) original files should not be modified at all but rather only newly created file should be tagged. This is higher priority as MMW always tag source/original file even destination is new file. Otherwise If replace is used in convert tags would be saved anyway as part of conversion. A second dilemma is when we should toast the message, logically would be when MM looses focus/refresh track list leaving option that user can edit tag on source file and then initiate convert so that new file contain updated tags without compromising original/source file? Third thing is when track which properties are changed is in library and Update tag is disabled. What option is the priority as change is and should be stored in library? |
|
|
As Jiri pointed out, the Folders dialog is designed to always display what is in the tag and to tag changes. With that in mind, there's no need for a toast message when operating on tracks in the Folders node. When operating on tracks in other Library nodes (with Tagging disabled), I've verified that MM currently doesn't save or delete artwork from the tag. Rather than giving a warning that artwork tags weren't changed, it would be preferable to disable such functionality in the first place if tagging is disabled e.g. a) In file properties > Artwork: Disable 'Delete' for images that are saved to the tag b) Disable 'Remove image' context entries for images saved to tags c) In the 'add cover' dialog if either 'Save image to tag (if possible)' option is selected, then save to the File folder instead (currently MM shows that it saved to the tag even though it doesn't) d) For 'Paste' image options, if the default settings are either 'Save image to tag (if possible)' option, then save to the File folder. As far as the 'convert bug' I was unable to replicate a problem with the steps described. The steps described indicated to perform the test on tracks _not_ in the library, and such tracks are always accessed via the 'Folders' node which always updates tracks. Note: these seem to be relatively low priority issues, so we can push to 5.1 if it isn't trivial. |
|
|
I think that a toast message is more useful and can even offer a solution. A disabled control can be more confusing. I'd suggest something like 'Tags weren't updated according to configuration. Enable tag updates? [Enable] [Close]'. In any case, I'd defer this to 5.1. |
|
|
Saving tags under Folders node and non library files fixed in build 2220. MM5 did was not saving them in case library files tagging was disabled. Now it should work the same as MMW. The rest deferred to 5.1. I prefer also some toast message, because it would not be clear, why there is sometimes some editing disabled, this would give user hint what to do. |
