View Issue Details

IDProjectCategoryView StatusLast Update
0014311MMASynchronizationpublic2017-08-30 10:59
Reportermarek Assigned To 
PriorityurgentSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Target Version1.3.1Fixed in Version1.3.1 
Summary0014311: MMW inserts invalid album artwork value during USB sync
DescriptionI have added path verification to MMA so we can detect invalid paths in mmstore.db.synced.

Now there are many occurences of crashlogs where path is '-'. This char is used as flag by MMA to mark that the album artwork was lost/deleted. It should be restored during next sync from MMW. Here I could see that media was updated with this flag by MMW. But it should be replaced by valid album art path or by null value.

There are many occurences from different devices using these MMW builds 1813-1840

TagsNo tags attached.
Fixed in build721

Relationships

related to 0013046 closedLudek MMW v4 MMW doesn't update lost artworks during sync 

Activities

Ludek

2017-07-25 11:46

developer   ~0048401

I traversed the code carefully and verified that MMW couldn't write '-' to media.album_art at all. It always writes null or a value with (at least) image file extension (*.jpg, *.thm).

The only idea I have is that DB triggers like insert_media_* would remain in the mmstore.db while processing by MMA and inserting a new track by MMA would cause the trigger call and thus writing to sync_operations table?

Ludek

2017-07-25 19:12

developer   ~0048408

Marek added more debug info to the next MMA build to find more...

marek

2017-07-25 20:28

developer   ~0048409

Triggers cannot cause it... mmstore.db (internal MMA DB) and mmstore.db.synced (from MMW) are two different DB files and these MMW triggers are never created in internal mmstore.db.

Now I am sure that there is a update (not insert as mentioned in issue description) operation for album artwork value with '-' char as new value.

In next build 719, mmstore.db.synced will be packed in crashlog so we can see all records in sync_operations table

marek

2017-08-09 21:51

developer   ~0048500

Fixed in build 721

peke

2017-08-30 10:59

developer   ~0048609

Verified 724 along with ":" tests