View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0014703 | MMW 5 | Now Playing | public | 2018-03-29 20:17 | 2018-04-18 22:08 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 5.0 | ||||
| Target Version | 5.0 | Fixed in Version | 5.0 | ||
| Summary | 0014703: Show/Hide Now Playing actually is Right Panel Toggle | ||||
| Description | Currently, the button in the player to 'Show Now Playing' actually toggles the right panel. This results in some confusing behavior. e.g. if the user closes Now Playing via the titlebar, and then enables it via the toggle in the player --> an empty panel appears! This inconsistency between Player > Toggle Now Playing and View > Hide Now Playing can be resolved as follows: a) Remove the toggle from the Player, and instead place it at the rightmost edge of the menu bar (i.e. Collapse/Expand Right and Left would have equivalent though opposite icons). This makes sense since some users may not even use the Right Panel for Now Playing. The downside is that the menu bar doesn't have much room and it'll be challenging to fit the Open/Collapse button. b) Modify the functionality of the Show/Hide Now Playing button so that it re-actives Now Playing if it's been disabled. The first approach seems to make more sense. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2096 | ||||
|
|
Per IM with Michal, we could implement both, i.e. a) We'll add the button to the toolbar. b) We'll modify the button functionality in the Player, but we'll also hide it by default (since the Toolbar button will probably cover most of the usecases). |
|
|
Fixed in build 2094. |
|
|
Tested 2095 and it's mostly working correctly. One new related issue: c) Enabling/disabling the menu bar causes the position of the right-panel toggle button to change. i.e. it normally appears on the right margin, but after enabling/disabling the menu bar, it appears to the left of the menu button. EDIT: per discussion with Jiri, the placement of the Menu button isn't ideal. It might be better to situate it immediately to the right of the MediaMonkey icon. This would require deprecating 'bordered' skins. |
|
|
C fixed in build 2096. |
|
|
Not sure about placing menu button to the left top, browsers like Chrome have menu button on the right side under maximize/minimize/close window buttons, could be confusing. Anyway, menu button should not be part of this issue. |
|
|
Verified 2098. |
