View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0014709 | MMW v4 | Properties/Auto-Tools | public | 2018-04-02 08:51 | 2018-05-31 20:39 |
| Reporter | peke | Assigned To | |||
| Priority | urgent | Severity | major | Reproducibility | sometimes |
| Status | closed | Resolution | reopened | ||
| Target Version | 4.1.21 | Fixed in Version | 4.1.21 | ||
| Summary | 0014709: Album Art: Some Images are incorectly presented | ||||
| Description | Based on User at https://www.mediamonkey.com/forum/viewtopic.php?f=7&t=89522 MMW incorrect decode and show some Image formats | ||||
| Additional Information | https://www.mediamonkey.com/forum/viewtopic.php?f=7&t=89522 https://github.com/JackTrapper/pngdelphi | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1867 | ||||
|
|
I see, the issue of darken red color is for the 4bpp.png image (Bit depth 4), isn't issue for 8bpp.png and 24bpp.png The issue exists in MM5 too |
|
|
I've tried to update our PNG library from version 1.4361 (year 2003) to 1.564 (year 2006 at https://github.com/JackTrapper/pngdelphi ), but it doesn't solve the issue so I left the old (one as it is customized for MM5). Also by a brief code analyze of the library I haven't found reason for the darken red color. We could try some alternate PNG libraries (e.g. https://github.com/graphics32/GR32PNG ), but this could be risky to include into 4.1, moving target to MM5... |
|
|
Finally I found working version of the original library, moving target back to 4.1.21 |
|
|
Fixed in 4.1.21.1866 and merged into 5.0.0.2094 @Peke, please test on various PNG formats for regressions. |
|
|
Verified 1866 Left resolved till user confirmation. |
|
|
Closing, user also confirmed fix. |
|
|
Reopen for regression check I uploaded elf file to FTP under "/!TempFiles/bugs_14790and14824and14709.rar" as it looks like there is an regression in PNGImage.pas |
|
|
I downloaded the rar and extracted, you are probably referring MediaMonkey.elf that crashes in TPngImage? Based on the log it happened while loading covers of file G:\mp3\30 Completed\Yeah Yeah Yeahs\It's Blitz!\02-Heads Will Roll-Yeah Yeah Yeahs-It's Blitz!.mp3 Could you please get the file and associated artwork files for me? |
|
|
Peke sent me the file over IM, assigned back to me for analyze |
|
|
Fixed in 1867. |
|
|
Verified 1867 |
|
|
Re verified in 1868 on much larger sample cases. |
