View Issue Details

IDProjectCategoryView StatusLast Update
0014875MMW v4Properties/Auto-Toolspublic2018-06-15 23:22
Reporterpeke Assigned To 
PriorityimmediateSeveritymajorReproducibilityalways
Status closedResolutionreopened 
Target Version4.1.21Fixed in Version4.1.21 
Summary0014875: AutoTag From Filename: Fail completely on Some Masks
DescriptionAutoTag From Filename: Some masks fail completely on some masks and mask format where non plain Alphabet chars are in filename.
Additional InformationVTJ-517-43239 with Track Number mask example where specific mask length needs to be defined in order to make mask work
TagsNo tags attached.
Attached Files
bug14875_3.jpg (225,804 bytes)   
bug14875_3.jpg (225,804 bytes)   
bug14875_2.jpg (245,489 bytes)   
bug14875_2.jpg (245,489 bytes)   
bug14875_1.jpg (239,433 bytes)   
bug14875_1.jpg (239,433 bytes)   
Fixed in build1870

Relationships

related to 0008837 closedLudek Mask: Auto Tag from Filename not fetching Info correctly in some cases 
related to 0007023 closedLudek 1129 Infer track properties can give odd result 

Activities

peke

2018-06-15 01:09

developer   ~0050541

bug14875__3: <Artist> Mask is Ignored
 bug14875__2 and bug14875__4 : "." in Mask to tell where end of <Artist> is Ignored
 bug14875__1: Works
bug14875_4.jpg (217,007 bytes)   
bug14875_4.jpg (217,007 bytes)   

Ludek

2018-06-15 09:13

developer   ~0050542

Last edited: 2018-06-15 11:25

Re your screenshots above, I see - whenever the artist is just number then it is ignored.
This is probably correct as I cannot think of any artist name that is just a number, I know alfanum artists (like '4Hero', 'U2', '1+1') but don't known an artist just called as '02'.
EDIT: The change (to accept only non-numeric artist strings) was made in course of 0007023 where for 'C:\02-Amor_y_celo_c209530e.wma' the '02' was detected as Artist instead of Track#.


Re: VTJ-517-43239 (original issue):

Firstly I couldn't replicate the issue, used mask '<Genre>\<Artist> - <Album>\<Track#>-<Title>'
results: https://www.dropbox.com/s/s81w6twxm053ykm/Screenshot%202018-06-15%2011.09.45.png?dl=0

But then I accidentally realized that if I add a trailing space to the mask: '<Genre>\<Artist> - <Album>\<Track#>-<Title> '
then the bug occurs https://www.dropbox.com/s/4ih35cb2epldvq1/Screenshot%202018-06-15%2011.11.59.png?dl=0

This was caused by a fix of 0008837 (for the '<Track#>.' works same like '<Track#>.<Skip>')

Fixed in 1870 by trimming the masks (low risk fix) and covered by unit tests.

peke

2018-06-15 11:49

developer   ~0050543

Last edited: 2018-06-15 11:54

I agree on artist not being just 02 but I checked I have bunch of artists having three numbers like 911, 187, 357, ...

re 0007023: It is Ok in Infer track properties, but it should be ignored in hard case mask is set in Auto Tools like tag from filename. See which behavior works better especially as it is working like that for years with only few complains.

Few more tests and it looks like problem is when "." is used in as Mask Separator where single Space can make huge difference in detection. I can also conclude that MMW is doing great jog in detecting it correctly.

Filename: Viva Club Rotation, vol. 11 (CD 1) (2000)\F.P.I. Project - Rich in Paradise (Going Back to My Roots) [Normal Radio Edit].mp3
Masks: "<Artist>.<Title>" and "<Artist>. <Title>"

Ludek

2018-06-15 13:11

developer   ~0050544

As discussed offline with Peke:
Artists like 911 does exist in the real world, so they should be ignored only in case of automatic tag guessing (inferring properties) and only when length of the numeric string is less than 3 (like '02')

Fixed in 1870

peke

2018-06-15 23:22

developer   ~0050546

Verified 1870