0015229: Tags Not saved: When BitLocker is used MMW do not save tags - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0015229	MMW v4	Properties/Auto-Tools	public	2018-12-03 09:31	2018-12-31 13:20

Reporter	peke	Assigned To
Priority	immediate	Severity	major	Reproducibility	always
Status	closed	Resolution	won't fix
Target Version	4.1.24

Summary	0015229: Tags Not saved: When BitLocker is used MMW do not save tags
Description	1. When BitLocker is used MMW do not save tags when tracks are in Users folder and work flawlessly if tracks are outside Users folder like c:\Music User have full access rights and even then User can't Edit/Delete files from MMW and silently fail to update tags. 2. Also when we try to install MMW Debug on system, Setup reports attached error and can't create Public Folder LNK and path exists on System 3. When we created DBGView LOG it could not be saved on desktop but we used External USB to save logs. I'm not sure if we can do anything in MMW, but if LOG confirm findings from remote session KB Article needs to be created NOTE: Updating Rating from File Properties in Explorer works and are refreshed in MMW on re scan.
Steps To Reproduce	1. Tried to Edit Tags on file in Users folder -> Failed 2. Edit same file on USB it updates it correctly Log File In Ticket
Additional Information	YMQ-736-56282
Tags	No tags attached.
Attached Files	bug15229_1.jpg (206,431 bytes) bug15229_1.jpg (206,431 bytes) bug15229_2.jpg (26,463 bytes) bug15229_2.jpg (26,463 bytes)

Fixed in build

Ludek 2018-12-10 09:38 developer ~0051715 Last edited: 2018-12-10 09:39	I cannot confirm that the tag was not written as rrom the debug log (attached to ticket YMQ-736-56282) I see: 00002268 72.79450226 [11460] MP3: Going to write tag to C:\Users\Niklas\Music\Jukebox\01 Hip-Hop & Rap\Antilopen Gang\2015 Abwasser\04 - Antilopen Gang - Abwasser - Lügenpresse 1 (Skit).mp3 00002269 72.79452515 [11460] MP3: Writing ID3v2 00002270 72.81676483 [11460] MP3: Updated ID3v2 00002271 72.81683350 [11460] MP3: Writing ID3v1 00002272 72.81796265 [11460] MP3: Updated ID3v1 00002273 72.81809235 [11460] 22460 DB exec SQL: UPDATE Songs SET FileLength=1968256, TrackModified=43437.368654803,FileModified=43437.368654803 WHERE ID=9563 00002274 72.81813049 [11460] 22460 DB lock successful. 00002275 72.81835175 [11460] 22460 DB lock finished, took 497. 00002276 72.81864929 [11460] RestoreFromTagging starting. 00002277 72.81868744 [11460] RestoreFromTagging finished. 00002278 72.81873322 [11460] Tagging: Track was tagged: C:\Users\Niklas\Music\Jukebox\01 Hip-Hop & Rap\Antilopen Gang\2015 Abwasser\04 - Antilopen Gang - Abwasser - Lügenpresse 1 (Skit).mp3 So it looks like if the track was successfully tagged. Michal, is it possible that it is false positive? Could you please verify that if a track fails to update the tag that the error is seen in the debug log? Otherwise whenever MM is unable to save the tag then we could possibly show the error log that auto-disappears in 10 seconds so that user is aware of that, but probably a "dont show this again" option is needed. To be reviewed by Rusty at first...

peke 2018-12-10 17:27 developer ~0051721	I can confirm that file tags are not written as they are identical even we changed Artist and added additional album art so that size must change and that HEX compare must find changes. Moving file to User desktop or to c:\TEMPFOLDER\ it cant be written even permission to write to file is set to Everybody. If same file is moved to external HDD than MMW update it normally.

michal 2018-12-12 14:37 developer ~0051753	I can confirm bug in id3lib, it is ancient regression. I will fix it for MM5 only, we already do not compile id3lib in MMW a it would be risky to change it, as it is not so serious bug (not accessible and not writable files are mostly detected before tagging attempt). Tracked as 0015257.

peke 2018-12-31 13:19 developer ~0051898	This is fixed in MM5 only due the high risk of regression and introducing new issues.