View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0015333 | MMW v4 | Collections (Filters) | public | 2019-01-11 21:18 | 2020-01-30 07:15 |
| Reporter | lowlander | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | no change required | ||
| Product Version | 4.1.23 | ||||
| Target Version | 4.1.24 | Fixed in Version | 4.1.24 | ||
| Summary | 0015333: Neoclassical and Classical Rock are incorrectly set as Type = Classical Music | ||||
| Description | Files with the genre of Neoclassical or Classical Rock are incorrectly set as Type = Classical Music. We should consider exact matching of Genre to set Type = Classical Music. Some Genre suggestions to set as Type = Classical Music would be: Avant-Garde, Baroque, Chamber Music, Chant, Choral, Classical, Classical Music, Classical Crossover, Early Music, High Classical, Impressionist, Medieval, Minimalism, Modern Composition, Opera, Orchestral, Renaissance, Romantic, Wedding Music | ||||
| Steps To Reproduce | To update: https://www.mediamonkey.com/wiki/index.php?title=WebHelp:Playback_Rules/4.0 | ||||
| Additional Information | https://www.mediamonkey.com/forum/viewtopic.php?f=4&t=61509 https://www.mediamonkey.com/forum/viewtopic.php?f=21&t=95712 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1883 | ||||
|
|
As detection is mostly hardcoded maybe an INI switch would be good to allow users to set their own parameters. |
|
|
I changed the rules for the file to be considered as Classical music when - genre includes one of the words 'Classical', 'Classical music', 'Avant-Garde', 'Opera', 'Orchestral', 'Baroque', 'Chant', 'Choral', 'Chamber', 'Impressionist', 'Medieval', 'Renaissance' - genre does not include 'Neoclassical', 'rock', 'jazz' Changed in 4.1.24.1883 and merged to 5.0.0.2049 As for the INI switch, I guess that users would hardly realize that there is an INI option(s) for this. If any, we could add an UI config for this in Options for MM 5.1, but does not seem to be at high priority atm. |
|
|
As for the config, some users (see https://www.mediamonkey.com/forum/viewtopic.php?p=454841#p454841 ) requests an option to ignore autosort to type based on tag value and have all new files added to the library with the same extension default to the same type. So that all mp3's and flacs, etc. default to being Music. I guess it makes sense to add a general checkbox that would disable the current auto-guessing of file type ? Assigned to Rusty for review and wording. |
|
|
I would not just make global switch as problem is rather tweaking than complete disable. Adding a way (maybe even in DB directly, as UI plugin can be easily made) to be able to tweak per type detection is more useful than global fix. User even agree that even hidden availability would work for him. This will be especially useful in tweaking Movies and TV series where we have much less experience than in music detection. |
|
|
I think that the real solution is to allow the user to configure what Genres to be assigned to a Type. That said, this seems to be really low priority since the most significant problem is the fact that users were confused about where there content was located and this _is_ configurable via 'Media Tree'. So my recommendation would be to not make any changes atm. |
|
|
Ok, so resolving as no change required. |
