View Issue Details

IDProjectCategoryView StatusLast Update
0015406MMW 5Tagging framework / input pluginspublic2019-02-06 03:56
Reportermichal Assigned To 
PriorityimmediateSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version5.0 
Target Version5.0Fixed in Version5.0 
Summary0015406: Some specific MP3 file corruption in ID3 tags can lead to crash during reading tags
DescriptionUser has MP3 file in issue 0015404, which contains 1MB of binary data in ID3 tag in text field, because of previous mess in combination of ID3v2.2 tags and ID3v2.3 tags. The crash was partially caused by fix of 0009311, where we try to read tags with ID3v2.2 name from ID3v2.3. This example shows, that it is not so safe, so we should better ignore such tags. It will lead to not reading tags from 0009311, but it should not crash. And we should add some length limitation when reading text field from ID3, so it will ignore text fields with more than e.g. 100000 chars. With exception for lyrics and comments, where we expect possible larger data by design.
Additional InformationCZE-506-41673
TagsNo tags attached.
Fixed in build2154

Relationships

related to 0015404 closedmichal MMW v4 MediaMonkey reads Title incorrectly 
related to 0009311 closedmichal MMW v4 MM sometimes cannot read ID3 tags for some specific files, whereas Winamp or WMP can. 

Activities

michal

2019-01-30 15:52

developer   ~0052348

Fixed in build 2154. Issue from 0009311 can now rarely occur, but current solution is more stable.

peke

2019-02-06 03:56

developer   ~0052423

Verified 2154