View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0015531 | MMW 5 | Main Panel | public | 2019-03-08 08:35 | 2019-09-13 02:32 |
| Reporter | Ludek | Assigned To | |||
| Priority | urgent | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | won't fix | ||
| Product Version | 5.0 | ||||
| Target Version | 5.0 | Fixed in Version | 5.0 | ||
| Summary | 0015531: Enhance undo functionality | ||||
| Description | It seems that enhancing undo functionality is requested: https://www.mediamonkey.com/forum/viewtopic.php?f=30&t=93986 We can hardly add a general undo for all actions with history, but we might enhance our current Undo in toast messages after some actions. e.g. currently if you rate a song that is not in library then there is a toast message shown ('Track was added to library' [Undo]) We could enhance this functionality and show the toast messages also: - when a library tack is rated (to undo the rating) - when a track is deleted from playlist and confirmation dialog is disabled | ||||
| Tags | No tags attached. | ||||
| Fixed in build | |||||
|
|
Undo after changed rating fixed in build 2195. Deleting is very complex feature, one delete could delete from playlist, library, nowplaying and disk, undo in this would be quite complicated. That is why we have confirmation dialog there, if somebody makes wrong deletions often, he/she should have confirmation dialog enabled, to avoid unneeded changes. Shift+Delete in Windows also does not have any undo... Resolving to test rating. Reopen then and set target version and priority, if you think, we really should somehow implement other Undo(s). |
|
|
Main View Rating Verified 2195 NOTE: When rating is done in Now Playing as it should be notified also in UNDO List, which ATM contain only only Add/Delete |
|
|
Changed rating is related to the track only, changes its property, has nothing to do with nowplaying list, it does not affect this list in any way, so it does not make sense to add it there. We track only changes which affect nowplaying list composition, cannot track other changes. Resolving. |
|
|
The new functionality (pop-up in response to a rating change) isn't a good solution. I'm listening and rating tracks and every time I rate a track a popup appears--it's very annoying! I would suggest reverting this change, as the solution is worse than the problem. The user was primarily looking for an 'undo' function that's similar to that in other apps (edit>undo). If we want to improve 'undo' functionality, and avoid the complexity described by Michal, we should: - decide what subset of functionality we want to support - implement it in a manner that doesn't result in continuous pop-ups |
|
|
Toast messages are meant to be warning, that something was changed, e.g. rating, that theoretically could be changed unintentionally (and could take it back by undo button). If the action of changed rating will only go silently to some undo list, user will not notice, that something was changed. Jiri, what do you think? |
|
|
What about using Status Bar instead of toast which would be less intrusive? |
|
|
1. As for the Undo Toast message after rating a non-library track, I think that it's useful, since the rating results in something not obvious (adding track to library) and so it's a good idea (imho) to notify user about this. In case someone does this often (I doubt so), it might be useful to add a 'Do not show again' button to the toast, so that it doesn't appear ever again. 2. I think though, that the message after rating a _Library_track_ is rather superfluous and would better be removed. The real solution is a true Undo functionality, which we might focus on sometimes in the future (5.1 or so). |
|
|
1) "Do not show again" is not very applicable there, because toast is displayed only several seconds, so user has very short time to read it and understand. Probably really not needed for situation with non-library tracks. 2) tracked in #15931 So reverting to the previous state, resolving. |
|
|
Verified 2196. |
