View Issue Details

IDProjectCategoryView StatusLast Update
0015681MMW 5Generalpublic2020-12-18 01:43
Reporterrusty Assigned To 
PriorityhighSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Product Version5.0 
Target Version5.0Fixed in Version5.0 
Summary0015681: Provide user feedback in cases of failed tagging / playback
DescriptionAs reported at 0015640 / 0014650 / 0015818, there are cases where files are corrupted, resulting in failed playback and/or tagging, but MM's feedback atm is limited to greying out the track during playback, which is of limited value to many users in understanding the problem.

It might be worth considering adding toast messages in such cases. e.g.:
a) 'Playback failed': <filename> is inaccessible.
b) 'Playback failed: <filename> is corrupted.'
c) 'Tag update failed: <Filename> is corrupted.'

Peke suggested doing something more comprehensive during the scanning process at #11179, but as Jiri indicated there, we'd have to approach it on a case by case basis. Would a simpler approach as described above make more sense? Are the error cases easily recognizable? Are there any other error cases that should be added?

Jiri, please assign to Michal for feedback if you think that this approach makes sense. Probably not the highest priority though.
TagsNo tags attached.
Fixed in build2260

Relationships

related to 0015640 closedmichal MM5 Codec Pack M4A: M4A files with Id3 tag fail to play and crash MM 
related to 0014650 closedmichal MMW 5 WMA: ID3 written in front to WMA header make WMA unplayable 
related to 0016240 closedLudek MMW 5 Playback: Playback fail on all tracks 
related to 0015372 closedmichal MMW 5 Attempts of generating thumbnails for audio files with video extension last too long 
related to 0015478 closedmichal MMW 5 M4P: Syncing M4P files can crash MMW 
related to 0015818 closedmichal MMW 5 WAV: WAV files with ID3 tag fail to play 
related to 0015843 closedmichal MMW 5 OGG: Incorrect Extension makes files unplayable 

Activities

jiri

2019-05-20 08:20

administrator   ~0053571

Toasts like those suggested seem to make sense to slightly clarify the problem.

rusty

2020-01-22 23:22

administrator   ~0056140

Note: I wonder whether the implementation of 0016240 would be better served by a toast as suggested here.

michal

2020-07-09 09:48

developer   ~0058821

Implemented in build 2260.
Used toast messages:
File %s cannot be decoded. It is possibly due to DRM restrictions. (when detected encrypted file)
Playback failed: %s is inaccessible.
Playback failed: %s cannot be decoded. (when playback fails because decoder cannot decode it for some reason).
Tag update failed: %s is inaccessible.
Tag update failed: %s has wrong format. (tagging plugin detects format problem and refuses to tag it)

Sometimes the corrupted file is not greyed out with toast error and just skipped, it is the same in MM4, we cannot detect corruption already during starting playback sometimes.

peke

2020-07-10 22:00

developer   ~0058863

Last edited: 2020-07-10 22:01

Verified 2260

Only change I would make that in case 'Playback failed: %s cannot be decoded.' I would change it to 'Playback failed: %s cannot be decoded. Try our Codec Pack' (link to codec pack page)?

michal

2020-07-11 12:04

developer   ~0058891

In case we detect, that some codec or codec pack could help, we display standard "Missing codec" dialog like before.

peke

2020-12-18 01:43

developer   ~0060896

Re verified 2286

original issue and implementation from 0015681:0058821 works further wording if needed can be reopened after Mm5.0 as localization is locked. Closing