View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001606 | MMW v4 | Properties/Auto-Tools | public | 2004-11-18 13:33 | 2007-08-24 17:56 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 3.0 | ||||
| Summary | 0001606: Ability to Remove/Edit/or Apply existing Album Art for multiple tracks via Properties dialog | ||||
| Description | When the user selects multiple tracks and tries to edit Album Art properties via the Properties dialog, they expect to be able to accomplish various Album Art editing tasks, however, there's currently no means of: a) removing existing art from all the tracks b) choosing 1 or 2 Images (from within the existing set of tracks or from an external source) and applying them to all tracks (replacing whatever exists). Note: I think that b) and c) are the most common requirements What should occur is that _all_ of the Album Art from _all_ of the selected tracks should appear so that the user can choose which set of art to delete/apply. | ||||
| Additional Information | Raised at: http://www.songs-db.com/forum/viewtopic.php?t=2771 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1063 | ||||
| parent of | 0001605 | closed | Ludek | Album Art: Adding image to multiple files via Album Art window only updates the first one |
| has duplicate | 0002665 | closed | rusty | Album Art Properties are Not Shown when Whole Album is selected |
| related to | 0002997 | closed | petr | Album Art View: Image editing functions missing/inconsistent |
|
|
I don't think it's that simple, such mass transfer of album art would need more complex solution. First of all user would need to select whether to do _any_ album art modification of the edited tracks, then which album art to include. I think it's too complex not only to implement but also to understand by users. Also, I don't think it's too useful now when user can easily edit album art for whole albums. |
|
|
I think that this is needed. Imagine the following scenario: User selects 3 tracks from a single album, clicks properties|Album Art, because he wants to add the front cover of #1 to #2 and #3 which are missing it. In the current build, this doesn't work--the Album Art panel in the dialog comes up Blank!! What should happen is that the Album Art tab displays _ALL_ Album Art from all of the selected albums. Each Album Art has a checkbox next to it and is unchecked by default. If the user checks any checkbox, then the set of Album Art that has been checked (and only the set of album art that has been checked) is what gets stored to all of the files. |
|
|
There are some reasons why I think it shouldn't work like this: - A global checkbox would be needed in order to specify that user wants to make _any_ album art modification. It's because the default state would mean 'remove album art from all selected files'. - The whole thing can be quite time and particularly memory consuming. Just imagine user selecting a really big set of tracks using this feature. - Other kind of problems would be in what to show. What about a picture that's the same in two files, but has different image type or comment assigned in them? - And the last point is that user can do this quite comfortably using the new functionality of applying album art to all tracks of an album. As far as I know, this is much more than other apps (iTunes, WMP) can do. |
|
|
To counter the point's you've raised: -The fact that a checkbox would be needed to make changes to any album art for a Mass Edit of tracks shouldn't be a usability problem--that is exactly how mass edits of ALL fields work; i.e. the change (addition/deletion) only takes effect when the checkbox is checked -Re. time/memory: you can set a limit e.g. display a max of the first 40 tracks (but apply changes to all tracks) -Re. what to show: I think it's ok to show images whenever any aspect of the image/comment is different -Re. the fact that they can already do this through another path: I agree that they probably can (in a reasonably unconfusing manner once 0001598 is resolved), however the fact remains that users would _expect_ to be able to accomplish this task in a more advanced manner via the Mass Edit tool, but can't. p.s. Another usecase in which this would be needed is: -User has 10 tracks in an Album that have a mixture of incorrect Art -Currently the user would have to delete the Art track by track -With this new function, the user could select and delete all incorrect Art and then Add a new replacement Cover. |
|
|
I've rethought this: The biggest problem is that with the new Album Art view, it's possible to see the album art for multiple tracks on an album, _along with mistakes in the art_. However, it is currently near-impossible to correct such mistakes. i.e. -there's no way to delete Art from a set of tracks that don't have matching art -there's no way to replace existing inconsistent art for a set of tracks that don't have matching art After further thought, the simplest means of fixing this would be: Make editing of Album Art in the properties dialog work exactly the way editing of other properties works. i.e.: -if all selected track have identical album art, then the art should be shown (currently users are confused when it doesn't appear). -if all selected tracks don't have identical album art, then (although it would be nice to show all the sets of album art) the album art should not be shown, and the user knows that an edit may be required. -if the user selects no art, then existing album art is deleted (just as occurs with other properties). Then the user can subsequently add corrected artwork. Note: If a user makes a change in this dialog, the required operation would be to removed any artwork that hasn't been explicitly selected, and add artwork that has been selected according to the prefered location for Album Artwork. |
|
|
Ok, we can make it like this, we just have to add a check box, like [ ] Update album art of all selected tracks that will specify whether to update the selected tracks or not (when >1 track properties are shown), just the same way as we have a check box for other fields in this case. It would be automatically checked after any change of album art. |
|
|
Sounds good, though I'd prefer to simply: [ ] Update all selected tracks (this should probably appear in place of 'Apply to all tracks on the Album' which appears when editing album art for only a single track) Also, if all selected tracks don't have identical album art, but there's only 1 set of available art in 1 or some of the tracks, then the available art should be shown (this is how the algorithm currently works e.g. if album title is missing for most tracks, but one of the tracks has an Album title). |
|
|
I little more refinement due to the fact that the Album Art view does NOT show the user which tracks are inconsistent: By default, the Album Art Properties Tab should work similarly to how mass-edit of comments used to work. i.e.: -if all selected track have identical album art, then the art should be shown (currently users are confused when it doesn't appear). -if all selected tracks don't have identical album art, then all album art should appear (if memory is a problem, you can make a limit that this works up to e.g. 200 tracks--i.e. disable the art from appearing and the checkbox from working for > 200 tracks) -a checkbox appears, always unfilled, below the entire Art list, and if the user adds/removes art from the list, then the checkbox is filled in. When the user clicks OK, the changes are committed. Here's the layout: [ ] Apply to all selected Tracks . . . . . [Add] [Remove] ^ v Note: If there's any change made, it should be saved according to the prefered location for Album Artwork. Note: if only a single track is selected, then Properties | Album Art should work exactly as it does today with one small change: [ ] Apply to all Tracks on the Album . . . . [Add] [Remove] ^ v (this is to avoid confusion caused by the fact that the 'Apply' functionality works even if the user doesn't click Add/Remove). |
|
|
In the interest of time, let's do the simpler implementation that we earlier agreed to (comment 8283): Make Mass Edits of Album Art in the properties dialog work exactly the way mass edits of other properties works. i.e.: -if all selected track have identical album art, then the art should be shown (currently users are confused when it doesn't appear). -if all selected tracks don't have identical album art, then (although it would be nice to show all the sets of album art) the album art should not be shown, and the user knows that an edit may be required. -at the bottom of the dialog appears either: . -If the tracks are from different albums: [ ] Update all selected tracks . -If the tracks are all from the same album: [ ] Apply to all tracks on the album -if the user selects no art, then existing album art is deleted, assuming the user checks off 'Update all selected tracks'. Note: If a user makes a change in this dialog, the required operation would be to removed any artwork that hasn't been explicitly selected, and add artwork that has been selected according to the prefered location for Album Artwork. |
|
|
Fixed in build 1062. - I implemented the former suggestion since it wasn't that much complex. |
|
|
This is generally working quite well except for one usability quirk. Currently when the user selects an Image in the Properties dialog and clicks the 'Remove' button, the following prompt appears: "Do you really want to remove the selected image? [[Yes]] [No]" This prompt is completely unnecessary since clicking 'remove' doesn't actually commit the change--the change only occurs when the user clicks 'OK'. |
|
|
Fixed in build 1063. |
|
|
Verified 1063. |
