View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0016065 | MMW 5 | Main Panel: Toolbars & Menus | public | 2019-10-28 14:53 | 2022-12-15 16:15 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | tweak | Reproducibility | always |
| Status | feedback | Resolution | reopened | ||
| Product Version | 5.0 | ||||
| Target Version | 5.2 | Fixed in Version | 5.0 | ||
| Summary | 0016065: Context menu cleanup | ||||
| Description | A couple of suggestions to reduce clutter and add functionality in the context menu: 1) Remove 'My Rating'. This functionality is available directly in the tracklist, player, and A&D/Preview windows. 2) Add 'Lookup image...' when right clicking on AA in Folders [List by Album] 3) Is it possible to add 'Lookup image...' whenever the user right clicks on the image in all views? Currently right-clicking on the image in [List] views has no effect. | ||||
| Additional Information | Note: Lookup image suggestion was raised at https://www.mediamonkey.com/forum/viewtopic.php?f=30&t=95315 https://www.mediamonkey.com/forum/viewtopic.php?t=103164 | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Fixed in build | 2220 | ||||
|
|
Fixed |
|
|
Tested 2210. Looks good, just re. 3) I see that 'Lookup image...' has been added to _all_ tracks (not just when right-clicking on images). I suppose that this is fine if this is easier. 4) The context menu for the Playlist section of the tree has items mixed up in the top section i.e Lookup image... should be removed New Playlist... and New AutoPlaylist... should appear _together_ in the top section (they are currently separated) Edit in Playlist panel should appear below New AutoPlaylist (it's currently missing) 5) Given the large context menus for tracks, we might want to re-ordering the bottom portion of the context menu from: Auto-Tag... Auto-Tag from Filename... Auto-Organize Files... Convert Format... Analyze Volume Level track volume Lookup image... ----------------------------- Pin it ------------------------------ Properties to Auto-Tag... Auto-Tag from Filename... Auto-Organize Files... Lookup image... Properties ----------------------------- Convert Format... Analyze Volume Level track volume ------------------------------ Pin it OR Move Properties up to the section with all the other tagging/organizational tools (leaving Pin it by itself). Note: the above approach should be applied to the tree/NP list as well |
|
|
Fixed |
|
|
I wonder if we can also improve context menu of album browser where Album View have confusing context menu. eg. in some places it is absent and in some places it is too big and contain non needed stuff. 1. Album art Play now/next/last/shuffle/shuffle by album I guess it can be put into sub context meny like when you click on Shuffle button. Same goes for play options as it will clear things a lot 2. Album name Context is missing 3. Artist context only have open link in new tab See video https://www.screencast.com/t/HiUO2YFMNK |
|
|
Some feedback here: https://www.mediamonkey.com/forum/viewtopic.php?f=30&t=95368 Mainly points #1 and #2 are valid #2 is moved to 0016005 #1 could be resolved by eliminating the top-right-corner close buttons for the "Preview" and "Playing" panels? |
|
|
Re. #1, I agree--now that we control the UI via 'panels', the 'x' hover buttons aren't needed. |
|
|
Close buttons eliminated in 2212 |
|
|
A couple of additional items (though I don't quite understand Peke's feedback), based on a review of context menus throughout MM5: 5) Home node (in the Tree): the only item that makes sense is Configure Collections and nodes 6) Podcasts node (in the tree): Edit Collection should show 'Edit Collection' just below 'Configure Collection and nodes' (currently they're split) 7) CD node (in the tree): Currently it shows all track-related commands, but afaik, it should only show: Rip audio cd, Get album info from freedb, play now/next/last, play shuffled, auto-tag, Properties 8) Artist images in Music > Artists [Grid] (or Album Artist or Composer or Publisher [Grid]): 'Paste image' currently appears first in the context list. It should be moved below 'Lookup image...'. 9) In Collection Name > Genres > GenreName [Browser view], the overflow menu should include: Rename, Properties |
|
|
Items 5, 6, 7, 8, 9 are fixed in 2212 4) as 'Lookup image...' has been removed from the playlist context menu in the tree, I added it back as menu item to the three dots overflow menu in the playlist header info panel. As it is the context where it really belongs. The downside is that user needs to open each playlist with 'Info panel' enabled to lookup the image. In true, I don't really understand why Rusty has suggested to remove the 'Lookup image' from the context menu for playlists? Either way it is not a big deal as the playlist image lookup feature won't be used much (probably). |
|
|
1) Lowlander indicated that removal of rating is problematic since there are cases where users get new tracks and do mass edits of ratings (e.g. select 5 tracks and set 'My Rating' to ***. So it would be useful to add this function back for multi-selected tracks (and I suppose single-selected tracks). 4) The reason I suggested removing 'lookup image...' for Playlists is because the 'lookup image...' function doesn't make sense for multiple tracks except in cases where all of the tracks are from the same album. Moreover, when this function is applied to a Playlist, the search term is the playlist name--I'm not sure what usecase this would be useful for? 7)b) The original issue was resolved, but now, if the user clicks a CD node and then right-clicks on the tracks that display --> There should be an option to rip the CD tracks / do a freedb lookup like with 7a . --> Also, it displays an option to Convert the tracks which results in an error. This option can probably be removed in the case of a physical CD, though may be required for residual VCD tracks (depending on how VCD tracks are imported). |
|
|
1/7b) are fixed in 2214 4) This use-case is for looking up (or browsing) an image for the playlist only, not for the tracks!! e.g. I can create "Ludek's playlist" and add my photo as the image of the playlist ;-) |
|
|
4) Ahh... I didn't understand that--I expected that it would look up artwork for all the tracks in the playlist. I like your new implementation, though, because it makes it a little more clear that the lookup is for the aggregate image. It's slightly different approach than for Artists/Albums/Genres/etc, but it makes sense since playlists really are a bit different than all of the other cases. 10) Music > Albums > AlbumName Right-click track --> Lookup image... is missing Same issue for any tracklist in Simple view. e.g. Music > Artists > ArtistName [Browser view:Simplified list] Music > Genres > GenreName [Browser view:Simplified list] etc. |
|
|
4) I don't see how this is different approach than for Artists ? In both cases (playlists, artists) the image for the corresponding artist/playlist is added (and not for the tracks). 10) I don't think that this should be added on a track level, images are mostly assigned on the album level? i.e. user would want mostly to lookup image for whole album (not just track) so from my perspective this would just further overfill the track context menu (that already has quite too many items), don't you think? |
|
|
4) The difference is that for an Artist, Genre, Composer, etc. the user right-clicks on an image so it's clear what image is being updated. But for Playlists that appear in the tree, the user right-clicks on an _icon_ (not an image) and so it can seem to the user that the image being updated is the album art associated with all of the _tracks_ in the playlist. i.e. we could include 'Lookup image...' for Playlist images--the issue is really with the context menu for the tree icons. 10) I completely agree. I'd originally wanted the 'Lookup Image' function to only appear when right-clicking on _images_ (item 3). However, the implementation of that issue was for most tracks as well so I (probably incorrectly assumed) that it was easier to just implement the context menu more universally (in which case it should be implemented consistently for tracks). However, If we can, I agree that it would be cleaner if the 'Lookup image...' context menu would only appear on images. 11) Home > Playlists > Playlist name [Grid] : if the user right-clicks on the Album Image, Lookup Image... is missing. |
|
|
4/10) OK 11) Fixed in 2214 |
|
|
10) I'm not sure what you meant by 'OK'. Don't you think that it would be preferable to only have the 'Lookup image...' context menu when right-clicking on images? 11) Doesn't seem to be fixed in 2214. |
|
|
10) OK is agreement that it is preferable to only have the 'Lookup image...' context menu when right-clicking on images (albums, artists, genres, playlists) and not tracks. 11) it is fixed, see: https://www.dropbox.com/s/41n1956tfx28f0s/Screenshot%202019-11-21%2023.29.48.png?dl=0 You need to right-click playlist item, not a track item (as on your screenshot) EDIT: 10/11) Maybe you are suggesting that the track entities should also have the "Lookup Image" in the context menu whenever they are shown as images? If yes, then I still think that adding images on track level via context menu would be cumbersome and unnecessary pollutes the context menu for tracks. Adding images on track level is much more comfortable via Preview window (where the image is looked up automatically having the save button) |
|
|
10) OK, so you're going to remove the 'Lookup image...' context menu for tracks that aren't displayed as thumbnails? 11) Your EDIT made the misunderstanding clear. AFAIK, the Playlists view is the only one in which tracks are displayed as Thumbnails, so if we remove the 'Lookup image...' for that view it's fine (my preference as noted elsewhere is to get rid of the grid view for playlists because it's confusing what it represents). 12) for: Music>Genres|GenreName: Should there be a Lookup option (with a Generate button)? Not a big deal one way or the other, though it seems similar to the Playlists usecase. 13) It would probably make sense to remove 'Paste image' for: Home|ArtistName: Lookup image/Paste image/Properties Music>Artists|ArtistName [Grid]: Lookup image/Paste image/Properties |
|
|
3/10) OK, I finally understand what you mean -- I didn't notice that Petr added the "Lookup Image..." to context menu also for track entities in course of item 3) I agree that the "Lookup image..." ideally should be only on images -- though my suggestion was to not include it on track entities at all (adding images via context menu is cumbersome and unnecessary pollutes the context menu for tracks, adding images on track level is much more comfortable via Preview window (where the image is looked up automatically having the save button). Together with item 13) are rather low priority items IMHO and rather for Petr -- as it is his code (item 3 + the stuff around issue 0016090 -- i.e. SVN revisions 34524 and 34624 in columntracklist.js ) 11) OK, I changed it and the "Lookup image..." is not shown only for playlists in grid. i.e. Playlists in the tree and in list view does not have the "Lookup image..." in the context menu. => Fixed in 2116 As for the tracks represented as images, there are also some other views when tracks can be shown as grid, e.g. folders nodes and also videos/TVs. It s useful for music videos also and for touch mode as explained in 0015926:0055040 |
|
|
11) Tested 2218 and playlists in the tree still have 'Lookup image...' in the context menu. EDIT: it only occurs on Auto-playlists As for the other issues, there's nothing really to triage so I'll just summarize them again for Petr: 10) (Related to item 3 per Ludek's comment above): 'Lookup image...' shouldn't appear as a context menu entry for individual tracks, though I think that it makes sense to appear if the user right-clicks on a thumbnail. 12) As with Playlists thumbnails, Genre thumbnails should have a lookup option. 13) It would make sense to remove 'Paste image' for: Home|ArtistName: Lookup image/Paste image/Properties Music>Artists|ArtistName [Grid]: Lookup image/Paste image/Properties None of these are terribly severe issues, so priority can be reduced if they're not trivial to fix. |
|
|
11) as clarified offline, it still happens when "grid" is selected in the view => fixed in 2219 |
|
|
14) I fixed one regression that caused that sub-root nodes shown unrelated items. e.g. 'Devices & Services' node shown "Auto-tag" and similar unrelated context menu items/actions => Fixed in 2220 and lowering priority for the other items |
|
|
Tagging as 'resolved' so that this is verified. Ticket should be re-opened with 5.1 target after verification. |
|
|
Verified fixed issues in 2220 Setting target 5.1 Due the nature of changes revise again after fixes in 5.1 |
|
|
Request to move 'Properties' to the last item in the menu: https://www.mediamonkey.com/forum/viewtopic.php?t=103164 |
