View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0016625 | MMW 5 | Tagging / organizing (properties / auto-tools) | public | 2020-05-19 14:38 | 2020-06-29 17:29 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | reopened | ||
| Product Version | 5.0 | ||||
| Target Version | 5.0 | Fixed in Version | 5.0 | ||
| Summary | 0016625: Auto-tag: changing settings requires too many steps / status bar issues | ||||
| Description | Currently, if the user initiates an auto-tag operation and the settings aren't optimal for the tracks being looked up, the following workflow results: 1 Initiate lookup --> User realizes settings are incorrect 2 Click Options --> Lookup continues in the background 3 User makes changes to the settings, clicks ok --> Lookup continues with the old settings 4 User clicks cancel 5 User selects the tracks again and re-initiates lookup --> Lookup proceeds with the correct settings It would make more sense if clicking 'Options' halted the lookup, and that after clicking 'OK'/''Cancel' in the Options dialog: - If no changes were made --> Lookup continues - If changes were made --> Lookup restarts with the new settings This would result in a far better workflow: 1 Initiate lookup --> User realizes settings are incorrect 2 Click Options 3 User makes changes to the settings, clicks ok/cancel --> Lookup continues with the old settings OR restarts with the new settings Note: if risky, push to 5.0.1 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2256 | ||||
|
|
btw, another possible approach that we might consider for the future would be to move some settings to the Auto-tag dialog so that it can be adjusted on-the-fly depending on the type of album. e.g. [Options] [[Avoid compilations], Allow compilations]_v_ Tooltip: Determines whether groups of tracks are treated as compilation albums or as individual tracks |
|
|
I've added 'Allow compilations' checkbox (it should be enough and clear). |
|
|
Verified 2251 Lookup works as suggested in description. |
|
|
Tested 2251. There are a couple of issues: 1) Options > Metadata Lookup should no longer have the option '[ ] For groups of tracks, avoid compilations' as it's redundant. 2) If the user checks or unchecks '[ ] Allow compilations' then the auto-tag operation should be re-initiated |
|
|
Fixed |
|
|
Tested 2252 and it's mostly working except that if the user toggles the 'Allow Compilations' switch, it causes the status bar to remain open (making it look as if the lookup is stuck on the last track despite having completed). https://www.screencast.com/t/ZGOym0cwlncl |
|
|
Artworks and lyrics were loaded at the most end of the process, but i see there are almost zero notifications about what track is currently processing for artwork/lyrics. Added some notifications so user can see it wasn't stuck. |
|
|
To retest with 2255 which includes fixes to lyric lookups. |
|
|
Tested 2255 and there remain a couple of issues with the status bar: 3) The auto-tag status bar currently shows the lookups as having completed even as many more lookup tasks continue 4) If the user toggles the 'Allow compilations' option, then the status bar gets stuck on a track even though the lookup has completed https://www.screencast.com/t/BftvlPhfmj |
|
|
I retested this with logging enabled: 3b) 1:30 Status shows lookups have completed, but album art only loads afterwards. The cause of this is unclear. 4b) 2:15-4:00 Shows 'Loading artwork' getting stuck (this is different than 0016660 as that issue requires a restart of MM5 to resolve) 5) 2:15 Enabling 'Allow Compilations' sometimes causes the status bar to indicate a status regarding twice the number of looked up tracks. e.g. it shows '24/24 looked up' instead of 12/12. https://www.screencast.com/t/fYkvCwCBi8v1 debug log on ftp |
|
|
Fixed |
|
|
Verified 2258. |
