View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0016626 | MMW 5 | Tagging / organizing (properties / auto-tools) | public | 2020-05-19 20:16 | 2021-11-29 19:07 |
Reporter | lowlander | Assigned To | |||
Priority | urgent | Severity | major | Reproducibility | always |
Status | closed | Resolution | reopened | ||
Product Version | 5.0 | ||||
Target Version | 5.0.3 | Fixed in Version | 5.0 | ||
Summary | 0016626: Can't paste Artwork from browser [Regression] | ||||
Description | You can no longer paste Artwork copied from a browser. The Context Menu in the Artwork tab of Properties fails to enable Paste. D&D from browser still works. | ||||
Additional Information | http://www.mediamonkey.com/forum/viewtopic.php?f=30&t=96592 https://www.mediamonkey.com/forum/viewtopic.php?f=33&t=100481 | ||||
Tags | No tags attached. | ||||
Fixed in build | 2271 | ||||
|
This regression was caused by Petr's SVN revision 35604 (fix of 0016526) by changing line 533 in dndutils.js from var list = e.data || e.dataTransfer.items; to var list = this.getDroppedFiles(); |
|
Fixed |
|
Verified 2251 No issues anymore. Also checked and no regressions in bug 0016526 fix. |
|
Added some debug messages in case this occurs again. |
|
Verified 2262 @Lowlander I am unable to replicate in concurrent 40+ paste |
|
Reminder sent to: lowlander |
|
Verified and closing. LL please re-open if this occurs again. |
|
Unfortunately logs didn't help to find an issue ... added some more debug messages. |
|
Verified 2271 Works with copy/paste and I also tested D&D for regression, no issues. |
|
Seen again on 2274 with Jay-Z - The Blueprint. Paste is not shown as part of the context menu. Note that this is hard to reproduce as it's a state MediaMonkey gets into at some point during long use. Paste is always available after starting MediaMonkey, but can at some point stop being shown. Log in same location as others. |
|
I cannot find the logs ... can you please upload on our FTP (into MM5/bugs folder) ? |
|
Still seen on 2413. 1) Right click on image in Firefox 89 2) Use WinKey+V to verify Artwork on Clipboard 3) Right click in Properties > Artwork 4) Paste is not enabled in Context Menu Copy on a image file (gif and png tested) also doesn't enable Paste. |
|
It's hard to include as i do not know yet where the problem is. As Martin wrote "this is hard to reproduce as it's a state MediaMonkey gets into at some point during long use" and log didn't gave any clue why it stopped work. Martin, can we make a remote debug when this occur again ? |
|
I am unable to reproduce 2511 Regarding browsers I tested Edge, Chrome, Firefox, WaterFox, Vivaldi, IE11 and tried both copy/paste image and Drag and drop, also on properties, Preview, Info. Then I tried HyperSnap, Paint, XNView, Irfan View. Then also used few video players that can fetch Frame as image and copy to clipboard. Note: MM5 as running more than 18h with few Sleeps, Hibernates and Hybrid Sleeps. Only thing I can think about is that you add MSG with Dragged Object Type info in case dragged object can't be dragged on Preview or Properties -> Artwork. I gues ssame can be done when you check if content of Clipboard can be pasted into MM? But this is also wild guess and most likely too complicated to implement and with influence performance. |
|
I still was able to reproduce and capture screencast and log with 2513 which is available form the link above. However it was only the one time. After the D&D of the Artwork it always shows Paste available, even after a MediaMonkey restart. |
|
Sent updated action.js with additional debug messages ... make a new log, please. |
|
Problem seems to be that Artwork isn't actually copied, as Clipboard doesn't show it. So this doesn't seem to be a MediaMonkey bug. |