View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0016754 | MMW 5 | FileMonitor / Find Missing | public | 2020-06-26 14:29 | 2020-06-30 23:38 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 5.0 | ||||
| Target Version | 5.0 | Fixed in Version | 5.0 | ||
| Summary | 0016754: Clarify 'Failed to import' value in scan results dialog | ||||
| Description | As described at 0016738, the scan results dialog is a bit misleading because 'Failed to import <x> files' doesn't clearly distinguish why files failed to import vs 'Did not import <x> files (did not match import criteria)'. A new string '(invalid format)' could clarify this. e.g. Failed to import <x> files (invalid format) note: this wording assumes that any File Type that has been checked off to be scanned, but that fails to scan for whatever reason will be counted in this category. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2259 | ||||
|
|
Note: that if usr do not have access rights to read files they are still Fail To import even they are not Invalid format. |
|
|
I agree with Peke that the "(invalid format)" appendix isn't needed at all as reasons for failed imports are various. e.g. access rights, AV when reading tag because of non-standard value, unexpected format or tag, unexpected audio data, etc. So my understanding is that: - only the files with extension not configured to scan (and too short files) should be listed as "did not match import criteria" - others files that failed to scan for whatever reason should be listed as "failed to import" |
|
|
My test results are different from Peke's tests results in 0016738 - item 2 (I tested with MM5 though) I created test folder with: - one standard MP3 file - one zero bytes MP3 file (empty txt file with MP3 extension) - one txt file including "bla bla" renamed to MP3 extension => all three files were imported to MM5 library. Expected: only the first file should be imported and the others two should be listed as "failed to import". |
|
|
So we are changing behavior introduced long time ago in the issue 0002437. I have no idea, why it was introduced at all, for me, importing empty/corrupted files also does not make sense. |
|
|
Fixed in build 2259. Files in wrong format now fail with error "error while reading file info". |
|
|
Verified 2259 Now it looks more reasonable. Test note: along with Ludek tests in 0016754:0058672 I have also tested with WAV,FLAC, OGG to MP3 and all return as Fail to import which is correct and now when saving Results Log it is clear where and what files fail. |
