View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0016924 | MMW 5 | Tagging framework / input plugins | public | 2020-09-13 21:16 | 2022-06-17 20:24 |
Reporter | peke | Assigned To | |||
Priority | urgent | Severity | major | Reproducibility | always |
Status | closed | Resolution | reopened | ||
Product Version | 5.0 | ||||
Target Version | 5.0.4 | Fixed in Version | 5.0.4 | ||
Summary | 0016924: Extended Tags: Extended Tags are not working on multi selection edits | ||||
Description | Extended Tags are not working on multi selection edits and show as empty even individual tracks contain same extended tags It could be good to have check mark column so that user can apply them to all selected tracks if needed. | ||||
Additional Information | https://www.mediamonkey.com/forum/viewtopic.php?f=30&t=97343 | ||||
Tags | No tags attached. | ||||
Fixed in build | 2653 | ||||
|
For me it works as expected. Any special steps to reproduce? I can edit extended tags for multiple files at once without problems. |
|
As discussed offline, we should take every single tag in extended tags separately with own checkbox, now we take it at once. As it is more complex, postponed to 5.0.1. |
|
To summarize offline discussions: Current behavior (in which edits to multiple tracks don't display the contained tags and overwrite existing tags) is problematic due to the potential for unforseen data loss, and it would be preferable to disable edits of extended tags when multiple files are selected (vs allowing them to be edited as is currently the case). There was discussion of an alternative interim solution that would present a warning e.g. if some of the tracks contain extended tags, the UI indicates a warning that 'Existing extended tags will be deleted!' However, it's too late in the 5.0.3 dev cycle to translate such a string (and there don't appear to be any similar alternative strings). An alternative interim solution that could work is: - the operation proceeds when none of the tracks contains extended tags - if some of the tracks contain extended tags, the Extended tags UI is updated slightly: Extended tags [ ] --> Extended tags [ ] Apply to all selected The above is only an interim solution because unlike artwork tags (which use the 'apply to all selected' approach), extended tags are more complicated in that there can be multiple fields in addition to multiple values per field. Thus, the permanent solution described by Michal would be to: 1) load union of all extended tags from all tracks, and display values only for these, which exist with the same value (??including union of an extended value and blank/empty value??) 2) display checkboxes for all extended tags 3) deletion of extended tag would mean removing this tag from all edited tracks 4) when saving, MM would take old values from each track, remove deleted tags, update edited and checked tags, add checked tags which did not exist before. |
|
Quick 5.0.3. solution fixed in build 2622. Resolved, so you can test it. We can reopen it for 5.0.4 later. |
|
Verified on 2622 the user has to explicitly enable the option to apply to all selected files prior to being able to add a tag that would apply to all selected files. Doing this will still result in existing tag loss, but this will be solved for 5.0.4. |
|
Full solution fixed in build 2651. |
|
Verified functionality, there is small UI issue with Column width when adding new EXT tags on multiple edits. |
|
Fixed in build 2652. |
|
On Material Design for both single file and multi file selections the column widths adjust (very small change) when adding the first extended tag. 1) MediaMonkey should either: a) Default column widths should already accommodate b) When adding a tag the column width shouldn't change |
|
Fixed in build 2653. |
|
Verified on 2653 |