View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0017118 | MMW 5 | General | public | 2020-11-20 22:00 | 2021-02-17 17:05 |
| Reporter | drakinite | Assigned To | |||
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 5.0 | ||||
| Target Version | 5.0 | Fixed in Version | 5.0 | ||
| Summary | 0017118: Performance issue - Extreme layout thrashing when tooltips fade in and out | ||||
| Description | On the main window, tooltips cause a huge performance penalty when fading in and out. It causes the entire UI to grind to a halt. The biggest culprit appears to be splitter.js. It causes over two dozen layout recalculations per frame of a tooltip fadein/fadeout, causing each frame to take several hundred milliseconds. I've attached a performance recording that demonstrates the issue. Original post: Item 1 of https://www.mediamonkey.com/forum/viewtopic.php?f=30&t=96907 More info: https://developers.google.com/web/fundamentals/performance/rendering/avoid-large-complex-layouts-and-layout-thrashing?utm_source=devtools#avoid-forced-synchronous-layouts | ||||
| Additional Information | I intentionally put this as a lower priority because I think it will take a considerable amount of development time to fix, and it should probably be saved for either 5.0.1 or 5.1; not 5.0. There's probably a lot of code that would need to be changed for this optimization. | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Fixed in build | 2293 | ||||
|
|
Updated priority--Petr thinks it should be easy. |
|
|
Fixed |
|
|
Verified 2280 I do not observe any additional performance drop, but it works much faster than 2277 |
|
|
Smart thinking - Removing the tooltip fade entirely seems like it was a pretty easy fix. ;) This makes MM5 SO much nicer to use now, it's fantastic. |
|
|
Ludek and I tested offline; Found that the layout thrashing was caused by calling setVisibility instead of setVisibilityFast. Children don't need to be notified because it's positioned absolute. Lag is gone and the animation could be re-enabled after the fix. |
|
|
Yes, animation re-enabled in 2293 and performance is even better as there was still 143 ms frame even with animation disabled |
|
|
Verified 2293 |
