View Issue Details

IDProjectCategoryView StatusLast Update
0017155MMW 5Extensions frameworkpublic2021-05-26 23:00
Reporterdrakinite Assigned To 
PriorityurgentSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version5.0 
Target Version5.0.1Fixed in Version5.0.1 
Summary0017155: info.json parsing does not have a case for invalid JSON
DescriptionWhen installing an extension, if info.json is syntactically invalid JSON, it will always display the following message:

"Invalid Addon! Addon version is not in the form %d.%d.%d."

There should be a separate case for invalid JSON.
Steps To Reproduceexample of invalid info.json (comma at the end):
{
    "title": "My Extension",
    "id": "MyExtension",
    "description": "invalid",
    "version": "1.0.0",
    "author": "nobody",
    "type": "skin",
}
TagsNo tags attached.
Fixed in build2408

Activities

rusty

2021-05-24 19:02

administrator   ~0063423

Jordan, are you looking for a message to help addon authors? e.g.

Invalid addon! (.json error)

Note: Invalid addon! is an existing string so the above could be added without any new translation strings (i.e. since '.json error' is targetted at developers, it doesn't need to be translated).

drakinite

2021-05-24 19:07

developer   ~0063424

I think that's perfect - though preferably, "Invalid addon! (JSON error)", since JSON is an acronym. Still can be done without translations.

michal

2021-05-25 12:16

developer   ~0063457

Fixed in build 2408.

drakinite

2021-05-26 22:59

developer   ~0063519

Last edited: 2021-05-26 23:00

Verified 2408; no regressions found in installing addons. Closing