View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0017238 | MMW 5 | Playback | public | 2020-12-16 22:14 | 2020-12-21 17:20 |
| Reporter | drakinite | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Product Version | 5.0 | ||||
| Summary | 0017238: Regression - Window reload now stops music playback | ||||
| Description | Previous to build 2286, when window.doReload() is called, music playback continues in the background while the window reloads, I believe this is an important feature to keep. In both debug and regular builds of 2286, however, music playback stops during the reload process. | ||||
| Steps To Reproduce | Easiest with refreshSkinShortcut: - start music playback - click le button | ||||
| Tags | No tags attached. | ||||
| Fixed in build | |||||
|
|
Yes, this was intended change technically described in ~60787 The reason is that currently most of the MM processing is somehow dependent on JS and because all JS/HTML/CSS needs to be reloaded on skin change (or addon install/unistall) then it is safer to always restart MM as whole after such a change. But maybe for the refreshSkinShortcut addon (I guess it is mainly for purpose of skin developing?) we could leave the old "soft reload" functionality ? On the other hand for the MM skin developers it is probably faster to run a batch file that just kills and restarts MM. |
|
|
Okay, cool. Big technical issue is more important than minor user convenience. :P - Saw your edit: That would be nice developers. If it's not too difficult to add a new "soft" reload function, e.g. window.doSoftReload() ? I imagine plenty of skin developers would be working on and testing their skin while listening to music on MM itself. |
|
|
BTW: There is already softReload parameter in the window.doReload that re-loads just the LESS/CSS. So maybe the refreshSkinShortcut addon could just reload the less/css which is faster and useful for skin developers ? EDIT: i.e. change just to window.doReload(false, true); where the second parametr is the soft reload of less/css only |
|
|
Added the change to SVN (revision 37092) |
|
|
Oh, that's very nice! I'll update refreshSkinShortcut to have an option between full reload and just LESS reload, because some developers (i.e. regular addon devs) will definitely want to reload the JS and HTML. |
|
|
Getting away from the original topic here, but refreshSkinShortcut is updated with those additions. |
|
|
Verified 2288 Unable to reproduce. |
