View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0017327 | MMW 5 | Main Panel | public | 2021-01-03 21:09 | 2021-01-31 14:29 |
| Reporter | peke | Assigned To | |||
| Priority | urgent | Severity | feature | Reproducibility | unable to reproduce |
| Status | closed | Resolution | reopened | ||
| Target Version | 5.0 | Fixed in Version | 5.0 | ||
| Summary | 0017327: Auto Tag: Auto Tag Dialog behavior change | ||||
| Description | Instead of Making Auto-Tag a modal window we should consider: a) to open it as a Tab b) gray out Main MM screen so that user can't go back to Main MM screen c) Open as main track browser view so that if user uses Tabbed browsing it can switch to other tabs but not continue on tab that initiated Auto-Tag till it finishes or cancels d) Make it top most dialog like in MM4 In MM4 Auto Tag dialog is always top most dialog and there is no way to open two searches. Personally I would prefer option c) but I guess option d) is fastest solution. | ||||
| Additional Information | User supplied short video file where switching from to Auto-Tag window can result in fast switching and MM screen blinking https://www.mediamonkey.com/forum/viewtopic.php?p=476470#p476470 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2294 | ||||
|
|
Assigning to Petr to try to fix the issue. As for the proposed workflow changes, moving a discussion with devs to Skype, resolution to be written here then. |
|
|
Changed auto-tag dialog to modal for 5.0. |
|
|
Reopen 1. Rarely when Double clicking on found Album art hides that dialog behind and can't be refocused (Happened once or twice) 2. Canceling Album Art lookup dialog looses focus from main MM window. Key to test is to have any other window in background of MM. I tested with windows explorer |
|
|
If the bug that we're trying to solve is flashing in the UI, do we really have to solve it by making auto-tag modal ? This is the opposite of what was requested at 0014877, and the reason for the request for a non-modal dialog is still valid--it takes a long time and locks the user out of the UI. |
|
|
Per IM discussion, Petr will try to fix this while keeping the dialog non-modal. We probably should reopen this issue then, or create a new one, in order to handle this in a unified way for MM 5.1. One idea was to open such dialogs as ordinary dialogs, probably even modal ones, but add them a 'Pin' button, that'd (re-)open them as a new Tab, to avoid blocking MM UI. (I'd rather avoid direct opening as a new tab, since this might be somewhat unexpected) |
|
|
@jiri That is exactly what I suggested in c) eg. Select tracks -> Auto Tag -> Track list is replaced with Auto tag (same tab) and user can open new tab for regular browsing and tab with auto Tag will not be used till user interact wit it if he closes it It is assumed as cancel. Same behavior is globally accepted when filling the forms and questionnaire on internet pages or query and we already use that for advanced search which replaces current tab. It should not be hard to implement. We even used same approach in MM4 for burning and there was no complains. |
|
|
Flickering fixed |
|
|
On 2293, if you have Auto-Tag behind the main window it is brought in front of the main window when you open a new window like Properties, Options, Auto-Organize Files. Is this intentional? There was no flickering though. It just was brought in front of the main window once. Can be closed if this is by design. |
|
|
Confirming that Flickering is fixed in 2293, But that is side affect of bug proposal do not fix confusion when doing Auto-Tag eg. Auto-tag is modal -> Lookup image is modal of Modal window. As I suggested in c) we should try to avoid multiple modals which by design risky and can easily introduce bugs (not that I am implying they do) and are harder to maintain and debug along not so user friendly. |
|
|
@Jiri If you do not think that we should further pursue it please close as reason why this dialog function is reviewed and change proposed should be fixed. |
|
|
I think that this is quite ok, not a big deal for me. A bit more disturbing is the fact that the main window sometimes gets hidden. Example 1: 1a. Open MM folder in Explorer. 1b. Click MM.exe => MM opens, but _behind_ the Explorer. Example 2: 2a. Have some large window open behing MM (e.g. Explorer) 2b. In MM, open Auto-tag. 2c. Open Options. 2d. Close Options. 2e. Close Auto-tag => Main MM window gets hidden behind Explorer. Should the fix be risky, I'd push it to MM 5.0.1, as it isn't any serious issue, but definitely something to review. |
|
|
Fixed |
|
|
2294 didn't show example 1 or 2. |
