|
Ludek
2021-02-02 16:57
developer
~0061691
Last edited: 2021-02-02 16:59
|
Originally the skin change did not interrupt playback, but later we decided to restart MM as whole because of issues like ~60787 (details in private Mantis note 60787) and further technical issues.
So with this in mind we may want to change the text of the warning,
assigned to Rusty for wording suggestion (post 5.0)
Also mentioned by Barry here: https://www.mediamonkey.com/forum/viewtopic.php?f=30&t=98335
|
|
|
|
Assuming the functionality remains as is:
1) Title can be 'Restart' (this is an existing string)
2) With the 'Restart' title above, I don't think many users would be surprised if this interrupted playback (I wouldn't mind changing the string to be more explicit, but I believe that we already changed it to be less explicit because it ?is?/was used in cases where playback wasn't interrupted).
Assigning to Ludek to implement 1) and for Triage to determine if we would want to consider a partial reload in the future. |
|
|
|
1) is fixed in 2408
As for the partial reload -- this would be fine, but hard to maintain and hard to ensure that this partial reload won't break anything -- as currently more and more code is processed in the frontend (JS/HTML5/CSS) which needs to be reloaded as whole (as skin/addon can modify it in any way). So majority of tasks (that somehow uses JS code) including e.g. media sync would need to be terminated anyway.
And because the reload is needed just from time to time (e.g. after skin change or addon install) then I don't think it is a huge issue that worth the risks and amount of work/testing involved. |
|
|
|
1) Verified on 2408
2) Not fixed |
|
