View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0017590 | MMW 5 | Extensions framework | public | 2021-02-21 03:25 | 2021-04-22 20:06 |
Reporter | drakinite | Assigned To | |||
Priority | high | Severity | feature | Reproducibility | N/A |
Status | resolved | Resolution | fixed | ||
Product Version | 5.0 | ||||
Target Version | 5.0 | Fixed in Version | 5.0 | ||
Summary | 0017590: Allow addons to use custom search engines | ||||
Description | I think it would be relatively simple (hopefully) to retrofit the app.utils.web.openSearchWeb method to allow addons to add support for whatever search engine they want. The method could take a string as its first argument, instead of an integer, to determine the URL that the method opens. It can then replace "%s" or "%S" with the search query that it determines from the second and third parameters. For example: https://open.spotify.com/search/%s -> app.utils.web.openSearchWeb('https://open.spotify.com/search/%s', type, item); https://napster.com/search?query=%s -> app.utils.web.openSearchWeb('https://napster.com/search?query=%s', type, item); https://www.jamendo.com/search?q=%s -> app.utils.web.openSearchWeb('https://www.jamendo.com/search?q=%s', type, item); Vivaldi does that for its custom search engines, and it works great. (see attached) Assigning to Jiri for evaluation on the idea. | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Fixed in build | |||||
|
Don't you wanna try to prepare a small test/sample implementation to evaluate? Maybe as an addon? |
|
I can't, unfortunately, because the openSearchWeb method appears to be native code. |
|
See my code re 0017589 -- I did not need to use any native code to add Spotify. (openSearchWeb was rather a survival from MM4) |
|
Re-opened for tweaking per IM discussion with Drakinite |
|
Committed new generic function to SVN; Will wait for the next build to be released before uploading new version of showLinks to the addons website. |
|
New version of Show Links is up on the addons site. |