View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0017693 | MMW 5 | Tagging / organizing (properties / auto-tools) | public | 2021-03-24 21:51 | 2026-09-29 19:07 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | feature | Reproducibility | always |
| Status | feedback | Resolution | reopened | ||
| Product Version | 5.0.1 | ||||
| Target Version | 2027.0 | Fixed in Version | 2027.0 | ||
| Summary | 0017693: Mass edits: improved handling of situations in which metadata within a field doesn't match | ||||
| Description | When performing a mass-edits and each track has different values for a given field, it would be better if: 1) The user was notified that attributes don't match by highlighting the fields in some manner. This could be achieved in the same manner as in the auto-tag dialog. There are 3 cases that would need to be handled: a) the field is empty for some of the tracks b) the attributes are identical except for case c) there are conflicting attributes (Currently there's an implicit notification by virtue of an empty field) The solution in all 3 cases, would be to Display the most common attribute for the field other than "" (in Orange to signify that a change will result) followed by an orange exclamation point (signifying the conflict). 2) The user was able to preferentially choose from among the values that have been entered. So when clicking a combio-box, rather than displaying the full alphabetic list, MM should display the attributes associated with the field (from most to least common), followed by a separator, and then the rest of the list. | ||||
| Additional Information | Raised at https://www.mediamonkey.com/forum/viewtopic.php?f=30&t=98686 Case discrepancy issue raised at 0017691 issue 1 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 3524 | ||||
| parent of | 0022317 | resolved | rusty | CUE tracks: Editing Properties of All CUE tracks incorrectly suggest changes (regression) |
| related to | 0021615 | closed | Ludek | BPM not showing in Properties when 2 files selected |
| related to | 0022185 | closed | michal | Opening Properties on multiple files causes high memory usage/slow to use |
| related to | 0022372 | resolved | petr | Metadata Lookup: Crash on Editing Fields for Auto Tag |
|
|
Fixed in build 3402. |
|
|
This seems to work on 3514. 1) I think the drop down indicator should be orange as well (eg. see Title, it's grey like the standard drop-down indicator like Album). 2) The Exclamation mark should show a tooltip indicating that multiple values are associated with the selected files for this field. 3) Genre, Track# and Disc# don't have exclamation mark on multiple values. 4) It would be nice to have values used in selected files in orange too in the drop-down, to better clarify to user that these are values found in the selected files (see Genre screenshot). |
|
|
Fixed in build 3515. |
|
|
Verified all 4 items on 3516. 5. The new Subtitle and Language fields don't show multi-value. 6. Rating has no multi-value indication. a. If there is a file with Rating value and and a file without, the Rating of the file with value is shown, no indication the other file is lacking Rating b. If 2 files with different Rating are selected, no Rating is shown, no indication of a multi-value 7. There is no indication that there are multiple values in Comment, it's shown blank. 8. No indication of multi-value for Start time, Stop time, Play counter, Skip counter, Track volume and Album volume. Note that users may select 2 copies of the same file so there is a use to being able to see multi-value. |
|
|
Fixed in build 3517. Because it would be risky and more computationally and memory demanding, the comment field displays the first value, not the most common one. It also does not display a dropdown with a selection of all possible values, as comments can be very long. |
|
|
Verified on 3517 |
|
|
|
|
|
To summarize, the problem is related to the fact that MM now highlights fields that have differing values using color and an '!', and preselects values that are most common resulting in: - some users interpret this as a warning/recommendation by MM to fix things using the suggested values (rather than a warning that the values across multiple files are inconsistent and should only be changed if the inconsistency needs to be corrected). Consequently they check the field with the suggestion, causing metadata to be lost. - some users interpret this as a warning about the suggested metadata, and solve it by deleting it. In so doing, the red text and '!' warning go away and the field to become checked, and they might think they've solved the problem even though results in the metadata being deleted from all tracks. This probably isn't a severe issue since MM still warns the user when a large number of files are to be edited, however, it should still be improved, since in the above cases users realize that they're editing many tracks--they just make incorrect edits if they're not thinking about what they're doing because the UI steers them towards those edits. This can be solved with a few tweaks discussed offline: 1. When a given field has multiple different values, continue to show the '!', but without displaying the 'recommended values'. Instead force the user (as in the past) to either choose from one of the recommended values in the combobox (instead of pre-filling the field) or manually edit the field - as always, automatically check the checkbox after the user has manually edited/deleted the field or only after selecting a value from the combobox The tweaks are minor, but force the user to actually go through editing steps as in the past (while still providing feedback regarding inconsistent field values). 2. Tweak the tooltip: Selected files contain multiple values for this field --> Selected files contain different values for this field |
|
|
Fixed in build 3522. Now we not do not prefill most frequent value, as before changes in this issue. |
|
|
I find the empty multi-values fields, just relying on the ! to be unclear in indicating a multi-value for a field. I think using << Multi Value >> (also in orange and in cusrive) in the field, that on click opens the drop-down (same if checkbox is clicked) and clears from field (and field only is saved if user actually types/selects a value) is the best compromise. ie. this value can't be saved/edited to the fields unless user manually types this. A similar thing is already done for Location and file name. |
|
|
Path and Location should get the same styling when multiple files are selected. |
|
|
The problem is that some fields are too small to include much text. How about: 1) Change the orange ! to ⓘ, but limit it to that so that it's small enough for all fields 2) Make the tooltip more explicit Selected files contain different values for this field. --> Selected files contain multiple different values. Edits will replace the value for all files. 3) If the user edits a field with a ⓘ, change the ⓘ to a ⚠ 4) For multi-value fields, clicking it should work similarly to how dropdowns in a browser work. i.e. - focus should remain in the textbox for the user to type, but the dropdown should open showing all of the values (as opposed to currently, the user must click the corner of the textbox to display existing values) 5) Currently, if the user starts typing and then clicks the first pre-existing orange value, it doesn't fill in the field! It should. 6) Sometimes, if the user clicks the dropdown (rather than typing to elicit suggestions) and then clicks the pre-existing orange value, MM crashes: crashlog 26D30000 |
|
|
"The problem is that some fields are too small" That is a valid point. How about also making the labels of multi-value fields orange? |
|
|
5) fixed in build 3524. 6) crash fixed in build 3524. It was not crash from Properties dialog, but from AutoTag dialog, which was most probably opened just before. |
|
|
Fixed in build 3524. Used last suggestions and also placeholder, as it seems to work nicely (It doesn't matter that it doesn't fit for few fields, the tooltip explains what it is in detail anyway). |
|
|
There are issues with the current implementation: 7. Multi-values are presented as single values. It's not clear what the multi-value value is as individual values are presented. Case, Involved People will always be the same values for all files associated with an Album Artist (in my Library). In Screenshots the single file shows the 3 values associated with Involved People. The new method presents 3 values in the drop-down (the old method showed all 3 loaded in the field). ie. MediaMonkey is not clearly communicating actual field value as it only shows individual values. 8. It often fails to select the used values from the drop-down, once a value has been chosen. 9. When selecting values from drop-down, they're added instead of replacing an existing value. ie. only after adding ; should drop-down append a new value. This can be inconsistent. |
|
|
7. Yeah, for this particular usecase it probably makes sense to list the existing _set_ of values (Name1;Name2;Name3) rather than listing them individually. |