View Issue Details

IDProjectCategoryView StatusLast Update
0017855MMW 5Now Playingpublic2023-07-15 16:41
Reporterrusty Assigned To 
PriorityurgentSeverityminorReproducibilityalways
Status closedResolutionreopened 
Product Version5.0 
Target Version5.0.3Fixed in Version5.0.3 
Summary0017855: Browser view: Sort order sometimes wrong / Play order sometimes doesn't match display order
DescriptionIf the user right clicks on a node (e.g. GenreName, ArtistName) that opens in a browser view and uses a Play command (e.g. Play Now, Play Next,...) then the tracks are added to Now Playing in an order that's unclear and that doesn't match the order of tracks that is generate when the user clicks the Play Now button in the view.

i.e. right-clicking > Play Now on the node should yield the same play order as when the user clicks the Play Now button that appears in the info panel (which seems to be the order of tracks in the tracklist).

Note: the issue was originally raised in 0016472 -- I still find the current behavior unexpected.
TagsNo tags attached.
Fixed in build2625

Relationships

related to 0016472 closedLudek Play Now for a node can trigger Playback of tracks different than those that are displayed 
related to 0018441 closedLudek Contextual Search doesn't work consistently for tracks section in Browser view 
related to 0018823 closedmichal Vinyl Albums play out of order 
related to 0020145 closedLudek Play Now/Play shuffled commands don't work for an attribute-node that represents a single track (regression) 

Activities

rusty

2021-10-20 21:26

administrator   ~0065364

At 16472, Ludek wrote: I think that Genre [Browser] view is quite specific (having Artists, Albums, Top Tracks) and one would hardly expect that playing whole genre node would go according to the "Top Tracks" section.
--
I agree--users always expect that _all_ of the tracks represented by the view should play. However, they should play in the order that they are presented i.e.:
- if the tracklist is collapsed into 'Top tracks' then they should play in order of 'popularity' (i.e. the same sort order as is used to generate 'Top Tracks') so that it matches the order of the subset of tracks that are displayed.
- if the tracklist is expanded ('All x tracks') then it should play in the order displayed

Note that the current situation is actually even more confusing than originally described as play order varies in several different ways:
1) If the tracklist is expanded:
a) Right clicking the Play node plays tracks in some order different than the displayed order. Unclear how this order is generated.
b) Clicking the 'Play' button at the top of the view plays tracks in the displayed order.

2) If the tracklist is collapsed (Top Tracks):
a) Right clicking the Play node plays tracks in some order different than the displayed order (same order as 1a).
b) Clicking the 'Play button at the top of the view plays tracks in some order different than the displayed order (different than both 1a, 1b, 2a).

It's really confusing. Users generally expect the tracks to play in the order displayed.

michal

2022-04-29 17:27

developer   ~0067882

Fixed in build 2619.

rusty

2022-04-29 21:57

administrator   ~0067886

Tested 2619 and play order still doesn't match display order.

1) When the tracklist is expanded (displaying 'All Tracks'), the play order (whether the user right-clicks on the GenreName OR clicks the 'Play' button in the Info Panel) is always the Top Tracks (user expects All Tracks to play if that's what's displayed).

note: Case 2) works correctly. i.e. when the tracklist is collapsed (displaying 'Top Tracks'), the play order matches the display order.

michal

2022-04-30 07:35

developer   ~0067892

Last edited: 2022-04-30 07:36

I cannot reproduce. Please backup your persistent.json, delete persistent.json.bck and persistent.json from Portable folder, and test again. Does it work then? If so, please send me your backuped old persistent.json, thanks. Or maybe there is some specific order of actions needed to reproduce.

rusty

2022-05-02 16:28

administrator   ~0067928

For some reason the issue 1) that I reported as not being fixed is no longer reproducible with the Music > Genres > GenreName [Browser] view, but it still occurs consistently with the Music > Artists > ArtistName [Browser]. It occurs even with a fresh json file.

I've also noticed the following similar issues in 2619:

3) Using the Info Panel Play button for all tracks doesn't always initiate playback correctly:
1 Navigate to Music > Genres > Alternative [Browser|Top Tracks]
2 Click Info Panel Play button
--> Top Tracks play as expected beginning with Track 1(ilomilo)
3 Expand Top Tracks to display 'All Tracks'
4 Click Info Panel Play button
--> Now Playing loads 'All tracks' but initiates playback at Track 0000954 rather than Track 1 (Track 0000954 is ilomilo)

4) Right-clicking 'Play Now' on a GenreName node from the Grid View plays tracks out of order:
1 Switch to Music > Genres [Grid view]
2 Right-click on Alternative, and 'Play Now'
--> All 989 Tracks start playing
3 Click 'Alternative' to see the view
--> It becomes apparent that the tracks are playing in an order that doesn't match that of the current (Browser) view or of any other view (List, List (by Album)). How is the play order generated?

michal

2022-05-03 13:30

developer   ~0067943

Fixed in build 2620. In 4) we use default sort order Date - Album - Track # - Title now, as view cannot know sort order in not opened view.

rusty

2022-05-04 19:53

administrator   ~0067981

Tested 2620:
1) This issue is partially fixed (it now seems to behave inconsistently--same as issue 3) :

3) Using the Info Panel Play button for all tracks causes 'Top Tracks' to play:
1 Navigate to Music > Genres > Alternative [Browser|Top Tracks]
2 Click Info Panel Play button
--> All 989 tracks play, in the order of Top Tracks (i.e. starting with ilomilo). Although this isn't what we'd discussed, one could argue that this is desired behavior, so let's leave it as is.
3 Expand Top Tracks to display 'All Tracks'
4 Click Info Panel Play button
--> Now Playing loads 'All tracks' but initiates playback at Track 0000954 rather than Track 1 (Track 0000954 is ilomilo)

Note that the above behavior doesn't occur consistently. e.g.:
- sometimes steps 1-4 work correctly, and then repeating them a second time triggers the bug
- if the user presses STOP between stops 2 and 3 then Track 954 plays but it is 'White sky'.

rusty

2022-05-06 16:46

administrator   ~0068027

Based on Michal's suggestion, I retested with 2621 with Genres (or Artists) that have only a few tracks (106) vs genres with a lot of tracks (300-1000), and the issue is more likely to occur when there are more tracks in the Genre/Artist.

michal

2022-05-06 20:26

developer   ~0068031

Fixed in build 2622. I already cannot reproduce.

lowlander

2022-05-06 22:27

developer   ~0068039

Verified on 2622.

rusty

2022-05-06 22:36

administrator   ~0068041

Tested 2262 and the problem seems to be fixed in the Genres node, but not in Artists nodes.

michal

2022-05-09 10:49

developer   ~0068061

Fixed in build 2623.

rusty

2022-05-10 02:26

administrator   ~0068074

Tested 2623 and the issue remains. I think that it might not actually be node-dependent, but rather that it's triggered by switching between nodes. Also note that there are 2 distinct bugs:
A) When first navigating to a node, the sort order for 'All Tracks' is different than after the user changes to Top Tracks and then back to All Tracks (but tracks play in the order that is displayed).
B) Navigating between Genres --> Artists --> Genres nodes causes
i) Tracks to play in an order other than the displayed order
ii) Sorting (in Top Tracks/All Tracks) to completely break

1 Navigate to Music > Genres > Alternative [Browser|All Tracks]
--> Display order is incorrect (or at least different than subsequently). See at 00:05s how sort order starts with 'numb' (Issue A)!!
2 Click Info Panel Play button
--> All 989 tracks play, in the order of All Tracks (i.e. starting with 'numb').
3 Toggle 'All Tracks' --> 'Top Tracks'
4 Click Info Panel Play button
--> Now Playing loads 'Top Tracks' in the correct order
5 Toggle 'Top Tracks' --> 'All Tracks'
--> Sort order now begins with 'Cornflake Girl' i.e. different than at step 1 (I believe this is the correct order).

6 Navigate to Music > Artists > Beatles [Browser|Top Tracks]
--> list starts with 'Please Please me'--which is likely incorrect (conflicts with all subsequent 'Top Tracks' sort orders)!
7 Click Info Panel Play button
--> Now Playing loads incorrect order (starting with 'All my loving', though the bug is likely that the sort order at Step 6 is incorrect) (Issue Bi)!
8 Toggle 'Top Tracks' --> 'All Tracks'
9 Click Info Panel Play button
--> Now Playing loads tracks correctly (starting with 'From me to you')
10 Toggle 'All Tracks' --> 'Top Tracks'
--> list starts with 'All My Loving' this time! In contrast to step 6 in which it started with 'Please Please Me'.
11 Click Info Panel Play button
--> Now Playing loads correct order (starting with 'All my loving').

12 Navigate back to Music > Genres > Alternative [Browser|All Tracks]
--> Display order is incorrect (different from previous and subsequent sort orders). Sort now starts with 'Wonderwall' !
2 Click Info Panel Play button
--> Tracks play out of order ( in 'Top Tracks' order beginning with ilomilo instead of in 'All Tracks' order) (issue Bi)!
3 Toggle 'Top Tracks' --> 'All Tracks'
--> Tracks adjust to correct order
4 Toggle 'All Tracks' --> 'Top Tracks'
--> Tracks stop adjusting to the correct order (Issue Bii)!

I'll provide video/logs shortly.

michal

2022-05-11 11:05

developer   ~0068085

Fixed in build 2624. There was problem with sorting by empty dates or bitrates. And I found one related timing issue also affecting some specific sorting fairly randomly.

rusty

2022-05-11 17:08

administrator   ~0068099

Tested 2624 and all 3 issues remain. i.e.
A) When first navigating to a node, the sort order for 'All Tracks' is different than after the user changes to Top Tracks and then back to All Tracks (but tracks play in the order that is displayed).
B) Navigating between Genres --> Artists --> Genres nodes causes
i) Tracks to play in an order other than the displayed order
ii) Sorting (in Top Tracks/All Tracks) to completely break

https://www.screencast.com/t/okTdrxk4wqEK

rusty

2022-05-12 16:44

administrator   ~0068119

Michal indicated that the root of this issue is related to how sorts are performed in Browser views when contextual searches are performed / removed. e.g. contextual search for 'Beat' in the Music > Beatles [Browser] filters tracks by empty string, so when Top tracks are displayed, they are immediately replaced by all tracks. But all tracks do not have "top tracks order" filled, so the order of tracks if quite random, dependent on IDs in database.

Per discussion with Michal, in such views, either of the following should happen when the user initiates a contextual search:
a) Leave it showing 'Top Tracks' and only display the top tracks that match the filter. And if the user toggles to 'All tracks' then display all tracks that match the filter.
b) Automatically toggle to 'All tracks' and display all tracks that match the filter (this might be preferred, as otherwise users will have to perform 2 steps each time they do a contextual search OR they won't understand why certain matches aren't appearing).

michal

2022-05-13 12:12

developer   ~0068131

Fixed in build 2625.

rusty

2022-05-13 19:29

administrator   ~0068134

Verified 2625. whoo hoo!