View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0017904 | MMW 5 | Conversion/Leveling | public | 2021-05-21 22:18 | 2022-05-02 15:23 |
| Reporter | lowlander | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 5.0.1 | ||||
| Target Version | 5.0.3 | Fixed in Version | 5.0.3 | ||
| Summary | 0017904: Multiple dialogs when MM can't level files | ||||
| Description | When the user: 1 initiates volume leveling for some track(s) that can't be leveled (generally because they're not MP3 files) --> "Leveling Track volume irreversibly modifies the track. Are you sure you want to level volume of the selected tracks? [Yes] [No]" This is annoying in cases where all of the tracks cannot be leveled (since the error is irrelevant) 2 Press [Yes] -->Timed Error dialog appears for 8 seconds for the track that can't be leveled: There was a problem leveling volume for the following tracks: ....list of tracks.... [Continue] [Cancel] This dialog appears again subsequently for _each_ track that can't be leveled! This only makes sense for cases when the user wants to stop the volume leveling (and even in that case it's not optimal, because the error should have appeared just once prior to leveling beginning), but not if they want it to continue for the remaining tracks. 3 Press [Cancel] (or [Continue] if only a single track is being leveled) --> Summary dialog appears that's near identical to the previous one: There was a problem leveling volume for the following tracks: Retry [ ] Track 1 [ ] Track 2 .... [OK] The summary dialog is fine, if not for the fact that the user was already presented with this information in the timed dialogs! To fix the above, MM should: - present only a single error message upfront - not present a second error message if the user has cancelled the operation prior to initiating leveling of any tracks Possible approach: A) Allows the user to decide upfront whether to proceed with volume leveling even if some of the tracks can't be leveled. In other words, i) if the user attempts to level tracks and none of them are MP3 files, --> Track volume may be leveled only for MP3 files. [OK] ii) if the user attempts to level tracks and only some of them are MP3 files, --> Track volume may be leveled only for MP3 files. Leveling Track volume irreversibly modifies the track. Are you sure you want to level volume of the selected tracks? [Yes] [No] iii) if the user attempts to level tracks and all are MP3 files --> Leveling Track volume irreversibly modifies the track. Are you sure you want to level volume of the selected tracks? [Yes] [No] B) If the user has clicked [Yes] in case A)ii) or Aiii) and the operation is proceeding and errors are encountered, the timed error dialogs should be replaced with non-blocking Toast messages each time an error occurs (as long as the toast stays in one place so that the user can press [Cancel]). e.g. Using existing strings: Error: Volume leveling (<FileName>). <Problem description>. . . . . . . . . . . . . . . . . . . . [Cancel] Note: - there's no need for a 'Continue' button with a timed dialog or a toast since that's the default behavior. - At the end of the operation, the summary dialog should appear if there were errors. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2618 | ||||
|
|
Please triage. |
|
|
Fixed in 5.0.3.2617 i.e. only single "Summary" error dialog is shown now at the end (no longer the "timed" dialog with Continue button). As for the warning ""Leveling Track volume irreversibly modifies the track. Are you sure you want to level volume of the selected tracks? [Yes] [No]"" I think the warning should be always shown as MM5 can't predict that all selected files will finally fail to level -- and the operation to check this beforehand would have a performance penalty and could take too long for thousands of files => resulting in miss of the confirmation dialog e.g. when user initiated the operation and left the PC |
|
|
Tested 2617. Re. Case Ai), now when the user selects 500 FLAC tracks, the user is prompted "Leveling Track volume irreversibly modifies the track. Are you sure you want to level volume of the selected tracks? [Yes] [No]", and then an error appears showing the 500 FLAC tracks. It's a little clunky (why bother going ahead with the operation on tracks that don't support it), but users will quickly learn that certain files aren't supported so this usecase is unlikely to occur often, so we can probably leave it as is. Re. Case Aii), now when the user elects to level a batch of files only some of which are eligible for leveling, the user isn't presented with the warning that only MP3 files can be leveled. i.e. Those that are eligible will be leveled and those that aren't won't, resulting in a music collection in which tracks are at different volume levels. I suspect that many users would prefer to avoid this and would have halted the operation had they been presented with an error message in advance that only MP3 files would be leveled. But still, a minor issue. Re. Case B), iirc, the timed dialog (and proposed alternative of a toast) was implemented so that users have a means of halting a leveling operation that endlessly consumes CPU and takes over MM UI preventing the user from exiting the process (e.g. inaccessible networked tracks, corrupted tracks, etc.). When I tested this out (removal of a network connection partway through the leveling operation, MM failed to report any errors. Shouldn't errors have been reported when they occurred, plus a summary? |
|
|
Re. Case Aii) This has been always the case and can be avoided only by modifying the text of the warning dialog "Leveling Track volume irreversibly modifies the track...." --> as starting the operation can always result in some tracks being leveled and some not (e.g. if the first track is MP3 and the last isn't). Case B) fixed in 5.0.3.2618 |
|
|
Tested 2618 and it seems to work. I'm only re-opening for feedback: Re. Case Aii) What I was trying to say is that prior to starting the operation (i.e. just before the warning about leveling permanently modifying tracks) MM can check what types of files are in the queue. I suppose you're saying that such a check would be too slow/cpu-intensive? |
|
|
Re. Case Aii) Yes, the check would needlessly consume time as the result would be the same, i.e. showing a warning dialog with modified text. i.e. instead of current warning "Leveling Track volume irreversibly modifies the tracks..." we would need to show something like: "Leveling Track volume irreversibly modifies the tracks. Note that some tracks may/will fail to level as leveling is supported only to some file type formats." i.e. the checking before the operation would just result in slightly different text (tracks will fail to level versus tracks may fail to level). Anyhow both require wording changes -- so this should be tracked as separated post 5.0.3 issue (to not broke 5.0.3 localization/translation). |
|
|
OK. Tagging as resolved and not opening a new issue as it's a minor item. |
