0018184: Playback: Save bookmarking info even for tracks that do not have bookmarking enabled - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0018184	MMW 5	Playback	public	2021-08-01 21:01	2024-02-29 00:06

Reporter	peke	Assigned To
Priority	high	Severity	tweak	Reproducibility	N/A
Status	feedback	Resolution	open
Product Version	5.0
Target Version	5.2

Summary	0018184: Playback: Save bookmarking info even for tracks that do not have bookmarking enabled
Description	Maybe we should consider enabling of save bookmarking position info even for tracks that do not have bookmarking enabled and having that info in Library will be ignored anyway. It should not posses any treat for MM performance, but for example it could be easy to: a) start MM with playback resume option which will continue playback of playing track at position it stopped b) user enables Bookmarking for the type, they would already have the value ready c) User accidentally had bookmarking disabled for AudioBooks/Podcasts/Videos and re enable it d) Tracks that were incorrectly scanned into type that do not have bookmarking enable and user makes correction of type eg. Music -> AudioBook
Tags	No tags attached.

Fixed in build

peke 2021-10-09 23:10 developer ~0065085	Not sure what feedback is needed, but a) BUG: MM do not continue track playback on restart eg. Play track -> Move seekbar to 3min in track -> Close MM -> Start MM -> Press Play -> Track starts from beginning (expected to continue playing at same place) b) NEW FEATURE: If you for example decide to Enable bookmarking for Music, then all tracks that you previously played would have Bookmark Information and when you play them they would continue playback where you left) c) BUG: there is a bug that when you accidentally disable Bookmarking for AudioBooks/Podcasts Type and confirm change you are loosing Bookmark position. d) NEW FEATURE: Download some Audio Book or Podcast that have incorrect Metadata (or user simply delete AudioBook in Genre and rescan folder) and scan it in library. It will be added to Music Collection -> Play it for some time -> Stop Playback -> Correct Track properties Type an dchange it From Music to Audio Book -> Play track again (it starts from beginning) b) and d) are New features because MM would save bookmark information in library for every played file no matter is bookmarking is enabled or not only player will ignore it on playback (there is no regressions in any way not it will influence current MM behavior, but will help users that manage and correct tags/types or enable bookmarking for type) a) and c) are bugs that can commonly made by users and then they blame MM for not Remembering Bookmark. In such cases saving Bookmark for all files will have evade such cases. Again no risk, over head or possible regression because, current playback rules will be working as is)

rusty 2022-04-21 22:33 administrator ~0067668	I really have no idea what usecase you're describing here. It sounds like the same as 0018182 but I don't really understand...

peke 2022-04-21 23:51 developer ~0067670 Last edited: 2022-04-22 00:03	bug 0018182 only refers to player playback behavior for tracks thzt have bookmarking enabled eg. like you pointed in 0018182:0067631 where if track is >10 minutes playback will start from bookmark position if not then it wil start from start. This bug covers functionality that for every played track bookmark value will be filled no matter if track type have bookmark enabled or not, where currently only if track type have bookmarking enable it will save bookmark info in Library. Based on my test adding this do not make any performance issues. eg. For any track type (eg. Music, Audiobooks, Video, Tv Series, ...) if bookmarking is not enabled then Track Properties -> Details do not have Bookmarking info (Pic1), But if you Enable Bookmarking in Playback rules for the type then Bookmarking is shown in details (Pic2). With this bug I want to improve MM behavior so that MM internally in library always write Bookmark information no matter if bookmarking is enabled or not, that way if user Change track type to one that have bookmark enabled or enable bookmark for the type (eg. Playback rules -> Audiobooks -> Enable/Disable bookmark) correct track bookmark value will be available immediately. image.png (17,239 bytes) image.png (17,239 bytes) image-2.png (17,394 bytes) image-2.png (17,394 bytes)